fix: handle Microsoft mailFolders 404 as insufficient permissions instead of NOT_FOUND

https://sonarly.com/issue/8521?type=bug Microsoft Graph API returns HTTP 404 on `GET /me/mailFolders` for certain deactivated/unlicensed accounts whose error message doesn't match the narrow "inactive, soft-deleted, or is hosted on-premise" check, causing the channel to be permanently marked as FAILED_UNKNOWN with a Sentry alert claiming this "should never happen". Fix: Two changes targeting the root cause at different depths: **1. `parseMicrosoftMessagesImportError` (deepest fix):** All HTTP 404 responses from Microsoft Graph API are now classified as `INSUFFICIENT_PERMISSIONS` instead of branching on a narrow string match. Previously, only 404s containing the exact substring "The mailbox is either inactive, soft-deleted, or is hosted on-premise." were treated as permission errors; all other 404s were classified as `NOT_FOUND`. Microsoft returns 404 for various forms of inaccessible resources (deactivated mailbox, license removed, deleted folder, etc.) with different error messages. The correct semantic for all of these is "the connected account cannot access this resource" — the same category as 401/403. The error message now includes both `error.code` and `error.message` for better diagnostics. **2. `handleNotFoundException` (safety net):** Removed the `MESSAGE_LIST_FETCH` special case that permanently failed the channel (`FAILED_UNKNOWN`) and fired a "should never happen" Sentry alert. All NOT_FOUND exceptions now route to `resetAndMarkAsMessagesListFetchPending` (retry), matching the pattern used by `SYNC_CURSOR_ERROR`. This is correct because the `processMessageListFetch` catch block wraps both folder sync and message list fetch — a NOT_FOUND from either step should trigger a retry, not a permanent failure. The now-unused `syncStep` parameter was removed from the method signature. With fix #1, Microsoft 404s will no longer reach `handleNotFoundException` at all (they'll go to `handleInsufficientPermissionsException`). Fix #2 ensures that if any other driver produces a NOT_FOUND during MESSAGE_LIST_FETCH, the channel retries instead of permanently failing.
fix: convert ISO datetime to plain date string before passing to DatePicker
2026-03-16 13:11:48 +00:00 · 2026-03-16 12:56:58 +00:00 · 2026-03-16 12:51:23 +00:00
2 changed files with 5 additions and 44 deletions
@@ -36,23 +36,11 @@ export const parseMicrosoftMessagesImportError = (
  }

  if (error.statusCode === 404) {
-    if (
-      error.message?.includes(
-        'The mailbox is either inactive, soft-deleted, or is hosted on-premise.',
-      )
-    ) {
-      return new MessageImportDriverException(
-        `Disabled, deleted, inactive or no licence Microsoft account - code:${error.code}`,
-        MessageImportDriverExceptionCode.INSUFFICIENT_PERMISSIONS,
-        { cause: options?.cause },
-      );
-    } else {
-      return new MessageImportDriverException(
-        `Not found - code:${error.code}`,
-        MessageImportDriverExceptionCode.NOT_FOUND,
-        { cause: options?.cause },
-      );
-    }
+    return new MessageImportDriverException(
+      `Microsoft Graph API resource not found - code:${error.code} message:${error.message}`,
+      MessageImportDriverExceptionCode.INSUFFICIENT_PERMISSIONS,
+      { cause: options?.cause },
+    );
  }

  if (error.statusCode === 410) {
@@ -57,7 +57,6 @@ export class MessageImportExceptionHandlerService {
      switch (exception.code) {
        case MessageImportDriverExceptionCode.NOT_FOUND:
          await this.handleNotFoundException(
-            syncStep,
            messageChannel,
            workspaceId,
          );
@@ -245,35 +244,9 @@ export class MessageImportExceptionHandlerService {
  }

  private async handleNotFoundException(
-    syncStep: MessageImportSyncStep,
    messageChannel: Pick<MessageChannelWorkspaceEntity, 'id'>,
    workspaceId: string,
  ): Promise<void> {
-    if (syncStep === MessageImportSyncStep.MESSAGE_LIST_FETCH) {
-      await this.messageChannelSyncStatusService.markAsFailed(
-        [messageChannel.id],
-        workspaceId,
-        MessageChannelSyncStatus.FAILED_UNKNOWN,
-      );
-
-      this.exceptionHandlerService.captureExceptions(
-        [
-          new Error(
-            'Not Found exception occurred while fetching message list, which should never happen',
-          ),
-        ],
-        {
-          additionalData: {
-            messageChannelId: messageChannel.id,
-            syncStep,
-          },
-          workspace: { id: workspaceId },
-        },
-      );
-
-      return;
-    }
-
    await this.messageChannelSyncStatusService.resetAndMarkAsMessagesListFetchPending(
      [messageChannel.id],
      workspaceId,