Sonarly Claude Code fd259d6b9d Fix: Add isBuildUpToDate check before logic function execution in workflow path
https://sonarly.com/issue/29664?type=bug

When a workflow executes a CODE step, the `CodeWorkflowAction` calls `LogicFunctionExecutorService.execute()` which proceeds directly to `LambdaDriver.execute()` and attempts to read the compiled JavaScript from S3 via `getBuiltCode()`. Neither the workflow action nor the executor service checks the `isBuildUpToDate` flag on the logic function before attempting execution. If the logic function's source code has never been compiled (or was modified since last compile), no built artifact exists in S3, and the S3 driver throws `FileStorageException('File not found', FILE_NOT_FOUND)`.

The GraphQL execution path (`LogicFunctionFromSourceService.executeOneFromSource()`) correctly checks `flatLogicFunction.isBuildUpToDate` and triggers `buildOneFromSource()` before executing. The workflow path bypasses this entirely.

Fix: Added a `LOGIC_FUNCTION_NOT_BUILT` exception code and an `isBuildUpToDate` check in `LogicFunctionExecutorService.execute()`.

When a logic function's source code is created or updated, `isBuildUpToDate` is set to `false` and no built artifact exists in S3. The GraphQL execution path (`executeOneFromSource`) checks this flag and triggers a build first. However, the workflow path (`CodeWorkflowAction → LogicFunctionExecutorService.execute() → LambdaDriver.execute()`) did not check this flag, leading to a cryptic S3 "File not found" error when `getBuiltCode()` tried to read the non-existent built file.

The fix adds validation in `LogicFunctionExecutorService.execute()` — immediately after fetching the flat logic function entity, it checks `isBuildUpToDate`. If false, it throws a `LogicFunctionExecutionException` with the new `LOGIC_FUNCTION_NOT_BUILT` code and a clear message explaining the function needs to be built first.

This protects all callers of the executor (workflow actions, route triggers, future integrations) from hitting the cryptic S3 error. The existing route trigger error mapper handles unmapped codes by falling through to `LOGIC_FUNCTION_EXECUTION_ERROR` (500), which is correct behavior.

Note: The pre-flight build in `RunWorkflowJob.startWorkflowExecution` (`buildCodeStepsFromSourceForSteps`) is supposed to build unbuilt code steps before execution, but has a silent failure path — it skips the build without logging when `applicationUniversalIdentifier` cannot be resolved. This new check is defense-in-depth for when that pre-flight build fails silently.
2026-04-22 08:40:30 +00:00

We're live on Product Hunt — Support us

Twenty logo

The #1 Open-Source CRM

Website · Documentation · Roadmap · Discord · Figma

Twenty banner


Why Twenty

Twenty gives technical teams the building blocks for a custom CRM that meets complex business needs and quickly adapts as the business evolves. Twenty is the CRM you build, ship, and version like the rest of your stack.

Learn more about why we built Twenty


Installation

Cloud

The fastest way to get started. Sign up at twenty.com and spin up a workspace in under a minute, with no infrastructure to manage and always up to date.

Build an app

Scaffold a new app with the Twenty CLI:

npx create-twenty-app my-app

Define objects, fields, and views as code:

import { defineObject, FieldType } from 'twenty-sdk/define';

export default defineObject({
  nameSingular: 'deal',
  namePlural: 'deals',
  labelSingular: 'Deal',
  labelPlural: 'Deals',
  fields: [
    { name: 'name', label: 'Name', type: FieldType.TEXT },
    { name: 'amount', label: 'Amount', type: FieldType.CURRENCY },
    { name: 'closeDate', label: 'Close Date', type: FieldType.DATE_TIME },
  ],
});

Then ship it to your workspace:

npx twenty deploy

See the app development guide for objects, views, agents, and logic functions.

Self-hosting

Run Twenty on your own infrastructure with Docker Compose, or contribute locally via the local setup guide.



Everything you need

Twenty gives you the building blocks of a modern CRM (objects, views, workflows, and agents) and lets you extend them as code. Here's a tour of what's in the box.

Want to go deeper? Read the User Guide for product walkthroughs, or the Documentation for developer reference.

Create your apps

Learn more about apps in doc

Stay on top with version control

Learn more about version control in doc

All the tools you need to build anything

Learn more about primitives in doc

Customize your layouts

Learn more about layouts in doc

AI agents and chats

Learn more about AI in doc

Plus all the tools of a good CRM

Learn more about CRM features in doc


Stack

Thanks

Chromatic      Greptile      Sentry      Crowdin

Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).

Join the Community

Star the repo · Discord · Feature requests · Releases · X · LinkedIn · Crowdin · Contribute

Languages
TypeScript 78%
MDX 18.5%
JavaScript 3.1%
Python 0.2%