Sonarly Claude Code fa1f51f802 fix(rest-api): handle mixed bare filters and conjunctions in filter parser
https://sonarly.com/issue/32412?type=bug

The REST API filter parser's `addDefaultConjunctionIfMissing` function uses a naive heuristic — checking for the presence of any parentheses — to decide whether to wrap the filter in a default `and()` conjunction. When a filter mixes bare conditions with explicit conjunctions (e.g., `status[eq]:'TODO',and(title[ilike]:'%test%')`), the parentheses from the nested conjunction trick the function into thinking a root conjunction already exists, causing the entire filter string to be parsed as a single base filter and producing a 400 error.

Fix: **What changed:** Replaced the naive parentheses-presence heuristic in `addDefaultConjunctionIfMissing` with the same regex pattern used by `parseFilter` to detect a root-level conjunction.

**Before:** The function checked `filterQuery.includes('(') && filterQuery.includes(')')`. If the filter contained *any* parentheses (e.g. from a nested `and(...)` or `or(...)`), it assumed a root conjunction already existed and returned the input unchanged. This meant `status[eq]:'TODO',and(title[ilike]:'%test%')` was NOT wrapped, causing a parse failure downstream.

**After:** The function checks `^(or|and|not)\((.+)\)$` — the exact same regex `parseFilter` uses to detect a root conjunction. This correctly identifies that `status[eq]:'TODO',and(title[ilike]:'%test%')` does NOT start with a root conjunction and wraps it in `and(...)`.

**Files changed:**
1. `add-default-conjunction.util.ts` — Replaced `includes('(')` check with `ROOT_CONJUNCTION_REGEX.test()` using the same regex pattern as `parseFilter`.
2. `__tests__/add-default-conjunction.util.spec.ts` — Added 5 test cases covering: mixed bare filters with nested conjunctions (the reported bug), `or` and `not` root conjunctions, and multiple bare filters without parentheses.
2026-04-29 10:46:13 +00:00
2025-08-07 17:02:12 +02:00

Twenty logo

The #1 Open-Source CRM

Website · Documentation · Roadmap · Discord · Figma

Twenty banner


Why Twenty

Twenty gives technical teams the building blocks for a custom CRM that meets complex business needs and quickly adapts as the business evolves. Twenty is the CRM you build, ship, and version like the rest of your stack.

Learn more about why we built Twenty


Installation

Cloud

The fastest way to get started. Sign up at twenty.com and spin up a workspace in under a minute, with no infrastructure to manage and always up to date.

Build an app

Scaffold a new app with the Twenty CLI:

npx create-twenty-app my-app

Define objects, fields, and views as code:

import { defineObject, FieldType } from 'twenty-sdk/define';

export default defineObject({
  nameSingular: 'deal',
  namePlural: 'deals',
  labelSingular: 'Deal',
  labelPlural: 'Deals',
  fields: [
    { name: 'name', label: 'Name', type: FieldType.TEXT },
    { name: 'amount', label: 'Amount', type: FieldType.CURRENCY },
    { name: 'closeDate', label: 'Close Date', type: FieldType.DATE_TIME },
  ],
});

Then ship it to your workspace:

npx twenty deploy

See the app development guide for objects, views, agents, and logic functions.

Self-hosting

Run Twenty on your own infrastructure with Docker Compose, or contribute locally via the local setup guide.



Everything you need

Twenty gives you the building blocks of a modern CRM (objects, views, workflows, and agents) and lets you extend them as code. Here's a tour of what's in the box.

Want to go deeper? Read the User Guide for product walkthroughs, or the Documentation for developer reference.

Create your apps

Learn more about apps in doc

Stay on top with version control

Learn more about version control in doc

All the tools you need to build anything

Learn more about primitives in doc

Customize your layouts

Learn more about layouts in doc

AI agents and chats

Learn more about AI in doc

Plus all the tools of a good CRM

Learn more about CRM features in doc


Stack

Thanks

Chromatic      Greptile      Sentry      Crowdin

Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).

Join the Community

Star the repo · Discord · Feature requests · Releases · X · LinkedIn · Crowdin · Contribute

Languages
TypeScript 78%
MDX 18.5%
JavaScript 3.1%
Python 0.2%