sonarly-bot ded636a02f fix(upgrade): guard role permission flag relation before 2.6
https://sonarly.com/issue/39738?type=bug

Cross-upgrade from 2.4.0 to 2.7.3 can abort in workspace cache recomputation before 2.6 migrations run. The crash blocks upgrade completion and leaves the workspace unusable in the upgraded runtime.

Fix: Implemented a surgical fix in the role-permission cache path to handle cross-upgrade transitional data safely.

### What changed
1. **Restored null-safe fallback in cache permission check**
   - File: `packages/twenty-server/src/engine/metadata-modules/role/services/workspace-roles-permissions-cache.service.ts`
   - In `hasSettingsGatedObjectPermissions(...)`, replaced unsafe direct dereference:
     - `rolePermissionFlag.permissionFlag.universalIdentifier`
   - With upgrade-safe fallback:
     - `(rolePermissionFlag.permissionFlag?.universalIdentifier ?? SystemPermissionFlag[rolePermissionFlag.flag])`
   - This prevents null/undefined dereference when upgrade-aware relation stripping removes `permissionFlag` before 2.6 while still correctly resolving permission grants from legacy `flag`.

2. **Added regression test for stripped relation scenario**
   - File: `packages/twenty-server/src/engine/metadata-modules/role/services/__tests__/workspace-roles-permissions-cache.service.spec.ts`
   - Added test:
     - `"should grant all record permissions from legacy flag when permissionFlag relation is unavailable"`
   - The test mocks a `RolePermissionFlagEntity` with only legacy `flag` and no `permissionFlag` relation, and asserts workspace-member permissions are granted as expected.

### Existing-fix check performed
- Ran:
  - `git log --all --oneline --since='30 days ago' -- packages/twenty-server/src/engine/metadata-modules/role/services/workspace-roles-permissions-cache.service.ts`
- Reviewed recent commits touching this file (including `d13cc7c...`, `db0547f...`, `3c78436...`).
- No newer commit in that window already applying this exact null-safe fallback in the affected cache path.

Authored by Sonarly by autonomous analysis (run 45292).
2026-05-22 11:30:04 +00:00
2025-08-07 17:02:12 +02:00
2026-05-21 13:35:35 +02:00
2026-05-20 15:12:39 +00:00

Twenty logo

The #1 Open-Source CRM

Website · Documentation · Roadmap · Discord · Figma

Twenty banner


Why Twenty

Twenty gives technical teams the building blocks for a custom CRM that meets complex business needs and quickly adapts as the business evolves. Twenty is the CRM you build, ship, and version like the rest of your stack.

Learn more about why we built Twenty


Installation

Cloud

The fastest way to get started. Sign up at twenty.com and spin up a workspace in under a minute, with no infrastructure to manage and always up to date.

Build an app

Scaffold a new app with the Twenty CLI:

npx create-twenty-app my-app

Define objects, fields, and views as code:

import { defineObject, FieldType } from 'twenty-sdk/define';

export default defineObject({
  nameSingular: 'deal',
  namePlural: 'deals',
  labelSingular: 'Deal',
  labelPlural: 'Deals',
  fields: [
    { name: 'name', label: 'Name', type: FieldType.TEXT },
    { name: 'amount', label: 'Amount', type: FieldType.CURRENCY },
    { name: 'closeDate', label: 'Close Date', type: FieldType.DATE_TIME },
  ],
});

Then ship it to your workspace:

npx twenty app:publish --private

See the app development guide for objects, views, agents, and logic functions.

Self-hosting

Run Twenty on your own infrastructure with Docker Compose, or contribute locally via the local setup guide.



Everything you need

Twenty gives you the building blocks of a modern CRM (objects, views, workflows, and agents) and lets you extend them as code. Here's a tour of what's in the box.

Want to go deeper? Read the User Guide for product walkthroughs, or the Documentation for developer reference.

Create your apps

Learn more about apps in doc

Stay on top with version control

Learn more about version control in doc

All the tools you need to build anything

Learn more about primitives in doc

Customize your layouts

Learn more about layouts in doc

AI agents and chats

Learn more about AI in doc

Plus all the tools of a good CRM

Learn more about CRM features in doc


Stack

Thanks

Chromatic      Greptile      Sentry      Crowdin

Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).

Join the Community

Star the repo · Discord · Feature requests · Releases · X · LinkedIn · Crowdin · Contribute

Languages
TypeScript 78%
MDX 18.5%
JavaScript 3.1%
Python 0.2%