Sonarly Claude Code
d09863c13a
https://sonarly.com/issue/5117?type=bug Editing a percentage-type number field (e.g., Opportunity probability) and clicking outside throws an unhandled error because the validation strips "%" but the subsequent cast receives the raw value still containing "%". Fix: The fix is a one-line change in `NumberFieldInput.tsx`: pass `newValueEscaped` (the `%`-stripped value) to `castAsNumberOrNull` instead of `newValue` (the raw user input that may contain `%`). **Before:** ```typescript file=packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/NumberFieldInput.tsx lines=29-36 if (fieldDefinition?.metadata?.settings?.type === 'percentage') { const newValueEscaped = newValue.replaceAll('%', ''); if (!canBeCastAsNumberOrNull(newValueEscaped)) { // ✅ validates "75" return { success: false }; } const castedValue = castAsNumberOrNull(newValue); // ❌ casts "75%" — throws! ``` **After:** ```typescript file=packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/input/components/NumberFieldInput.tsx lines=29-36 if (fieldDefinition?.metadata?.settings?.type === 'percentage') { const newValueEscaped = newValue.replaceAll('%', ''); if (!canBeCastAsNumberOrNull(newValueEscaped)) { // ✅ validates "75" return { success: false }; } const castedValue = castAsNumberOrNull(newValueEscaped); // ✅ casts "75" ``` The validation guard on line 32 already correctly used `newValueEscaped`, so the cast on line 36 must use the same variable. Previously, the guard would pass for `"75%"` (because it validated the escaped `"75"`), but then `castAsNumberOrNull("75%")` would be called — and since `+"75%"` evaluates to `NaN`, it would throw `Error: Cannot cast to number or null`. Now both the validation and the cast operate on the same `%`-stripped value, eliminating the mismatch.
The #1 Open-Source CRM
🌐 Website · 📚 Documentation · 
Roadmap · 
Discord · 
Figma
Installation
See: 🚀 Self-hosting 🖥️ Local Setup
Why Twenty
We built Twenty for three reasons:
CRMs are too expensive, and users are trapped. Companies use locked-in customer data to hike prices. It shouldn't be that way.
A fresh start is required to build a better experience. We can learn from past mistakes and craft a cohesive experience inspired by new UX patterns from tools like Notion, Airtable or Linear.
We believe in Open-source and community. Hundreds of developers are already building Twenty together. Once we have plugin capabilities, a whole ecosystem will grow around it.
What You Can Do With Twenty
Please feel free to flag any specific needs you have by creating an issue.
Below are a few features we have implemented to date:
- Personalize layouts with filters, sort, group by, kanban and table views
- Customize your objects and fields
- Create and manage permissions with custom roles
- Automate workflow with triggers and actions
- Emails, calendar events, files, and more
Personalize layouts with filters, sort, group by, kanban and table views
Customize your objects and fields
Create and manage permissions with custom roles
Automate workflow with triggers and actions
Emails, calendar events, files, and more
Stack
- TypeScript
- Nx
- NestJS, with BullMQ, PostgreSQL, Redis
- React, with Jotai, Linaria and Lingui
Thanks
Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).
Join the Community
- Star the repo
- Subscribe to releases (watch -> custom -> releases)
- Follow us on Twitter or LinkedIn
- Join our Discord
- Improve translations on Crowdin
- Contributions are, of course, most welcome!