sonarly-bot
c07ad2fef7
https://sonarly.com/issue/41751?type=bug Self-impersonation creates an invalid impersonation auth session that the app then persists, leaving the user in a broken loading state across pages until auth cookies are cleared. Fix: I implemented a backend-first fix so self-impersonation is rejected before any impersonation auth session is issued: 1) Block self-impersonation at impersonation login-token creation - In `ImpersonationService.impersonate(...)`, after loading target and impersonator workspaces, I added: - `if (toImpersonateUserWorkspace.id === impersonatorUserWorkspace.id) throw AuthException('User cannot impersonate themselves', FORBIDDEN_EXCEPTION)` - This prevents generating impersonation login tokens for self-targets. 2) Block self-impersonation at login-token exchange (defense in depth) - In `AuthResolver.validateAndLogImpersonation(...)`, I added the same user-workspace equality guard before server/workspace-level impersonation checks and before issuing impersonation access/refresh tokens. - This prevents invalid impersonation token issuance even if a legacy/self login token somehow reaches exchange. 3) Added backend test coverage - In `impersonation.service.spec.ts`, I added a test: - rejects when target and impersonator are the same user workspace - asserts no login token generation and no permission check is performed 4) Added frontend prevention in admin panel - In `SettingsAdminWorkspaceDetail.tsx`, the Impersonate button is now disabled when the listed user is the current user (`currentUser?.id === userId`) in addition to in-flight disable. - This removes the accidental self-trigger from the exposed UI path. Validation commands attempted: - `npx jest ...impersonation.service.spec.ts --config=packages/twenty-server/jest.config.mjs` - `npx nx lint:diff-with-main twenty-server` Both failed due missing installed modules in this environment (`file-type`/Nx modules not found), so I could not execute test/lint locally. Authored by Sonarly by autonomous analysis (run 47631).
The #1 Open-Source CRM
Website · 
Documentation · 
Roadmap · 
Discord · 
Figma
Why Twenty
Twenty gives technical teams the building blocks for a custom CRM that meets complex business needs and quickly adapts as the business evolves. Twenty is the CRM you build, ship, and version like the rest of your stack.
Learn more about why we built Twenty
Installation
Cloud
The fastest way to get started. Sign up at twenty.com and spin up a workspace in under a minute, with no infrastructure to manage and always up to date.
Build an app
Scaffold a new app with the Twenty CLI:
npx create-twenty-app my-app
Define objects, fields, and views as code:
import { defineObject, FieldType } from 'twenty-sdk/define';
export default defineObject({
nameSingular: 'deal',
namePlural: 'deals',
labelSingular: 'Deal',
labelPlural: 'Deals',
fields: [
{ name: 'name', label: 'Name', type: FieldType.TEXT },
{ name: 'amount', label: 'Amount', type: FieldType.CURRENCY },
{ name: 'closeDate', label: 'Close Date', type: FieldType.DATE_TIME },
],
});
Then ship it to your workspace:
npx twenty app:publish --private
See the app development guide for objects, views, agents, and logic functions.
Self-hosting
Run Twenty on your own infrastructure with Docker Compose, or contribute locally via the local setup guide.
Everything you need
Twenty gives you the building blocks of a modern CRM (objects, views, workflows, and agents) and lets you extend them as code. Here's a tour of what's in the box.
Want to go deeper? Read the 
User Guide for product walkthroughs, or the Documentation for developer reference.
|
|
|
|
|
|
Learn more about version control in docStack
TypeScript
Nx
NestJS, with BullMQ, 
PostgreSQL, 
Redis
React, with Jotai, Linaria and Lingui
Thanks
Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).
Join the Community
Star the repo · Discord · 
Feature requests · Releases · 
X · 
LinkedIn · 
Crowdin · 
Contribute