Sonarly Claude Code 6510b514db fix(server): default viewFilter value for operands that don't expect one
https://sonarly.com/issue/33956?type=bug

Installing a marketplace app that defines a view filter with an `IS_NOT_EMPTY` operand fails because the app manifest omits the `value` field (which is semantically unnecessary for that operand), but the database column `core.viewFilter.value` is NOT NULL with no default.

Fix: Three changes across 3 files to fix the NOT NULL constraint violation when installing marketplace apps with emptiness-operand view filters:

1. **`packages/twenty-shared/src/application/viewManifestType.ts`**: Made `value` optional on `ViewFilterManifest` (`value?: ViewManifestFilterValue`). Operands like `IS_NOT_EMPTY`, `IS_EMPTY`, `IS_NOT_NULL`, `IS_IN_PAST`, `IS_IN_FUTURE`, and `IS_TODAY` don't require a value, so the manifest type should reflect this. This is backwards-compatible — existing manifests that provide a value are unaffected.

2. **`packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-view-filter-manifest-to-universal-flat-view-filter.util.ts`**: Changed `value: viewFilterManifest.value` to `value: viewFilterManifest.value ?? ''` — provides an empty string default when the manifest omits the value. This follows the same `?? null` / `?? default` pattern already used for `viewFilterGroupUniversalIdentifier`, `subFieldName`, and `positionInViewFilterGroup` in the same function. Empty string satisfies the database NOT NULL constraint and is semantically correct (the value is ignored for emptiness operands).

3. **`packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/__tests__/from-view-filter-manifest-to-universal-flat-view-filter.util.spec.ts`**: Added a test case that creates a view filter with `IS_NOT_EMPTY` operand and no `value`, verifying the converter defaults to empty string.
2026-05-04 11:31:05 +00:00
2025-08-07 17:02:12 +02:00

Twenty logo

The #1 Open-Source CRM

Website · Documentation · Roadmap · Discord · Figma

Twenty banner


Why Twenty

Twenty gives technical teams the building blocks for a custom CRM that meets complex business needs and quickly adapts as the business evolves. Twenty is the CRM you build, ship, and version like the rest of your stack.

Learn more about why we built Twenty


Installation

Cloud

The fastest way to get started. Sign up at twenty.com and spin up a workspace in under a minute, with no infrastructure to manage and always up to date.

Build an app

Scaffold a new app with the Twenty CLI:

npx create-twenty-app my-app

Define objects, fields, and views as code:

import { defineObject, FieldType } from 'twenty-sdk/define';

export default defineObject({
  nameSingular: 'deal',
  namePlural: 'deals',
  labelSingular: 'Deal',
  labelPlural: 'Deals',
  fields: [
    { name: 'name', label: 'Name', type: FieldType.TEXT },
    { name: 'amount', label: 'Amount', type: FieldType.CURRENCY },
    { name: 'closeDate', label: 'Close Date', type: FieldType.DATE_TIME },
  ],
});

Then ship it to your workspace:

npx twenty deploy

See the app development guide for objects, views, agents, and logic functions.

Self-hosting

Run Twenty on your own infrastructure with Docker Compose, or contribute locally via the local setup guide.



Everything you need

Twenty gives you the building blocks of a modern CRM (objects, views, workflows, and agents) and lets you extend them as code. Here's a tour of what's in the box.

Want to go deeper? Read the User Guide for product walkthroughs, or the Documentation for developer reference.

Create your apps

Learn more about apps in doc

Stay on top with version control

Learn more about version control in doc

All the tools you need to build anything

Learn more about primitives in doc

Customize your layouts

Learn more about layouts in doc

AI agents and chats

Learn more about AI in doc

Plus all the tools of a good CRM

Learn more about CRM features in doc


Stack

Thanks

Chromatic      Greptile      Sentry      Crowdin

Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).

Join the Community

Star the repo · Discord · Feature requests · Releases · X · LinkedIn · Crowdin · Contribute

Languages
TypeScript 78%
MDX 18.5%
JavaScript 3.1%
Python 0.2%