Sonarly Claude Code
41bf13d557
https://sonarly.com/issue/22703?type=bug The `FindManyCalendarEvents` post-query hook executes 38 identical `userWorkspace` lookups and 38 `connectedAccount` queries inside a per-event loop, adding ~94ms of avoidable DB overhead per calendar page load. Fix: ## Fix: Eliminate N+1 queries in calendar event visibility restrictions The `ApplyCalendarEventsVisibilityRestrictionsService` was executing 2 DB queries per calendar event inside the visibility restriction loop: 1. `userWorkspaceRepository.findOne()` — identical every iteration (same userId + workspaceId) 2. `connectedAccountRepository.find()` — varying by calendar channel IDs With 38 events, this produced 76 individual queries (~94ms overhead). ### Changes: **`apply-calendar-events-visibility-restrictions.service.ts`:** - Hoisted `userWorkspace` lookup before the loop (it's loop-invariant — same userId/workspaceId every time) - Replaced per-event `connectedAccount` queries with a single batch query that fetches all connected accounts for ALL non-SHARE_EVERYTHING calendar channels at once, using `relations: ['calendarChannels']` to get the channel associations - Built a `Set<string>` of owned calendar channel IDs for O(1) lookup inside the loop - The loop now does pure in-memory checks (`ownedCalendarChannelIds.has()`) instead of DB queries This reduces the query count from `2 + N*2` (where N = events without SHARE_EVERYTHING) to `4` fixed queries regardless of event count. **`apply-calendar-events-visibility-restrictions.service.spec.ts`:** - Updated mock setup to match new batch query pattern (single `find` call returns connected accounts with `calendarChannels` relation) - Removed unused `mockWorkspaceMemberRepository` - All existing test cases preserved with same behavioral expectations **Note:** The messaging equivalent (`apply-messages-visibility-restrictions.service.ts`) has the same N+1 pattern but is out of scope for this fix.
The #1 Open-Source CRM
🌐 Website · 📚 Documentation · 
Roadmap · 
Discord · 
Figma
Installation
See: 🚀 Self-hosting 🖥️ Local Setup
Why Twenty
We built Twenty for three reasons:
CRMs are too expensive, and users are trapped. Companies use locked-in customer data to hike prices. It shouldn't be that way.
A fresh start is required to build a better experience. We can learn from past mistakes and craft a cohesive experience inspired by new UX patterns from tools like Notion, Airtable or Linear.
We believe in open-source and community. Hundreds of developers are already building Twenty together. Once we have plugin capabilities, a whole ecosystem will grow around it.
What You Can Do With Twenty
Please feel free to flag any specific needs you have by creating an issue.
Below are a few features we have implemented to date:
- Personalize layouts with filters, sort, group by, kanban and table views
- Customize your objects and fields
- Create and manage permissions with custom roles
- Automate workflow with triggers and actions
- Emails, calendar events, files, and more
Personalize layouts with filters, sort, group by, kanban and table views
Customize your objects and fields
Create and manage permissions with custom roles
Automate workflow with triggers and actions
Emails, calendar events, files, and more
Stack
- TypeScript
- Nx
- NestJS, with BullMQ, PostgreSQL, Redis
- React, with Jotai, Linaria and Lingui
Thanks
Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).
Join the Community
- Star the repo
- Subscribe to releases (watch -> custom -> releases)
- Follow us on Twitter or LinkedIn
- Join our Discord
- Improve translations on Crowdin
- Contributions are, of course, most welcome!