Sonarly Claude Code 3c590cb9fa fix: prevent RecordIndexFiltersToContextStoreEffect from overwriting board selection on Kanban view
https://sonarly.com/issue/17389?type=bug

A race condition between two competing effects writing to the same context store atom causes bulk updates in Kanban view to target all workspace records instead of only the selected ones, triggering thousands of unintended webhook events and data mutations.

Fix: Two changes fix the race condition where Kanban bulk edit updates all records instead of selected ones:

**1. RecordIndexContainer.tsx — Render `RecordIndexFiltersToContextStoreEffect` only on Table view (line 66)**

The effect was mounted unconditionally, causing it to write table row selection (always `[]` on Kanban) to the same `contextStoreTargetedRecordsRuleComponentState` atom that `RecordBoardSelectRecordsEffect` writes board card selection to. Background events (SSE sync, cache updates) caused the `syncWriteAtom` to recreate due to unstable array references from `selectedRowIdsComponentSelector`, triggering the cleanup which reset the selection to `{ mode: 'selection', selectedRecordIds: [] }` — wiping the board's card selection.

By only rendering this effect when `recordIndexViewType === ViewType.TABLE`, the race condition is eliminated. Kanban and Calendar views manage their own selection via `RecordBoardSelectRecordsEffect` and equivalent effects.

**2. computeContextStoreFilters.ts — Return `undefined` for empty selection (defense in depth)**

Previously, when `selectedRecordIds` was `[]` in `selection` mode, the `id.in` filter was omitted, producing a filter that matched ALL records in the workspace. Now the function returns `undefined` early when `selectedRecordIds` is empty, treating "nothing selected" as "no records to operate on" rather than "all records." This is a safety net that prevents mass unintended updates even if a similar race condition were to occur in the future.

**3. Test added** for the empty selection edge case in `computeContextStoreFilters.test.ts`.
2026-03-23 07:42:59 +00:00
2025-08-07 17:02:12 +02:00
2025-07-08 15:13:02 +02:00
2026-03-11 16:30:28 +01:00

Twenty logo

The #1 Open-Source CRM

🌐 Website · 📚 Documentation · Roadmap · Discord · Figma


Cover


Installation

See: 🚀 Self-hosting 🖥️ Local Setup

Why Twenty

We built Twenty for three reasons:

CRMs are too expensive, and users are trapped. Companies use locked-in customer data to hike prices. It shouldn't be that way.

A fresh start is required to build a better experience. We can learn from past mistakes and craft a cohesive experience inspired by new UX patterns from tools like Notion, Airtable or Linear.

We believe in open-source and community. Hundreds of developers are already building Twenty together. Once we have plugin capabilities, a whole ecosystem will grow around it.


What You Can Do With Twenty

Please feel free to flag any specific needs you have by creating an issue.

Below are a few features we have implemented to date:

Personalize layouts with filters, sort, group by, kanban and table views

Companies Kanban Views

Customize your objects and fields

Setting Custom Objects

Create and manage permissions with custom roles

Permissions

Automate workflow with triggers and actions

Workflows

Emails, calendar events, files, and more

Other Features


Stack

Thanks

Chromatic Greptile Sentry Crowdin E2B

Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).

Join the Community

Languages
TypeScript 78%
MDX 18.5%
JavaScript 3.1%
Python 0.2%