Sonarly Claude Code 174d3ff083 fix: validate ISO 8601 format before calling Temporal.Instant.from in DateTimeDisplay
https://sonarly.com/issue/21521?type=bug

The `DateTimeDisplay` component passes field values directly to `Temporal.Instant.from()` without validating they are valid ISO 8601 datetime strings, causing a `RangeError` crash when a custom object field contains non-ISO text like "JULY".

Fix: Wrapped the `Temporal.Instant.from(value)` call in a `useMemo` with a try-catch to safely handle non-ISO 8601 date strings stored in datetime fields.

**What changed:**
- Added `useMemo` import alongside existing `useContext`
- Extracted the `Temporal.Instant.from(value)` call into a memoized `instant` variable that returns `undefined` if the value is not a valid ISO 8601 instant string
- Changed the conditional render to check `instant !== undefined` instead of `isNonEmptyString(value)`

**Why this approach:**
- The `try-catch` is narrowly scoped to the specific parsing operation, not a broad error swallower — it only catches `RangeError` from `Temporal.Instant.from()` on invalid input
- Graceful degradation: when the value can't be parsed as an instant, the date text still renders (via `formatDateTimeString` which already handles invalid dates gracefully), only the timezone abbreviation is omitted
- The `useMemo` ensures the parsing only re-runs when `value` changes, matching existing patterns in sibling display components like `EmailsDisplay`, `PhonesDisplay`, and `LinksDisplay`
- This addresses the risk the original PR author (`0b5be7caa31`) explicitly called out: *"If the input is badly formatted Temporal will throw, we might want to adopt a global strategy to avoid that"*
2026-04-03 11:06:45 +00:00
2025-08-07 17:02:12 +02:00
2026-03-11 16:30:28 +01:00

Twenty logo

The #1 Open-Source CRM

🌐 Website · 📚 Documentation · Roadmap · Discord · Figma


Cover


Installation

See: 🚀 Self-hosting 🖥️ Local Setup

Why Twenty

We built Twenty for three reasons:

CRMs are too expensive, and users are trapped. Companies use locked-in customer data to hike prices. It shouldn't be that way.

A fresh start is required to build a better experience. We can learn from past mistakes and craft a cohesive experience inspired by new UX patterns from tools like Notion, Airtable or Linear.

We believe in open-source and community. Hundreds of developers are already building Twenty together. Once we have plugin capabilities, a whole ecosystem will grow around it.


What You Can Do With Twenty

Please feel free to flag any specific needs you have by creating an issue.

Below are a few features we have implemented to date:

Personalize layouts with filters, sort, group by, kanban and table views

Companies Kanban Views

Customize your objects and fields

Setting Custom Objects

Create and manage permissions with custom roles

Permissions

Automate workflow with triggers and actions

Workflows

Emails, calendar events, files, and more

Other Features


Stack

Thanks

Chromatic Greptile Sentry Crowdin E2B

Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).

Join the Community

Languages
TypeScript 78%
MDX 18.5%
JavaScript 3.1%
Python 0.2%