Sonarly Claude Code 014c8f1af8 fix(billing): skip billingPortalSession query when subscription is canceled
https://sonarly.com/issue/36227?type=bug

When a workspace's only billing subscriptions are in `Canceled` state, the frontend still fires the `BillingPortalSession` GraphQL query, causing the backend to throw `Error: missing subscription` and breaking the `/settings/billing` page.

Fix: ## Fix 1: Frontend — correct the `skip` guard (`SettingsBillingContent.tsx`)

The `BillingPortalSession` GraphQL query was guarded by `skip: !hasSubscriptions`, where `hasSubscriptions` is `true` whenever `billingSubscriptions.length > 0` — including when every subscription is `Canceled`. The backend's `computeBillingPortalSessionURLOrThrow` queries with `status: Not(SubscriptionStatus.Canceled)`, so it returns nothing and throws for workspaces whose only subscriptions are canceled.

The correct guard — `hasNotCanceledCurrentSubscription` — was already computed two lines above but was only used for UI rendering. The fix changes the `skip` condition to use this properly-filtered variable:

```diff
-    skip: !hasSubscriptions,
+    skip: !hasNotCanceledCurrentSubscription,
```

`hasSubscriptions` was only used for this `skip` prop, so it is removed entirely.

## Fix 2: Backend — replace raw `Error` throws with `BillingException` (`billing-portal.workspace-service.ts`)

The two `throw new Error(...)` calls in `computeBillingPortalSessionURLOrThrow` bypassed the billing exception infrastructure. Because they are plain `Error` instances (not `HttpException` or `BaseGraphQLError`), `shouldCaptureException` returns `true` for them and they are captured by Sentry as unexpected crashes, even though "no active subscription" is an expected business state for a canceled workspace.

Replacing them with `BillingException` using the correct codes (`BILLING_ACTIVE_SUBSCRIPTION_NOT_FOUND` → HTTP 404, `BILLING_CUSTOMER_NOT_FOUND` → HTTP 404) means the already-registered global `BillingGraphqlApiExceptionFilter` converts them to `NotFoundError` (`ErrorCode.NOT_FOUND`), which is in `graphQLErrorCodesToFilter`, so `shouldCaptureException` correctly returns `false`. No more Sentry noise for this expected state.
2026-05-08 16:43:19 +00:00
2025-08-07 17:02:12 +02:00

Twenty logo

The #1 Open-Source CRM

Website · Documentation · Roadmap · Discord · Figma

Twenty banner


Why Twenty

Twenty gives technical teams the building blocks for a custom CRM that meets complex business needs and quickly adapts as the business evolves. Twenty is the CRM you build, ship, and version like the rest of your stack.

Learn more about why we built Twenty


Installation

Cloud

The fastest way to get started. Sign up at twenty.com and spin up a workspace in under a minute, with no infrastructure to manage and always up to date.

Build an app

Scaffold a new app with the Twenty CLI:

npx create-twenty-app my-app

Define objects, fields, and views as code:

import { defineObject, FieldType } from 'twenty-sdk/define';

export default defineObject({
  nameSingular: 'deal',
  namePlural: 'deals',
  labelSingular: 'Deal',
  labelPlural: 'Deals',
  fields: [
    { name: 'name', label: 'Name', type: FieldType.TEXT },
    { name: 'amount', label: 'Amount', type: FieldType.CURRENCY },
    { name: 'closeDate', label: 'Close Date', type: FieldType.DATE_TIME },
  ],
});

Then ship it to your workspace:

npx twenty deploy

See the app development guide for objects, views, agents, and logic functions.

Self-hosting

Run Twenty on your own infrastructure with Docker Compose, or contribute locally via the local setup guide.



Everything you need

Twenty gives you the building blocks of a modern CRM (objects, views, workflows, and agents) and lets you extend them as code. Here's a tour of what's in the box.

Want to go deeper? Read the User Guide for product walkthroughs, or the Documentation for developer reference.

Create your apps

Learn more about apps in doc

Stay on top with version control

Learn more about version control in doc

All the tools you need to build anything

Learn more about primitives in doc

Customize your layouts

Learn more about layouts in doc

AI agents and chats

Learn more about AI in doc

Plus all the tools of a good CRM

Learn more about CRM features in doc


Stack

Thanks

Chromatic      Greptile      Sentry      Crowdin

Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).

Join the Community

Star the repo · Discord · Feature requests · Releases · X · LinkedIn · Crowdin · Contribute

Languages
TypeScript 78%
MDX 18.5%
JavaScript 3.1%
Python 0.2%