chore: improve monitoring for Race condition: debounced save fires while workflo

Applied the same `isReady` guard to `useUpdateWorkflowVersionTrigger`, which has the identical race condition pattern — it's called from debounced trigger save callbacks that can fire during transient workflow data loading states. Without this fix, the same "Failed to get updatable workflow version" error would generate noisy Sentry events from trigger editing flows as well. The code fix itself is the primary monitoring improvement: by preventing the throw during expected transient states, it eliminates the noisy Sentry error events (currently tagged `handled: yes, mechanism: generic`) that provide no actionable signal. The remaining throw in `getUpdatableWorkflowVersion()` still fires for genuine configuration errors (e.g., missing `workflowVisualizerWorkflowId`), preserving alerting for real bugs.
Race condition: debounced save fires while workflow data is transiently undefined during refetch
2026-03-07 10:15:04 +00:00 · 2026-03-07 10:15:03 +00:00
5 changed files with 16 additions and 3 deletions
@@ -13,6 +13,9 @@ export const useGetUpdatableWorkflowVersionOrThrow = (instanceId?: string) => {
  );
  const workflow = useWorkflowWithCurrentVersion(workflowVisualizerWorkflowId);

+  const isReady =
+    isDefined(workflowVisualizerWorkflowId) && isDefined(workflow);
+
  const getUpdatableWorkflowVersion = async (): Promise<string> => {
    if (!isDefined(workflowVisualizerWorkflowId) || !isDefined(workflow)) {
      throw new Error('Failed to get updatable workflow version');
@@ -34,5 +37,5 @@ export const useGetUpdatableWorkflowVersionOrThrow = (instanceId?: string) => {
    return draftVersionId;
  };

-  return { getUpdatableWorkflowVersion };
+  return { getUpdatableWorkflowVersion, isReady };
 };
@@ -18,6 +18,7 @@ jest.mock(
 jest.mock('@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow', () => ({
  useGetUpdatableWorkflowVersionOrThrow: () => ({
    getUpdatableWorkflowVersion: mockGetUpdatableWorkflowVersion,
+    isReady: true,
  }),
 }));

@@ -4,12 +4,16 @@ import { useUpdateWorkflowVersionStep } from '@/workflow/workflow-steps/hooks/us
 import { useStepsOutputSchema } from '@/workflow/workflow-variables/hooks/useStepsOutputSchema';

 export const useUpdateStep = () => {
-  const { getUpdatableWorkflowVersion } =
+  const { getUpdatableWorkflowVersion, isReady } =
    useGetUpdatableWorkflowVersionOrThrow();
  const { updateWorkflowVersionStep } = useUpdateWorkflowVersionStep();
  const { markStepForRecomputation } = useStepsOutputSchema();

  const updateStep = async (updatedStep: WorkflowAction) => {
+    if (!isReady) {
+      return { updatedStep: undefined };
+    }
+
    const workflowVersionId = await getUpdatableWorkflowVersion();

    const result = await updateWorkflowVersionStep({
@@ -16,6 +16,7 @@ jest.mock('@/object-record/hooks/useUpdateOneRecord', () => ({
 jest.mock('@/workflow/hooks/useGetUpdatableWorkflowVersionOrThrow', () => ({
  useGetUpdatableWorkflowVersionOrThrow: jest.fn(() => ({
    getUpdatableWorkflowVersion: mockGetUpdatableWorkflowVersion,
+    isReady: true,
  })),
 }));

@@ -9,12 +9,16 @@ import { TRIGGER_STEP_ID } from 'twenty-shared/workflow';
 export const useUpdateWorkflowVersionTrigger = () => {
  const { updateOneRecord: updateOneWorkflowVersion } = useUpdateOneRecord();

-  const { getUpdatableWorkflowVersion } =
+  const { getUpdatableWorkflowVersion, isReady } =
    useGetUpdatableWorkflowVersionOrThrow();

  const { markStepForRecomputation } = useStepsOutputSchema();

  const updateTrigger = async (updatedTrigger: WorkflowTrigger) => {
+    if (!isReady) {
+      return;
+    }
+
    const workflowVersionId = await getUpdatableWorkflowVersion();

    await updateOneWorkflowVersion({