Staled workflow runs handler lacks batching, fails when >200 runs accumulate

https://sonarly.com/issue/3797?type=bug The `WorkflowHandleStaledRunsWorkspaceService.handleStaledRunsForWorkspace()` fetches all staled workflow runs without a limit and passes all IDs to a single `update()` call, which hits the ORM's hard 200-record update limit, preventing recovery of stuck workflow runs. Fix: Replaced the unbounded `find()` + single `update()` pattern with a batched do-while loop that processes staled workflow runs in chunks of `QUERY_MAX_RECORDS` (200). **What changed:** - Added `import { QUERY_MAX_RECORDS } from 'twenty-shared/constants'` (same import used by sibling `workflow-run-enqueue.workspace-service.ts`) - Changed the `find()` call to include `select: { id: true }` and `take: QUERY_MAX_RECORDS` to limit each batch to 200 records - Wrapped the find+update in a `do-while` loop that continues fetching and updating batches until fewer than `QUERY_MAX_RECORDS` are returned (meaning all staled runs have been processed) - Added a guard so `recomputeWorkflowRunNotStartedCount` is only called if at least one record was updated **Why this works:** Each batch updates at most 200 records, staying within the `WorkspaceUpdateQueryBuilder`'s `QUERY_MAX_RECORDS` limit. After each batch is updated (status changed from `ENQUEUED` → `NOT_STARTED`), those records no longer match `getStaledRunsFindOptions()`, so the next `find()` naturally returns the next set of staled runs. This is the same pattern used by `workflow-run-enqueue.workspace-service.ts` (lines 83-98) which already works correctly in production.
Orphaned view sorts crash People page after field deactivation
2026-03-07 06:22:09 +00:00 · 2026-03-07 06:03:51 +00:00
1 changed files with 30 additions and 17 deletions
@@ -1,5 +1,7 @@
 import { Injectable, Logger } from '@nestjs/common';

+import { QUERY_MAX_RECORDS } from 'twenty-shared/constants';
+
 import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
 import { buildSystemAuthContext } from 'src/engine/twenty-orm/utils/build-system-auth-context.util';
 import {
@@ -30,25 +32,36 @@ export class WorkflowHandleStaledRunsWorkspaceService {
          { shouldBypassPermissionChecks: true },
        );

-      const staledWorkflowRuns = await workflowRunRepository.find({
-        where: getStaledRunsFindOptions(),
-      });
+      let updatedCount = 0;
+      let batchRuns: WorkflowRunWorkspaceEntity[];

-      if (staledWorkflowRuns.length <= 0) {
-        return;
+      do {
+        batchRuns = await workflowRunRepository.find({
+          where: getStaledRunsFindOptions(),
+          select: { id: true },
+          take: QUERY_MAX_RECORDS,
+        });
+
+        if (batchRuns.length === 0) {
+          break;
+        }
+
+        await workflowRunRepository.update(
+          batchRuns.map((workflowRun) => workflowRun.id),
+          {
+            enqueuedAt: null,
+            status: WorkflowRunStatus.NOT_STARTED,
+          },
+        );
+
+        updatedCount += batchRuns.length;
+      } while (batchRuns.length === QUERY_MAX_RECORDS);
+
+      if (updatedCount > 0) {
+        await this.workflowThrottlingWorkspaceService.recomputeWorkflowRunNotStartedCount(
+          workspaceId,
+        );
      }
-
-      await workflowRunRepository.update(
-        staledWorkflowRuns.map((workflowRun) => workflowRun.id),
-        {
-          enqueuedAt: null,
-          status: WorkflowRunStatus.NOT_STARTED,
-        },
-      );
-
-      await this.workflowThrottlingWorkspaceService.recomputeWorkflowRunNotStartedCount(
-        workspaceId,
-      );
    }, authContext);
  }
 }