fix: add defensive check for package.json in copyDependenciesInMemory

https://sonarly.com/issue/32080?type=bug Logic function execution fails with "File not found" error when attempting to build Lambda dependency layers because the code unconditionally downloads package.json from S3 without checking if it exists first. Upgraded workspaces lack this file entirely, causing FileStorageException. Fix: The fix implements a defensive check for the `package.json` file in `copyDependenciesInMemory()` method, preventing FileStorageException when the file is missing from S3. **Changes made:** 1. Added import for `SEED_DEPENDENCIES_DIRNAME` constant which points to the seed-dependencies directory containing default dependency files 2. Added `path` to the path module import (previously only importing `dirname` and `join`) 3. Modified `copyDependenciesInMemory()` to check if both `package.json` and `yarn.lock` exist in parallel using `Promise.all()` 4. Added conditional logic for `package.json`: if it exists in S3, download it; otherwise, copy the seed package.json from the local seed-dependencies directory 5. Kept existing conditional logic for `yarn.lock` unchanged **Why this fixes the issue:** Workspaces created before the application-system feature, or upgraded from earlier versions, do not have dependency files in S3. When logic functions are executed, the system attempts to retrieve these files. Previously, the code unconditionally tried to download `package.json` without checking if it existed first, causing FileStorageException(FILE_NOT_FOUND) which prevented the entire logic function build process. By checking file existence first and falling back to the seed package.json (which contains all necessary production dependencies), logic functions can now execute successfully on any workspace, regardless of when it was created or whether it was upgraded. This follows the exact same defensive pattern already implemented for `yarn.lock` handling and matches the reference fix that was previously developed (commit a730cf3f7d).
2026-04-28 12:50:14 +00:00
1 changed files with 36 additions and 14 deletions
@@ -2,7 +2,7 @@ import { Injectable } from '@nestjs/common';

 import crypto from 'crypto';
 import { promises as fs } from 'fs';
-import { dirname, join } from 'path';
+import path, { dirname, join } from 'path';
 import { type QueryRunner } from 'typeorm';

 import { FileFolder } from 'twenty-shared/types';
@@ -10,6 +10,7 @@ import { isDefined } from 'twenty-shared/utils';

 import { FileStorageExceptionCode } from 'src/engine/core-modules/file-storage/interfaces/file-storage-exception';

+import { SEED_DEPENDENCIES_DIRNAME } from 'src/engine/core-modules/application/application-package/constants/seed-dependencies-dirname';
 import { FileStorageService } from 'src/engine/core-modules/file-storage/file-storage.service';
 import {
  getLogicFunctionSeedProjectFiles,
@@ -257,24 +258,45 @@ export class LogicFunctionResourceService {
    workspaceId: string;
    inMemoryFolderPath: string;
  }) {
-    const yarnLockExists = await this.fileStorageService.checkFileExists({
-      workspaceId,
-      applicationUniversalIdentifier,
-      fileFolder: FileFolder.Dependencies,
-      resourcePath: 'yarn.lock',
-    });
-
-    const promises = [];
-
-    promises.push(
-      this.fileStorageService.downloadFile({
+    const [packageJsonExists, yarnLockExists] = await Promise.all([
+      this.fileStorageService.checkFileExists({
        workspaceId,
        applicationUniversalIdentifier,
        fileFolder: FileFolder.Dependencies,
        resourcePath: 'package.json',
-        localPath: join(inMemoryFolderPath, 'package.json'),
      }),
-    );
+      this.fileStorageService.checkFileExists({
+        workspaceId,
+        applicationUniversalIdentifier,
+        fileFolder: FileFolder.Dependencies,
+        resourcePath: 'yarn.lock',
+      }),
+    ]);
+
+    const promises = [];
+
+    if (packageJsonExists) {
+      promises.push(
+        this.fileStorageService.downloadFile({
+          workspaceId,
+          applicationUniversalIdentifier,
+          fileFolder: FileFolder.Dependencies,
+          resourcePath: 'package.json',
+          localPath: join(inMemoryFolderPath, 'package.json'),
+        }),
+      );
+    } else {
+      const packageJsonPath = join(inMemoryFolderPath, 'package.json');
+
+      promises.push(
+        fs.mkdir(dirname(packageJsonPath), { recursive: true }).then(() =>
+          fs.copyFile(
+            path.join(SEED_DEPENDENCIES_DIRNAME, 'package.json'),
+            packageJsonPath,
+          ),
+        ),
+      );
+    }

    if (yarnLockExists) {
      promises.push(