Compare commits

...

3 Commits

6 changed files with 10 additions and 18 deletions
@@ -78,12 +78,12 @@ export const buildDefaultFlatFieldMetadatasForCustomObject = ({
label: 'Name',
icon: 'IconAbc',
description: 'Name',
isNullable: false,
isNullable: true,
isActive: true,
isCustom: false,
isSystem: false,
isUIReadOnly: false,
defaultValue: "''",
defaultValue: null,
viewFilterIds: [],
createdAt,
@@ -57,9 +57,6 @@ export class WorkspaceMigrationFactory {
FieldMetadataType.TEXT,
{
factory: this.basicColumnActionFactory,
options: {
defaultValue: "''",
},
},
],
[FieldMetadataType.NUMERIC, { factory: this.basicColumnActionFactory }],
@@ -97,6 +97,11 @@ export const seedFeatureFlags = async ({
workspaceId: workspaceId,
value: true,
},
{
key: FeatureFlagKey.IS_NULL_EQUIVALENCE_ENABLED,
workspaceId: workspaceId,
value: true,
},
])
.execute();
};
@@ -2,4 +2,5 @@ import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/featu
export const DEFAULT_FEATURE_FLAGS = [
FeatureFlagKey.IS_WORKSPACE_MIGRATION_V2_ENABLED,
FeatureFlagKey.IS_NULL_EQUIVALENCE_ENABLED,
] as const satisfies FeatureFlagKey[];
@@ -6,10 +6,7 @@ import { CustomError, isDefined } from 'twenty-shared/utils';
import { type ImapSmtpCaldavParams } from 'src/engine/core-modules/imap-smtp-caldav-connection/types/imap-smtp-caldav-connection.type';
import { type ConnectedAccountWorkspaceEntity } from 'src/modules/connected-account/standard-objects/connected-account.workspace-entity';
import {
MessageImportDriverException,
MessageImportDriverExceptionCode,
} from 'src/modules/messaging/message-import-manager/drivers/exceptions/message-import-driver.exception';
import { MessageImportDriverExceptionCode } from 'src/modules/messaging/message-import-manager/drivers/exceptions/message-import-driver.exception';
type ConnectedAccountIdentifier = Pick<
ConnectedAccountWorkspaceEntity,
@@ -86,13 +83,6 @@ export class ImapClientProvider {
let client: ImapFlow | null = null;
let timeoutId: NodeJS.Timeout | null = null;
if (!isDefined(connectionParameters.IMAP?.username)) {
throw new MessageImportDriverException(
'Username is required',
MessageImportDriverExceptionCode.CHANNEL_MISCONFIGURED,
);
}
if (!isDefined(connectedAccount.handle)) {
throw new CustomError(
'Handle is required',
@@ -1,7 +1,6 @@
import { type FieldMetadataTypesToTestForCreateInputValidation } from 'test/integration/graphql/suites/inputs-validation/types/field-metadata-type-to-test';
import { TEST_TARGET_OBJECT_RECORD_ID_FIELD_VALUE } from 'test/integration/graphql/suites/inputs-validation/utils/setup-test-objects-with-all-field-types.util';
import { FieldMetadataType } from 'twenty-shared/types';
import { isEmptyObject } from 'twenty-shared/utils';
export const successfulCreateInputByFieldMetadataType: {
[K in Exclude<
@@ -135,7 +134,7 @@ export const successfulCreateInputByFieldMetadataType: {
rawJsonField: {},
},
validateInput: (record: Record<string, any>) => {
return isEmptyObject(record.rawJsonField);
return record.rawJsonField === null;
},
},
{