fix: respect standard object label overrides for non-English locales

https://sonarly.com/issue/14771?type=bug

When a user renames a standard object (e.g., "People" → "Contacts"), the custom name is only displayed when the UI language is English. For all other locales, the i18n-translated default name is shown instead, ignoring the user's customization.

Fix: Removed the `safeLocale === SOURCE_LOCALE` / `locale === SOURCE_LOCALE` guard from the direct override check in both `resolveObjectMetadataStandardOverride` and `resolveFieldMetadataStandardOverride`.

Previously, when a user renamed a standard object (e.g., "People" → "Contacts"), the rename was stored in `standardOverrides.labelSingular` but only returned when the locale was English (`SOURCE_LOCALE`). For any other locale, the code skipped the user's override and fell through to the i18n auto-translation of the original default name.

The fix makes the direct override check locale-independent, so user renames are respected regardless of the UI language. The priority order is now:

1. Per-locale translation overrides (`standardOverrides.translations[locale]`) — highest priority, allows per-language customization
2. Direct overrides (`standardOverrides[labelKey]`) — the user's rename, applies to ALL locales
3. i18n auto-translation of the default label — fallback

Also cleaned up the unused `SOURCE_LOCALE` import from the field metadata util, and updated both test files to assert the corrected behavior (direct overrides should be used for non-English locales).

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/__tests__/resolve-field-metadata-standard-override.util.spec.ts

@@ -262,7 +262,7 @@ describe('resolveFieldMetadataStandardOverride', () => {
       ).toBe('overridden-icon');
     });
 
-    it('should not use direct override for non-SOURCE_LOCALE', () => {
+    it('should use direct override for non-SOURCE_LOCALE', () => {
       const fieldMetadata = {
         label: 'Standard Label',
         description: 'Standard Description',
@@ -273,9 +273,6 @@ describe('resolveFieldMetadataStandardOverride', () => {
         },
       };
 
-      mockGenerateMessageId.mockReturnValue('generated-message-id');
-      mockI18n._.mockReturnValue('generated-message-id');
-
       const result = resolveFieldMetadataStandardOverride(
         fieldMetadata,
         'label',
@@ -283,7 +280,9 @@ describe('resolveFieldMetadataStandardOverride', () => {
         mockI18n,
       );
 
-      expect(result).toBe('Standard Label');
+      expect(result).toBe('Overridden Label');
+      expect(mockGenerateMessageId).not.toHaveBeenCalled();
+      expect(mockI18n._).not.toHaveBeenCalled();
     });
 
     it('should not use empty string override for SOURCE_LOCALE', () => {

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/resolve-field-metadata-standard-override.util.ts

@@ -1,6 +1,6 @@
 import { type I18n } from '@lingui/core';
 import { isNonEmptyString } from '@sniptt/guards';
-import { type APP_LOCALES, SOURCE_LOCALE } from 'twenty-shared/translations';
+import { type APP_LOCALES } from 'twenty-shared/translations';
 import { isDefined } from 'twenty-shared/utils';
 
 import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';
@@ -37,10 +37,7 @@ export const resolveFieldMetadataStandardOverride = (
     }
   }
 
-  if (
-    locale === SOURCE_LOCALE &&
-    isNonEmptyString(fieldMetadata.standardOverrides?.[labelKey])
-  ) {
+  if (isNonEmptyString(fieldMetadata.standardOverrides?.[labelKey])) {
     return fieldMetadata.standardOverrides[labelKey] ?? '';
   }
 

packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/__tests__/resolve-object-metadata-standard-override.util.spec.ts

@@ -319,7 +319,7 @@ describe('resolveObjectMetadataStandardOverride', () => {
       ).toBe('overridden-icon');
     });
 
-    it('should not use direct override for non-SOURCE_LOCALE', () => {
+    it('should use direct override for non-SOURCE_LOCALE', () => {
       const objectMetadata = {
         labelSingular: 'Standard Label',
         labelPlural: 'Standard Labels',
@@ -332,9 +332,6 @@ describe('resolveObjectMetadataStandardOverride', () => {
         },
       };
 
-      mockGenerateMessageId.mockReturnValue('generated-message-id');
-      mockI18n._.mockReturnValue('generated-message-id');
-
       const result = resolveObjectMetadataStandardOverride(
         objectMetadata,
         'labelSingular',
@@ -342,7 +339,9 @@ describe('resolveObjectMetadataStandardOverride', () => {
         mockI18n,
       );
 
-      expect(result).toBe('Standard Label');
+      expect(result).toBe('Overridden Label');
+      expect(mockGenerateMessageId).not.toHaveBeenCalled();
+      expect(mockI18n._).not.toHaveBeenCalled();
     });
 
     it('should not use undefined override for SOURCE_LOCALE', () => {

packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/resolve-object-metadata-standard-override.util.ts

@@ -45,10 +45,7 @@ export const resolveObjectMetadataStandardOverride = (
     }
   }
 
-  if (
-    safeLocale === SOURCE_LOCALE &&
-    isNonEmptyString(objectMetadata.standardOverrides?.[labelKey])
-  ) {
+  if (isNonEmptyString(objectMetadata.standardOverrides?.[labelKey])) {
     return objectMetadata.standardOverrides[labelKey] ?? '';
   }