Board view hidden field dropdown shows fields not available in column definitions lookup

https://sonarly.com/issue/7305?type=bug When a user tries to show a hidden field (like Attachments or Timeline Activities) on a Kanban board view, the handler crashes because the dropdown and the visibility handler use different, inconsistent sets of field definitions. Fix: The fix ensures the hidden fields dropdown in Kanban/board views only displays fields that the board field visibility handler can actually process. **What changed:** In `ViewFieldsHiddenDropdownSection.tsx`, the `hiddenBoardFields` array is now destructured from `useObjectOptionsForBoard` (which was already being called). When the view type is `Kanban`, the filter for `availableFieldMetadataItemsToShow` now includes an additional check: only fields whose `id` matches a `fieldMetadataId` in `hiddenBoardFields` are shown. This ensures fields excluded by `TABLE_COLUMNS_DENY_LIST` (e.g., `attachments`, `timelineActivities`) and `isLabelIdentifier` fields — which are absent from `availableColumnDefinitions` — are not displayed as clickable hidden fields. **Why this works:** `hiddenBoardFields` is computed from `availableColumnDefinitions` (lines 75-93 of `useObjectOptionsForBoard.ts`), which is the **same** source that `handleBoardFieldVisibilityChange` searches at line 178 when processing the click. This restores the consistency guarantee that existed in the old `ObjectOptionsDropdownHiddenFieldsContent` component before it was replaced in commit `c342ece2ee`. **What is NOT changed:** The table view path (`changeRecordFieldVisibility`) is unaffected because the `viewType === ViewType.Kanban` guard only applies the board-specific filter. No shared utilities or the `useObjectOptionsForBoard` hook were modified.
Unchecked findIndex(-1) in board field visibility toggle causes TypeError
2026-03-06 15:04:13 +00:00 · 2026-03-06 15:02:07 +00:00
1 changed files with 23 additions and 8 deletions
@@ -18,11 +18,12 @@ export const ViewFieldsHiddenDropdownSection = () => {
  const { changeRecordFieldVisibility } =
    useChangeRecordFieldVisibility(recordIndexId);

-  const { handleBoardFieldVisibilityChange } = useObjectOptionsForBoard({
-    objectNameSingular: objectMetadataItem.nameSingular,
-    recordBoardId: recordIndexId,
-    viewBarId: recordIndexId,
-  });
+  const { handleBoardFieldVisibilityChange, hiddenBoardFields } =
+    useObjectOptionsForBoard({
+      objectNameSingular: objectMetadataItem.nameSingular,
+      recordBoardId: recordIndexId,
+      viewBarId: recordIndexId,
+    });

  const handleChangeFieldVisibility =
    viewType === ViewType.Kanban
@@ -42,10 +43,24 @@ export const ViewFieldsHiddenDropdownSection = () => {
  });

  const availableFieldMetadataItemsToShow = activeFieldMetadataItems.filter(
-    (fieldMetadataItemToFilter) =>
-      !visibleRecordFields
+    (fieldMetadataItemToFilter) => {
+      const isAlreadyVisible = visibleRecordFields
        .map((recordField) => recordField.fieldMetadataItemId)
-        .includes(fieldMetadataItemToFilter.id),
+        .includes(fieldMetadataItemToFilter.id);
+
+      if (isAlreadyVisible) {
+        return false;
+      }
+
+      if (viewType === ViewType.Kanban) {
+        return hiddenBoardFields.some(
+          (boardField) =>
+            boardField.fieldMetadataId === fieldMetadataItemToFilter.id,
+        );
+      }
+
+      return true;
+    },
  );

  const { getIcon } = useIcons();