Fix SSE update event crash when server sends unknown fields

Wrap per-event optimistic update processing in a try-catch so that unknown fields in SSE events (e.g. avatarFile on person after schema migration) don't crash the entire event processing pipeline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-19 23:13:07 +00:00
1 changed files with 76 additions and 64 deletions
@@ -47,79 +47,91 @@ export const useTriggerOptimisticEffectFromSseUpdateEvents = () => {

        upsertRecordsInStore({ partialRecords: [updatedRecord] });

-        const computedOptimisticRecord = {
-          ...computeOptimisticRecordFromInput({
+        try {
+          const computedOptimisticRecord = {
+            ...computeOptimisticRecordFromInput({
+              cache: apolloCoreClient.cache,
+              objectMetadataItem,
+              objectMetadataItems,
+              recordInput: updatedRecord,
+              objectPermissionsByObjectMetadataId,
+              currentWorkspaceMember: null,
+            }),
+            id: updatedRecord.id,
+            __typename: getObjectTypename(objectMetadataItem.nameSingular),
+          };
+
+          const recordGqlFields = generateDepthRecordGqlFieldsFromRecord({
+            objectMetadataItem,
+            objectMetadataItems,
+            record: computedOptimisticRecord,
+            depth: 0,
+          });
+
+          const cachedRecord = getRecordFromCache({
            cache: apolloCoreClient.cache,
            objectMetadataItem,
            objectMetadataItems,
-            recordInput: updatedRecord,
+            recordId: updatedRecord.id,
+            recordGqlFields,
            objectPermissionsByObjectMetadataId,
-            currentWorkspaceMember: null,
-          }),
-          id: updatedRecord.id,
-          __typename: getObjectTypename(objectMetadataItem.nameSingular),
-        };
+          });

-        const recordGqlFields = generateDepthRecordGqlFieldsFromRecord({
-          objectMetadataItem,
-          objectMetadataItems,
-          record: computedOptimisticRecord,
-          depth: 0,
-        });
+          const cachedRecordWithConnection = getRecordNodeFromRecord({
+            record: cachedRecord,
+            objectMetadataItem,
+            objectMetadataItems,
+            recordGqlFields,
+            computeReferences: false,
+          });

-        const cachedRecord = getRecordFromCache({
-          cache: apolloCoreClient.cache,
-          objectMetadataItem,
-          objectMetadataItems,
-          recordId: updatedRecord.id,
-          recordGqlFields,
-          objectPermissionsByObjectMetadataId,
-        });
+          if (
+            !isDefined(cachedRecord) ||
+            !isDefined(cachedRecordWithConnection)
+          ) {
+            continue;
+          }

-        const cachedRecordWithConnection = getRecordNodeFromRecord({
-          record: cachedRecord,
-          objectMetadataItem,
-          objectMetadataItems,
-          recordGqlFields,
-          computeReferences: false,
-        });
+          updateRecordFromCache({
+            objectMetadataItems,
+            objectMetadataItem,
+            cache: apolloCoreClient.cache,
+            record: computedOptimisticRecord,
+            recordGqlFields,
+            objectPermissionsByObjectMetadataId,
+          });

-        if (
-          !isDefined(cachedRecord) ||
-          !isDefined(cachedRecordWithConnection)
-        ) {
-          continue;
+          const computedOptimisticRecordWithConnection =
+            getRecordNodeFromRecord({
+              record: computedOptimisticRecord,
+              objectMetadataItem,
+              objectMetadataItems,
+              recordGqlFields,
+            });
+
+          if (!isDefined(computedOptimisticRecordWithConnection)) {
+            continue;
+          }
+
+          triggerUpdateRecordOptimisticEffect({
+            cache: apolloCoreClient.cache,
+            objectMetadataItem,
+            currentRecord: cachedRecordWithConnection,
+            updatedRecord: computedOptimisticRecordWithConnection,
+            objectMetadataItems,
+            objectPermissionsByObjectMetadataId,
+            upsertRecordsInStore,
+          });
+        } catch (error) {
+          // SSE events from the server may contain fields not yet known
+          // to the frontend metadata (e.g. after a schema migration).
+          // Log a warning and continue processing remaining events.
+          console.warn(
+            'Failed to process SSE update event for record',
+            updatedRecord.id,
+            error,
+          );
        }
-
-        updateRecordFromCache({
-          objectMetadataItems,
-          objectMetadataItem,
-          cache: apolloCoreClient.cache,
-          record: computedOptimisticRecord,
-          recordGqlFields,
-          objectPermissionsByObjectMetadataId,
-        });
-
-        const computedOptimisticRecordWithConnection = getRecordNodeFromRecord({
-          record: computedOptimisticRecord,
-          objectMetadataItem,
-          objectMetadataItems,
-          recordGqlFields,
-        });
-
-        if (!isDefined(computedOptimisticRecordWithConnection)) {
-          continue;
-        }
-
-        triggerUpdateRecordOptimisticEffect({
-          cache: apolloCoreClient.cache,
-          objectMetadataItem,
-          currentRecord: cachedRecordWithConnection,
-          updatedRecord: computedOptimisticRecordWithConnection,
-          objectMetadataItems,
-          objectPermissionsByObjectMetadataId,
-          upsertRecordsInStore,
-        });
      }

      if (isNonEmptyArray(updateEvents)) {