Fix AI Chat permission error for users with restricted field access (#14799)

Closes [#1582](https://github.com/twentyhq/core-team-issues/issues/1582)
This commit is contained in:
Abdul Rahman
2025-10-01 11:21:16 +02:00
committed by GitHub
parent 4eaf87341f
commit 9d7c36e92f
@@ -15,6 +15,7 @@ import { AppPath } from 'twenty-shared/types';
import { getAppPath } from 'twenty-shared/utils';
import { In, Repository } from 'typeorm';
import { getAllSelectableFields } from 'src/engine/api/utils/get-all-selectable-fields.utils';
import { AIBillingService } from 'src/engine/core-modules/ai/services/ai-billing.service';
import { AiModelRegistryService } from 'src/engine/core-modules/ai/services/ai-model-registry.service';
import { DomainManagerService } from 'src/engine/core-modules/domain-manager/services/domain-manager.service';
@@ -25,6 +26,7 @@ import { AgentHandoffToolService } from 'src/engine/metadata-modules/agent/agent
import { AGENT_CONFIG } from 'src/engine/metadata-modules/agent/constants/agent-config.const';
import { AGENT_SYSTEM_PROMPTS } from 'src/engine/metadata-modules/agent/constants/agent-system-prompts.const';
import { type RecordIdsByObjectMetadataNameSingularType } from 'src/engine/metadata-modules/agent/types/recordIdsByObjectMetadataNameSingular.type';
import { getObjectMetadataMapItemByNameSingular } from 'src/engine/metadata-modules/utils/get-object-metadata-map-item-by-name-singular.util';
import { WorkspacePermissionsCacheService } from 'src/engine/metadata-modules/workspace-permissions-cache/workspace-permissions-cache.service';
import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager';
@@ -144,6 +146,10 @@ export class AgentExecutionService {
workspaceId: workspace.id,
});
const objectMetadataMaps =
workspaceDataSource.internalContext.objectMetadataMaps;
const objectMetadataPermissions = workspaceDataSource.permissionsPerRoleId;
const contextObject = (
await Promise.all(
recordIdsByObjectMetadataNameSingular.map(
@@ -152,14 +158,44 @@ export class AgentExecutionService {
return [];
}
const objectMetadataMapItem =
getObjectMetadataMapItemByNameSingular(
objectMetadataMaps,
recordsWithObjectMetadataNameSingular.objectMetadataNameSingular,
);
if (!objectMetadataMapItem) {
this.logger.warn(
`Object metadata not found for ${recordsWithObjectMetadataNameSingular.objectMetadataNameSingular}`,
);
return [];
}
const repository = workspaceDataSource.getRepository(
recordsWithObjectMetadataNameSingular.objectMetadataNameSingular,
false,
roleId,
);
const restrictedFields =
objectMetadataPermissions?.[roleId]?.[objectMetadataMapItem.id]
?.restrictedFields ?? {};
const hasRestrictedFields = Object.values(restrictedFields).some(
(field) => field.canRead === false,
);
const selectOptions = hasRestrictedFields
? getAllSelectableFields({
restrictedFields,
objectMetadata: { objectMetadataMapItem },
})
: undefined;
return (
await repository.find({
...(selectOptions && { select: selectOptions }),
where: {
id: In(recordsWithObjectMetadataNameSingular.recordIds),
},