fix: resolved comment in PR

This commit is contained in:
jeet1desai
2024-03-01 12:45:18 +05:30
parent ae5adaa8c8
commit 1da4d6a82c
2 changed files with 27 additions and 15 deletions
@@ -1,10 +1,10 @@
import { useTheme } from '@emotion/react';
import { css, useTheme } from '@emotion/react';
import styled from '@emotion/styled';
import { useRecoilValue } from 'recoil';
import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
import { useIcons } from '@/ui/display/icon/hooks/useIcons';
import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
import { scrollLeftState } from '@/ui/utilities/scroll/states/scrollLeftState';
import { ColumnDefinition } from '../types/ColumnDefinition';
@@ -24,7 +24,13 @@ const StyledTitle = styled.div<{ hideTitle?: boolean }>`
padding-left: ${({ theme }) => theme.spacing(2)};
padding-right: ${({ theme }) => theme.spacing(2)};
${({ hideTitle }) => hideTitle && useIsMobile() && `display: none;`}
${({ hideTitle }) =>
hideTitle &&
css`
@media (max-width: ${MOBILE_VIEWPORT}px) {
display: none;
}
`}
`;
const StyledIcon = styled.div`
@@ -51,7 +57,7 @@ export const ColumnHead = ({ isLabelIdentifier, column }: ColumnHeadProps) => {
const scrollLeft = useRecoilValue(scrollLeftState);
return (
<StyledTitle hideTitle={isLabelIdentifier && scrollLeft > 0}>
<StyledTitle hideTitle={!!isLabelIdentifier && scrollLeft > 0}>
<StyledIcon>
<Icon size={theme.icon.size.md} />
</StyledIcon>
@@ -12,6 +12,7 @@ import { LightIconButton } from '@/ui/input/button/components/LightIconButton';
import { useTrackPointer } from '@/ui/utilities/pointer-event/hooks/useTrackPointer';
import { getSnapshotValue } from '@/ui/utilities/recoil-scope/utils/getSnapshotValue';
import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
import { scrollLeftState } from '@/ui/utilities/scroll/states/scrollLeftState';
import { mapArrayToObject } from '~/utils/array/mapArrayToObject';
import { ColumnHeadWithDropdown } from './ColumnHeadWithDropdown';
@@ -71,10 +72,7 @@ const StyledColumnHeadContainer = styled.div`
`;
const StyledHeaderIcon = styled.div`
margin-bottom: ${({ theme }) => theme.spacing(1)};
margin-right: ${({ theme }) => theme.spacing(1)};
margin-top: ${({ theme }) => theme.spacing(1)};
margin-left: ${({ theme }) => theme.spacing(1.5)};
margin: ${({ theme }) => theme.spacing(1, 1, 1, 1.5)};
`;
export const RecordTableHeaderCell = ({
@@ -166,6 +164,12 @@ export const RecordTableHeaderCell = ({
onMouseUp: handleResizeHandlerEnd,
});
const isMobile = useIsMobile();
const scrollLeft = useRecoilValue(scrollLeftState);
const disableColumnResize =
column.isLabelIdentifier && isMobile && scrollLeft > 0;
return (
<StyledColumnHeaderCell
key={column.fieldMetadataId}
@@ -199,13 +203,15 @@ export const RecordTableHeaderCell = ({
</StyledHeaderIcon>
)}
</StyledColumnHeadContainer>
<StyledResizeHandler
className="cursor-col-resize"
role="separator"
onPointerDown={() => {
setResizedFieldKey(column.fieldMetadataId);
}}
/>
{!disableColumnResize && (
<StyledResizeHandler
className="cursor-col-resize"
role="separator"
onPointerDown={() => {
setResizedFieldKey(column.fieldMetadataId);
}}
/>
)}
</StyledColumnHeaderCell>
);
};