fix view update button if no filters are applied

2024-07-24 18:18:55 +05:30
3 changed files with 7 additions and 5 deletions
@@ -117,7 +117,8 @@ export const GlobalViewsAppliedFiltersRoot = observer((props: Props) => {
    });
  };

-  const areFiltersEqual = getAreFiltersEqual(appliedFilters, issueFilters, viewDetails);
+  // add a placeholder object instead of appliedFilters if it is undefined
+  const areFiltersEqual = getAreFiltersEqual(appliedFilters ?? {}, issueFilters, viewDetails);

  const isAuthorizedUser = !!currentWorkspaceRole && currentWorkspaceRole >= EUserWorkspaceRoles.MEMBER;

@@ -91,7 +91,8 @@ export const ProjectViewAppliedFiltersRoot: React.FC = observer(() => {
    );
  };

-  const areFiltersEqual = getAreFiltersEqual(appliedFilters, issueFilters, viewDetails);
+  // add a placeholder object instead of appliedFilters if it is undefined
+  const areFiltersEqual = getAreFiltersEqual(appliedFilters ?? {}, issueFilters, viewDetails);
  const viewFilters = {
    filters: cloneDeep(appliedFilters ?? {}),
    display_filters: cloneDeep(issueFilters?.displayFilters),
@@ -182,10 +182,10 @@ export const IssueFormRoot: FC<IssueFormProps> = observer((props) => {
  }, [projectId]);

  useEffect(() => {
-    if (data?.description_html) setValue("description_html" as const, data?.description_html);
+    if (data?.description_html) setValue("description_html", data?.description_html);
  }, [data?.description_html]);

-  const issueName = watch("name" as const);
+  const issueName = watch("name");

  const handleFormSubmit = async (formData: Partial<TIssue>, is_draft_issue = false) => {
    // Check if the editor is ready to discard
@@ -327,7 +327,7 @@ export const IssueFormRoot: FC<IssueFormProps> = observer((props) => {
          handleClose={() => setLabelModal(false)}
          projectId={projectId}
          onSuccess={(response) => {
-            setValue("label_ids" as const, [...watch("label_ids"), response.id]);
+            setValue("label_ids", [...watch("label_ids"), response.id]);
            handleFormChange();
          }}
        />