Udit TakkarGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>Udit TakkarUdit Takkar* feat: workflow auto translation * tests: add unit tests * refactor: tests and workflow * fix: type err * fix: type err * fix: remove redundant index on WorkflowStepTranslation The @@index on [workflowStepId, field, targetLocale] duplicates the @@unique constraint on the same columns. A unique index already provides efficient lookups, so the separate @@index adds storage overhead and write latency without benefit. Addresses Cubic AI review feedback (confidence 9/10). Co-Authored-By: unknown <> * fix: correct locale mapping when translation API returns null Map translations with their corresponding locales before filtering to preserve correct locale-to-translation associations. Previously, filtering out null translations would reindex the array, causing incorrect locale mappings when any translation in the batch failed. Also fixes pre-existing lint warnings: - Move exports to end of file - Add explicit return type to processTranslations - Replace ternary with if-else for upsertMany selection Co-Authored-By: udit@cal.com <udit222001@gmail.com> * fix: address review feedback for workflow auto-translation - Add change detection before creating translation tasks - Rename userLocale to sourceLocale in task props for clarity - Show source language in UI with new translation key - Extract SUPPORTED_LOCALES to shared translationConstants.ts - Fix locale mapping bug in translateEventTypeData.ts - Add WhatsApp translation support - Abstract translation lookup into shared translationLookup.ts helper - Restore if-else readability for SCANNING_WORKFLOW_STEPS Co-authored-by: Udit Takkar <udit.takkar@cal.com> Co-Authored-By: unknown <> * fix: update test to use sourceLocale instead of userLocale Co-Authored-By: unknown <> * refactor: feedback * fix: handle first time * fix: tests * fix: tests * fix: address Cubic AI review feedback (confidence 9/10 issues) - WhatsApp translation: Apply variable substitution using getSMSMessageWithVariables and clear contentSid when using translated body to ensure Twilio uses the translated text instead of the original template - update.handler.ts: Change sourceLocale assignment from ?? to || for consistency with tasker payload behavior (line 481) - ITranslationService.ts: Rename methods from plural to singular naming: - getWorkflowStepTranslations -> getWorkflowStepTranslation - getEventTypeTranslations -> getEventTypeTranslation Updated all call sites and tests accordingly Co-Authored-By: unknown <> * fix: address Cubic AI review feedback (confidence 9/10+ issues) - Fix getSMSMessageWithVariables to handle WHATSAPP_ATTENDEE action for locale and timezone (confidence 9/10) - Remove WhatsApp translation feature that set contentSid to undefined since Twilio ignores body parameter for WhatsApp and requires pre-approved Message Templates (confidence 10/10) Co-Authored-By: unknown <> * fix: translatio * Add tests: packages/features/eventTypeTranslation/repositories/EventTypeTranslationRepository.test.ts Generated by Paragon from proposal for PR #27087 * Add tests: packages/features/tasker/tasks/translateWorkflowStepData.test.ts Generated by Paragon from proposal for PR #27087 * chore: nit * chore: verfied atg * fix: set sourceLocale for new steps, add shouldDirty to checkbox, remove spec docs - Set sourceLocale fallback in addedSteps mapping to fix stale detection mismatch - Add { shouldDirty: true } to autoTranslateEnabled checkbox onChange - Remove specs/workflow-translation/ directory (planning docs, not for repo) Co-authored-by: Udit Takkar <udit.07.takkar@gmail.com> Co-Authored-By: unknown <> * chore: add specs back * fix: type error * fix: type error * fix: type err * fix: tests * refactor: feedback * fix: type err * refactor --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Udit Takkar <udit.takkar@cal.com> Co-authored-by: Udit Takkar <udit.07.takkar@gmail.com>
60 lines
3.3 KiB
Markdown
60 lines
3.3 KiB
Markdown
# Workflow Translation Implementation
|
|
|
|
## Status: complete
|
|
|
|
## Completed
|
|
|
|
- [x] Database schema: Added `WorkflowStepAutoTranslatedField` enum
|
|
- [x] Database schema: Added `WorkflowStepTranslation` model
|
|
- [x] Database schema: Added `autoTranslateEnabled`, `sourceLocale`, `translations` to WorkflowStep
|
|
- [x] Created WorkflowStepTranslationRepository (with DI/Prisma constructor injection)
|
|
- [x] Created translateWorkflowStepData tasker task
|
|
- [x] Integrated translation lookup in EmailWorkflowService
|
|
- [x] Integrated translation lookup in smsReminderManager
|
|
- [x] Integrated translation lookup in whatsappReminderManager
|
|
- [x] Updated workflow update handler to trigger translation
|
|
- [x] Added UI toggle in WorkflowStepContainer
|
|
- [x] Added unit tests
|
|
- [x] Created shared TranslationService with DI
|
|
|
|
## Files Changed
|
|
|
|
### New Files
|
|
|
|
- `packages/features/translation/services/TranslationService.ts` - Shared translation service
|
|
- `packages/features/translation/services/ITranslationService.ts` - Interface
|
|
- `packages/features/translation/di/tokens.ts` - DI tokens
|
|
- `packages/features/di/modules/TranslationService.ts` - DI module
|
|
- `packages/features/di/containers/TranslationService.ts` - DI container
|
|
- `packages/features/ee/workflows/repositories/WorkflowStepTranslationRepository.ts`
|
|
- `packages/features/ee/workflows/di/WorkflowStepTranslationRepository.module.ts` - DI module
|
|
- `packages/features/ee/workflows/di/WorkflowStepTranslationRepository.container.ts` - DI container
|
|
- `packages/features/tasker/tasks/translateWorkflowStepData.ts`
|
|
- `packages/features/tasker/tasks/translateWorkflowStepData.test.ts`
|
|
|
|
### Modified Files
|
|
|
|
- `packages/prisma/schema.prisma` - Added WorkflowStepTranslation model and WorkflowStep fields
|
|
- `packages/features/tasker/tasker.ts` - Register translateWorkflowStepData task
|
|
- `packages/features/tasker/tasks/index.ts` - Export translateWorkflowStepData
|
|
- `packages/features/ee/workflows/lib/service/EmailWorkflowService.ts` - Translation lookup at send time
|
|
- `packages/features/ee/workflows/lib/service/EmailWorkflowService.test.ts` - Auto translation tests
|
|
- `packages/features/ee/workflows/lib/reminders/smsReminderManager.ts` - Translation lookup
|
|
- `packages/features/ee/workflows/lib/reminders/emailReminderManager.ts` - Pass autoTranslateEnabled/sourceLocale
|
|
- `packages/features/ee/workflows/lib/scheduleBookingReminders.ts` - Pass fields to scheduleEmailReminder
|
|
- `packages/features/ee/workflows/lib/types.ts` - Added autoTranslateEnabled/sourceLocale to WorkflowStep type
|
|
- `packages/features/ee/workflows/lib/getAllWorkflows.ts` - Added fields to workflowSelect
|
|
- `packages/features/ee/workflows/lib/schema.ts` - Added fields to formSchema
|
|
- `packages/features/ee/workflows/lib/test/workflows.test.ts` - Added fields to test select
|
|
- `packages/features/ee/workflows/repositories/WorkflowReminderRepository.ts` - Added fields to findByIdIncludeStepAndWorkflow
|
|
- `packages/trpc/server/routers/viewer/workflows/update.schema.ts` - Added fields to step schema
|
|
- `packages/trpc/server/routers/viewer/workflows/update.handler.ts` - Org-only enforcement, trigger translation task
|
|
- `apps/web/modules/ee/workflows/components/WorkflowStepContainer.tsx` - UI toggle
|
|
- `apps/web/public/static/locales/en/common.json` - Translation strings
|
|
|
|
## Verification
|
|
|
|
- [ ] Run `yarn workspace @calcom/prisma db-migrate`
|
|
- [ ] Run `yarn prisma generate`
|
|
- [ ] Run `yarn type-check:ci --force`
|