Files
calendar/packages/trpc/server/routers/viewer/webhook/create.handler.ts
T
Pedro CastroGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
cb36fc201f fix: add URL validation to webhook endpoints (#26593)
Validates webhook URLs on create and update:
- HTTPS required (HTTP allowed for self-hosted and E2E)
- Blocks private IP ranges and localhost
- Blocks cloud metadata endpoints

Existing webhooks are preserved: validation only applies when URL is created or changed.

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-02-05 16:18:10 -03:00

103 lines
2.9 KiB
TypeScript

import { v4 } from "uuid";
import { PermissionCheckService } from "@calcom/features/pbac/services/permission-check.service";
import { updateTriggerForExistingBookings } from "@calcom/features/webhooks/lib/scheduleTrigger";
import { validateUrlForSSRFSync } from "@calcom/lib/ssrfProtection";
import { prisma } from "@calcom/prisma";
import type { Webhook } from "@calcom/prisma/client";
import type { Prisma } from "@calcom/prisma/client";
import { MembershipRole } from "@calcom/prisma/enums";
import { EventTypeMetaDataSchema } from "@calcom/prisma/zod-utils";
import type { TrpcSessionUser } from "@calcom/trpc/server/types";
import { TRPCError } from "@trpc/server";
import type { TCreateInputSchema } from "./create.schema";
type CreateOptions = {
ctx: {
user: NonNullable<TrpcSessionUser>;
};
input: TCreateInputSchema;
};
export const createHandler = async ({ ctx, input }: CreateOptions) => {
const { user } = ctx;
// SSRF validation for webhook URL
const validation = validateUrlForSSRFSync(input.subscriberUrl);
if (!validation.isValid) {
throw new TRPCError({
code: "BAD_REQUEST",
message: `Webhook URL is not allowed: ${validation.error}`,
});
}
const webhookData: Prisma.WebhookCreateInput = {
id: v4(),
...input,
};
if (input.platform && user.role !== "ADMIN") {
throw new TRPCError({ code: "UNAUTHORIZED" });
}
if (input.teamId) {
const permissionService = new PermissionCheckService();
const hasPermission = await permissionService.checkPermission({
userId: user.id,
teamId: input.teamId,
permission: "webhook.create",
fallbackRoles: [MembershipRole.ADMIN, MembershipRole.OWNER],
});
if (!hasPermission) {
throw new TRPCError({
code: "UNAUTHORIZED",
});
}
}
// Add userId if platform, eventTypeId, and teamId are not provided
if (!input.platform && !input.eventTypeId && !input.teamId) {
webhookData.user = { connect: { id: user.id } };
}
if (input.eventTypeId) {
const parentManagedEvt = await prisma.eventType.findFirst({
where: {
id: input.eventTypeId,
parentId: {
not: null,
},
},
select: {
parentId: true,
metadata: true,
},
});
if (parentManagedEvt?.parentId) {
const isLocked = !EventTypeMetaDataSchema.parse(parentManagedEvt.metadata)?.managedEventConfig
?.unlockedFields?.webhooks;
if (isLocked) {
throw new TRPCError({ code: "UNAUTHORIZED" });
}
}
}
let newWebhook: Webhook;
try {
newWebhook = await prisma.webhook.create({
data: webhookData,
});
} catch (error) {
// Avoid printing raw prisma error on frontend
throw new TRPCError({ code: "INTERNAL_SERVER_ERROR", message: "Failed to create webhook" });
}
await updateTriggerForExistingBookings(newWebhook, [], newWebhook.eventTriggers);
return newWebhook;
};