Udit TakkarandGitHub
7a9fdd5a0c
## What does this PR do? This PR adds https://vercel.com/blog/introducing-react-best-practices for your coding agent using `npx add-skill vercel-labs/agent-skills` command The skills are added to `.claude/`, `.cursor/`, and `.opencode/` directories to provide React and Next.js performance optimization guidance for AI-assisted workflows. ## Updates since last revision Addressed Cubic AI review feedback for issues with confidence >= 9/10: - **rerender-dependencies.md** - Replaced `console.log(user.id)` with `fetchUserDetails(user.id)` to avoid logging sensitive information - **server-after-nonblocking.md** - Removed `sessionCookie` from `logUserAction` call to avoid logging sensitive authentication data, added `await` to async call - **bundle-conditional.md** - Added `loadError` state and `setLoadError` setter to fix undefined `setEnabled` reference - **advanced-event-handler-refs.md** - Updated `useWindowEvent` handler signature to accept `Event` parameter and forward it to the stored handler - **rerender-derived-state.md** - Closed `<nav>` elements in both examples for valid JSX Fixes applied to both `.claude` and `.cursor` skill directories for consistency. ## Mandatory Tasks (DO NOT REMOVE) - [x] I have self-reviewed the code (A decent size PR without self-review might be rejected). - [x] N/A I have updated the developer docs in /docs if this PR makes changes that would require a [documentation change](https://cal.com/docs). If N/A, write N/A here and check the checkbox. - [x] N/A, I confirm automated tests are in place that prove my fix is effective or that my feature works. ## How should this be tested? These are documentation files for AI coding agents. No runtime testing required - review the markdown files to verify the example code snippets are correct. ## Checklist for human review - [ ] Verify example code snippets in the skill files are syntactically correct - [ ] Confirm the fixes don't introduce new issues in the documentation examples - [ ] Check that `.claude` and `.cursor` directories have consistent content --- Link to Devin run: https://app.devin.ai/sessions/f7f7e67fdeea4b22a4817d63ed9e1759 Requested by: unknown ()
83 lines
2.1 KiB
Markdown
83 lines
2.1 KiB
Markdown
---
|
|
title: Use Loop for Min/Max Instead of Sort
|
|
impact: LOW
|
|
impactDescription: O(n) instead of O(n log n)
|
|
tags: javascript, arrays, performance, sorting, algorithms
|
|
---
|
|
|
|
## Use Loop for Min/Max Instead of Sort
|
|
|
|
Finding the smallest or largest element only requires a single pass through the array. Sorting is wasteful and slower.
|
|
|
|
**Incorrect (O(n log n) - sort to find latest):**
|
|
|
|
```typescript
|
|
interface Project {
|
|
id: string
|
|
name: string
|
|
updatedAt: number
|
|
}
|
|
|
|
function getLatestProject(projects: Project[]) {
|
|
const sorted = [...projects].sort((a, b) => b.updatedAt - a.updatedAt)
|
|
return sorted[0]
|
|
}
|
|
```
|
|
|
|
Sorts the entire array just to find the maximum value.
|
|
|
|
**Incorrect (O(n log n) - sort for oldest and newest):**
|
|
|
|
```typescript
|
|
function getOldestAndNewest(projects: Project[]) {
|
|
const sorted = [...projects].sort((a, b) => a.updatedAt - b.updatedAt)
|
|
return { oldest: sorted[0], newest: sorted[sorted.length - 1] }
|
|
}
|
|
```
|
|
|
|
Still sorts unnecessarily when only min/max are needed.
|
|
|
|
**Correct (O(n) - single loop):**
|
|
|
|
```typescript
|
|
function getLatestProject(projects: Project[]) {
|
|
if (projects.length === 0) return null
|
|
|
|
let latest = projects[0]
|
|
|
|
for (let i = 1; i < projects.length; i++) {
|
|
if (projects[i].updatedAt > latest.updatedAt) {
|
|
latest = projects[i]
|
|
}
|
|
}
|
|
|
|
return latest
|
|
}
|
|
|
|
function getOldestAndNewest(projects: Project[]) {
|
|
if (projects.length === 0) return { oldest: null, newest: null }
|
|
|
|
let oldest = projects[0]
|
|
let newest = projects[0]
|
|
|
|
for (let i = 1; i < projects.length; i++) {
|
|
if (projects[i].updatedAt < oldest.updatedAt) oldest = projects[i]
|
|
if (projects[i].updatedAt > newest.updatedAt) newest = projects[i]
|
|
}
|
|
|
|
return { oldest, newest }
|
|
}
|
|
```
|
|
|
|
Single pass through the array, no copying, no sorting.
|
|
|
|
**Alternative (Math.min/Math.max for small arrays):**
|
|
|
|
```typescript
|
|
const numbers = [5, 2, 8, 1, 9]
|
|
const min = Math.min(...numbers)
|
|
const max = Math.max(...numbers)
|
|
```
|
|
|
|
This works for small arrays but can be slower for very large arrays due to spread operator limitations. Use the loop approach for reliability.
|