## What does this PR do? This PR adds https://vercel.com/blog/introducing-react-best-practices for your coding agent using `npx add-skill vercel-labs/agent-skills` command The skills are added to `.claude/`, `.cursor/`, and `.opencode/` directories to provide React and Next.js performance optimization guidance for AI-assisted workflows. ## Updates since last revision Addressed Cubic AI review feedback for issues with confidence >= 9/10: - **rerender-dependencies.md** - Replaced `console.log(user.id)` with `fetchUserDetails(user.id)` to avoid logging sensitive information - **server-after-nonblocking.md** - Removed `sessionCookie` from `logUserAction` call to avoid logging sensitive authentication data, added `await` to async call - **bundle-conditional.md** - Added `loadError` state and `setLoadError` setter to fix undefined `setEnabled` reference - **advanced-event-handler-refs.md** - Updated `useWindowEvent` handler signature to accept `Event` parameter and forward it to the stored handler - **rerender-derived-state.md** - Closed `<nav>` elements in both examples for valid JSX Fixes applied to both `.claude` and `.cursor` skill directories for consistency. ## Mandatory Tasks (DO NOT REMOVE) - [x] I have self-reviewed the code (A decent size PR without self-review might be rejected). - [x] N/A I have updated the developer docs in /docs if this PR makes changes that would require a [documentation change](https://cal.com/docs). If N/A, write N/A here and check the checkbox. - [x] N/A, I confirm automated tests are in place that prove my fix is effective or that my feature works. ## How should this be tested? These are documentation files for AI coding agents. No runtime testing required - review the markdown files to verify the example code snippets are correct. ## Checklist for human review - [ ] Verify example code snippets in the skill files are syntactically correct - [ ] Confirm the fixes don't introduce new issues in the documentation examples - [ ] Check that `.claude` and `.cursor` directories have consistent content --- Link to Devin run: https://app.devin.ai/sessions/f7f7e67fdeea4b22a4817d63ed9e1759 Requested by: unknown ()
81 lines
1.9 KiB
Markdown
81 lines
1.9 KiB
Markdown
---
|
|
title: Cache Repeated Function Calls
|
|
impact: MEDIUM
|
|
impactDescription: avoid redundant computation
|
|
tags: javascript, cache, memoization, performance
|
|
---
|
|
|
|
## Cache Repeated Function Calls
|
|
|
|
Use a module-level Map to cache function results when the same function is called repeatedly with the same inputs during render.
|
|
|
|
**Incorrect (redundant computation):**
|
|
|
|
```typescript
|
|
function ProjectList({ projects }: { projects: Project[] }) {
|
|
return (
|
|
<div>
|
|
{projects.map(project => {
|
|
// slugify() called 100+ times for same project names
|
|
const slug = slugify(project.name)
|
|
|
|
return <ProjectCard key={project.id} slug={slug} />
|
|
})}
|
|
</div>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct (cached results):**
|
|
|
|
```typescript
|
|
// Module-level cache
|
|
const slugifyCache = new Map<string, string>()
|
|
|
|
function cachedSlugify(text: string): string {
|
|
if (slugifyCache.has(text)) {
|
|
return slugifyCache.get(text)!
|
|
}
|
|
const result = slugify(text)
|
|
slugifyCache.set(text, result)
|
|
return result
|
|
}
|
|
|
|
function ProjectList({ projects }: { projects: Project[] }) {
|
|
return (
|
|
<div>
|
|
{projects.map(project => {
|
|
// Computed only once per unique project name
|
|
const slug = cachedSlugify(project.name)
|
|
|
|
return <ProjectCard key={project.id} slug={slug} />
|
|
})}
|
|
</div>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Simpler pattern for single-value functions:**
|
|
|
|
```typescript
|
|
let isLoggedInCache: boolean | null = null
|
|
|
|
function isLoggedIn(): boolean {
|
|
if (isLoggedInCache !== null) {
|
|
return isLoggedInCache
|
|
}
|
|
|
|
isLoggedInCache = document.cookie.includes('auth=')
|
|
return isLoggedInCache
|
|
}
|
|
|
|
// Clear cache when auth changes
|
|
function onAuthChange() {
|
|
isLoggedInCache = null
|
|
}
|
|
```
|
|
|
|
Use a Map (not a hook) so it works everywhere: utilities, event handlers, not just React components.
|
|
|
|
Reference: [How we made the Vercel Dashboard twice as fast](https://vercel.com/blog/how-we-made-the-vercel-dashboard-twice-as-fast)
|