Commit Graph
13582 Commits
Author SHA1 Message Date
sean-brydonandGitHub 4e1048b221 fix: issues found in PBAC creation (#22659) 2025-07-22 10:01:41 +01:00
Omar LópezGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>Benny Jooemrysal
cb78692347 feat: add calendar cache status and actions (#22532)
* feat: add calendar cache status dropdown

- Add updatedAt field to CalendarCache schema with migration
- Create tRPC cacheStatus endpoint for fetching cache timestamps
- Add action dropdown to CalendarSwitch for Google Calendar entries
- Display formatted last updated timestamp in dropdown
- Add placeholder for cache deletion functionality
- Include translation strings for dropdown content

The dropdown only appears for Google Calendar integrations that have
active cache entries and provides cache management options for future
extensibility.

Co-Authored-By: zomars@cal.com <zomars@me.com>

* fix: resolve Prisma type incompatibilities in repository files

- Remove problematic satisfies clause in selectedCalendar.ts
- Add missing cacheStatus parameter to ConnectedCalendarList component
- Fixes type errors that were preventing CI from passing

Co-Authored-By: zomars@cal.com <zomars@me.com>

* refactor: integrate cache status into connectedCalendars handler

- Remove separate cacheStatus tRPC endpoint as requested
- Return cache status as separate field in connectedCalendars response
- Update UI components to use cache data from connectedCalendars
- Fix Prisma type incompatibilities in repository files

Co-Authored-By: zomars@cal.com <zomars@me.com>

* fix: resolve Prisma type incompatibilities and fix data flow for cache status

- Fix Prisma.SortOrder usage in membership.ts orderBy clauses
- Remove problematic satisfies clause in selectedCalendar.ts
- Fix TeamSelect type reference in team.ts
- Update SelectedCalendarsSettingsWebWrapper to properly pass cacheStatus data flow

Co-Authored-By: zomars@cal.com <zomars@me.com>

* Discard changes to packages/lib/server/repository/membership.ts

* Discard changes to packages/lib/server/repository/team.ts

* fix: improve calendar cache dropdown with proper formatting and subscription logic

- Fix timestamp HTML entity encoding with interpolation escapeValue: false
- Only show dropdown for subscribed Google calendars (googleChannelId exists)
- Hide delete option when no cache data exists
- Include updatedAt and googleChannelId fields upstream in user repository
- Update data flow to pass subscription status through components

Co-Authored-By: zomars@cal.com <zomars@me.com>

* feat: update SelectedCalendar.updatedAt when Google webhooks trigger cache refresh

- Add updateManyByCredentialId method to SelectedCalendarRepository
- Update fetchAvailabilityAndSetCache to refresh SelectedCalendar timestamps
- Ensure webhook flow updates both CalendarCache and SelectedCalendar records
- Maintain proper timestamp tracking for calendar cache operations

Co-Authored-By: zomars@cal.com <zomars@me.com>

* Add script to automate Tunnelmole webhook setup

Introduces test-gcal-webhooks.sh to start Tunnelmole, extract the public URL, and update GOOGLE_WEBHOOK_URL in the .env file. Handles process management, rate limits, and ensures environment configuration for Google Calendar webhooks.

* Update dev:cron script to use npx tsx

Replaces 'ts-node' with 'npx tsx' in the dev:cron script for running cron-tester.ts, likely to improve compatibility or leverage tsx features.

* Update cache status string and improve CalendarSwitch UI

Renamed 'last_updated' to 'cache_last_updated' in locale file for clarity and updated CalendarSwitch to use the new string. Also added dark mode text color support for cache status display.

* refactor: move cache management to credential-level dropdown with Remove App

- Create CredentialActionsDropdown component consolidating cache and app removal actions
- Add deleteCache tRPC mutation for credential-level cache deletion
- Update connectedCalendars handler to include cacheUpdatedAt at credential level
- Move dropdown from individual CalendarSwitch to credential level in SelectedCalendarsSettingsWebWrapper
- Remove cache-related props from CalendarSwitch component
- Add translation strings for cache management actions
- Consolidate all credential-level actions (cache management + Remove App) in one dropdown

Co-Authored-By: zomars@cal.com <zomars@me.com>

* fix: remove duplicate translation keys in common.json

- Remove duplicate cache-related keys at lines 51-56
- Keep properly positioned keys later in file
- Addresses GitHub comment from zomars about duplicate keys

Co-Authored-By: zomars@cal.com <zomars@me.com>

* fix: rename translation key to cache_last_updated

- Address GitHub comment from zomars
- Rename 'last_updated' to 'cache_last_updated' for specificity
- Update usage in CredentialActionsDropdown component

Co-Authored-By: zomars@cal.com <zomars@me.com>

* fix: remove duplicate last_updated translation key

Co-Authored-By: zomars@cal.com <zomars@me.com>

* fix: add confirmation dialog for cache deletion and use repository pattern

- Add confirmation dialog for destructive cache deletion action
- Replace direct Prisma calls with CalendarCacheRepository pattern
- Add getCacheStatusByCredentialIds method to repository interface
- Fix import paths for UI components
- Address GitHub review comments from zomars

Co-Authored-By: zomars@cal.com <zomars@me.com>

* Update CredentialActionsDropdown.tsx

* Update common.json

* Update common.json

* fix: remove nested div wrapper to resolve HTML structure error

- Remove wrapping div around DisconnectIntegration component
- Fixes nested <p> tag validation error preventing Remove App functionality
- Maintains existing confirmation dialog patterns

Co-Authored-By: zomars@cal.com <zomars@me.com>

* Fix API handler response termination logic

Removed unnecessary return values after setting status in the integrations API handler. This clarifies response handling and prevents returning the response object when not needed. Resolves "API handler should not return a value, received object".

* fix: 400 is correct error code for computing slot for past booking (#22574)

* fix

* add test

* chore: release v5.5.1

* Refactor credential disconnect to use confirmation dialog

Replaces the DisconnectIntegration component with an inline confirmation dialog for removing app credentials. Adds disconnect mutation logic and updates UI to improve user experience and consistency.

* Set default value for CalendarCache.updatedAt

Added a default value of NOW() for the updatedAt column in the CalendarCache table to ensure existing and future rows have a valid timestamp. Updated the Prisma schema to reflect this change and provide compatibility for legacy data and raw inserts.

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Benny Joo <sldisek783@gmail.com>
Co-authored-by: emrysal <me@alexvanandel.com>
2025-07-22 03:57:57 +01:00
Joe Au-YeungGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>Alex van Andel
3784421f02 feat: include record IDs in Salesforce assignment reason strings (#22561)
* feat: include record IDs in Salesforce assignment reason strings

- Add recordId parameter to assignmentReasonHandler function
- Include Contact ID, Lead ID, and Account ID in assignment reason strings
- Update entire call chain to pass record IDs from CRM service
- Maintain backward compatibility with optional recordId parameter

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* fix: resolve lint warnings in assignment reason handler implementation

- Change Record<string, any> to Record<string, unknown> in BookingHandlerInput type
- Remove unused eventTypeId variable in getAttributeRoutingConfig function

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* fix: revert to Record<string, any> with ESLint disable for BookingHandlerInput

- Revert from Record<string, unknown> to Record<string, any> to maintain type compatibility
- Add ESLint disable comment to suppress no-explicit-any warning
- Maintains consistency with handleNewRecurringBooking.ts pattern

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* feat: pass CRM record ID from booker state to handleNewBooking

- Add crmRecordId field to booker store interface and initialization
- Update mapBookingToMutationInput to include record ID from booker state
- Modify handleNewBooking to extract record ID from bookingData parameter
- Add crmRecordId to BookingCreateBody schema in Prisma layer
- Follow existing pattern for CRM fields (teamMemberEmail, crmOwnerRecordType, crmAppSlug)
- Ensures record ID flows: booker store → booking form → mapBookingToMutationInput → handleNewBooking

This replaces the previous backend CRM service extraction approach with
frontend booker state approach as requested by the user.

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Pass crmRecordId as prop

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
2025-07-21 14:31:31 +00:00
Eunjae LeeandGitHub e7535b9db3 feat: add hourly booking charts on /insights (#22619)
* feat: add hourly booking charts on /insights

* safe guard

* rename

* update styles

* fix data

* clean up

* clean up

* re-order charts

* update style

* apply feedback

* rename

* update query
2025-07-21 13:52:56 +00:00
Anik Dhabal BabuGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
bb4260c98b feat: add test to verify unpublished platform orgs are excluded from credit usage (#22567)
* feat: add test to verify unpublished platform orgs are excluded from credit usage

- Add filtering logic in _getTeamWithAvailableCredits to skip unpublished platform organizations
- Add comprehensive test case that verifies user with memberships in both unpublished platform org and regular team
- Ensure only regular team is selected for credit usage, not unpublished platform org
- Test validates team.findUnique calls and credit balance checks for correct team filtering

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* Update credit-service.ts

* Update credit-service.test.ts

* fix: update test to work with repository-level filtering for unpublished platform orgs

- Remove obsolete team.findUnique mocking since filtering moved to repository layer
- Update test to mock findAllAcceptedPublishedTeamMemberships correctly
- Test now validates integration with repository-level filtering
- Maintains core validation that unpublished platform orgs are excluded from credit usage

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* docs: improve test comments to clarify repository-level filtering scenario

- Add clearer comments explaining user has memberships in both teams
- Clarify that repository method filters out unpublished platform orgs
- Better document the architectural change from PR #22600

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* docs: clarify test demonstrates user with memberships in both teams

- Add detailed comments explaining user has memberships in TWO teams initially
- Clarify that unpublished platform org (teamId: 1) and regular team (teamId: 2) scenario
- Explain repository-level filtering removes unpublished platform orgs before credit service
- Address user feedback about demonstrating two-team membership scenario

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* docs: add comprehensive comments explaining two-team filtering scenario

- Clarify that user has memberships in BOTH teams initially in database
- Explain that repository method filters out unpublished platform org (teamId: 1)
- Document that only regular team (teamId: 2) is returned to credit service
- Address user feedback about demonstrating the filtering behavior clearly
- Test validates integration with repository-level filtering from PR #22600

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* fix: update test to properly demonstrate filtering behavior

- Mock repository to return only regular team (teamId: 2) as expected after filtering
- Update credit balance mock and expectations to match teamId: 2
- Test now passes and validates that unpublished platform org is filtered out
- Address user feedback about showing correct filtering behavior in test logic

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* feat: demonstrate two-team membership scenario in test logic

- Mock repository to return both membership objects: teamId 1 and teamId 2
- Show user has memberships in both unpublished platform org and regular team
- Mock different credit states: teamId 1 has no credits/limit reached, teamId 2 has available credits
- Verify both teams are processed but only regular team (teamId 2) is selected
- Test now demonstrates actual filtering behavior in test logic, not just comments
- Addresses user feedback: 'create two membership with those two teams in that test'

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* feat: demonstrate two-team membership scenario in test logic

- Mock repository to return both membership objects: teamId 1 and teamId 2
- Show user has memberships in both unpublished platform org and regular team
- Mock different credit states: teamId 1 has no credits/limit reached, teamId 2 has available credits
- Verify both teams are processed but only regular team (teamId 2) is selected
- Test now demonstrates actual filtering behavior in test logic, not just comments
- Addresses user feedback: 'create two membership with those two teams in that test'

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* Revert "feat: demonstrate two-team membership scenario in test logic"

This reverts commit d7c4beb2a40179fb5ad14421563626a3bf287b45.

* Update credit-service.test.ts

* Update credit-service.test.ts

* Update credit-service.test.ts

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-19 14:45:19 +00:00
keithwillcode 9d65b6f794 chore: release v5.5.3 2025-07-18 22:30:47 +00:00
Joe Au-YeungGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
4874c6c2ee feat: add 2FA status column to organization members table (#22564)
* feat: add 2FA status column to organization members table

- Add twoFactorEnabled column to UserListTable with admin-only visibility
- Modify backend handler to conditionally include 2FA data for org admins
- Set column as hidden by default using initalColumnVisibility
- Use Badge component to display enabled/disabled status
- Implement proper permission checks using adminOrOwner variable

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* fix: hide 2FA column from display options for non-admin users

- Change enableHiding from true to adminOrOwner
- Prevents non-admin users from seeing 2FA column in column visibility menu
- Maintains existing cell-level permission checks for data access

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* fix: resolve CI workflow dependency mismatch for integration-test job

- Remove build job dependencies from integration-test job that were causing skipped job failures
- integration-test now depends on [changes, check-label, deps] instead of build jobs
- This fixes the 'required' check failure where skipped conditional jobs were treated as failures

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* revert: restore integration-test job dependencies as requested by keithwillcode

- Restore integration-test dependencies to [changes, check-label, build, build-api-v1, build-api-v2]
- Add conditional logic to only run integration-test when run-e2e == 'true'
- This prevents the 'required' check from failing due to skipped conditional jobs
- Addresses GitHub comment from keithwillcode requesting workflow revert

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* revert: remove conditional logic from integration-test job as requested

- Remove run-e2e condition from integration-test job
- Restore original workflow exactly as it was before any modifications
- Addresses GitHub comment from keithwillcode requesting no CI changes

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-18 20:39:59 +00:00
Eunjae LeeGitHubeunjae@cal.com <hey@eunjae.dev>Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>Keith WilliamsOmar López
30a92a4d66 chore(eslint): add no-this-in-static-method rule to prevent context loss (#22410)
Co-authored-by: eunjae@cal.com <hey@eunjae.dev>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Keith Williams <keithwillcode@gmail.com>
Co-authored-by: Omar López <zomars@me.com>
2025-07-18 13:05:53 -07:00
Udit TakkarandGitHub 04ce054cf7 fix: remove team plan check (#22628) 2025-07-18 18:14:58 +00:00
Alex van AndelandGitHub e901e8d189 perf: Prevent parse when object is empty, resulting in a truthy value (#22625) 2025-07-18 17:32:45 +00:00
Peer RichelsenGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
0aa595ddac fix: update enterprise sales URL from i.cal.com to go.cal.com (#22627)
* fix: update enterprise sales URL from i.cal.com to go.cal.com

- Update EnterprisePage contact sales button URL
- Update TeamList admin tools learn more URL
- Update platform pricing enterprise redirect URL
- Update documentation example URL
- All URLs now point to go.cal.com/enterprise

Co-Authored-By: peer@cal.com <peer@cal.com>

* Apply suggestions from code review

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-18 16:05:24 +00:00
Lauris SkraucisandGitHub 2115a045ec fix: v2 ignore permissions check for 3rd party oauth (#22588) 2025-07-18 13:53:51 +00:00
Omar LópezandGitHub f67522dbbd Fix API handler response termination logic (#22575) 2025-07-18 12:21:54 +00:00
dc5aef0dd4 feat: preview default roles permissions (#22621)
Co-authored-by: Alex van Andel <me@alexvanandel.com>
2025-07-18 12:20:19 +00:00
RomitandGitHub e1d7631215 fix: Editing RR weights adds all hosts (#22623)
* fixed

* chore

* chore
2025-07-18 12:55:52 +01:00
Hariom BalharaGitHubClaudecoderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
05e1ad0c91 fix: Code Quality improvements to response record endpoint and added unit tests (#22264)
* chore: remove unnecessary logs and fix documentation

* refactor: extract GetSlotsInputWithRouting type and eliminate code duplication

- Move GetSlotsInputWithRouting_2024_09_04 type to platform-types package for reuse
- Refactor slots service to eliminate duplicate error handling logic
- Fix TypeScript errors in slots service tests by adding missing type property
- Update test expectations to match new implementation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: improve type safety in slots service

- Export explicit types from slots-input.service for transformed queries
- Replace 'any' type with proper TransformedSlotsQuery union type
- Re-implement fetchAndFormatSlots abstraction to eliminate code duplication
- Revert unrelated console.log in router.controller.ts

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: simplify slots service implementation

- Remove intermediate variable assignment in getAvailableSlotsWithRouting
- Update test to match simplified routing parameters structure

* test: add comprehensive error handling and edge case tests for slots service

- Add error scenario tests for NotFoundException, invalid time range, and generic errors
- Add edge case tests for null/undefined parameters and empty arrays
- Improve test coverage for getAvailableSlotsWithRouting method
- Mock SlotsInputService properly to enable isolated unit testing

* 📝 CodeRabbit Chat: Rename TransformedGetSlotsQuery types to InternalGetSlotsQuery in slot services

* fix: correct import path for AvailableSlotsService in slots service test

- Fix import path from '@/lib/services/AvailableSlots' to '@/lib/services/available-slots.service'
- Resolves unit test failure due to case sensitivity/naming mismatch
- All API v2 tests now pass (9 test suites, 142 tests)

Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-18 16:26:53 +05:30
cf392562da feat: team roles ui pbac (#22585)
Co-authored-by: Eunjae Lee <hey@eunjae.dev>
2025-07-18 10:12:25 +00:00
Anik Dhabal BabuandGitHub c8de8ca681 fix: don't use unpublished org in any credit context (#22600)
* fix: don't use unpublished org for any credit context

* type error

* fix test

* update
2025-07-18 10:03:50 +00:00
Joe Au-YeungandGitHub 2c91c0e309 Use org slug in link (#22612) 2025-07-18 07:02:04 +00:00
Hariom BalharaGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
cef007d852 docs: add BrowserStack attribution to README (#22615)
Add required attribution 'This project is tested with browserstack' to README.md
for BrowserStack open source account eligibility

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-18 05:51:46 +00:00
keithwillcode 97b81d6f6b chore: release v5.5.2 2025-07-18 01:17:02 +00:00
Alex van AndelandGitHub ac117a14eb perf: Faster logic by preventing instanceof Dayjs in slots.ts (#22590)
* perf: Faster logic by preventing instanceof Dayjs in slots.ts

* Flip isSameOrAfter to isBefore as .. before
2025-07-17 17:53:34 -04:00
Joe Au-YeungGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>Alex van Andel
f85f226982 fix: Create RoutingFormResponseService to get field value from identifier (#22396)
* Make identifier required

* Fallback to null if identifier isn't present

* Type fix

* Type fixes

* Type fix

* Create `RoutingFormResponseRepository`

* Create `RoutingFormResponseService`

* Use repsotiories to find form value

* Delete console.logs

* Undo change in `ZResponseInputSchema` schema

* Type fix

* Undo changes

* fix: correct import path in RoutingFormResponseService to resolve runtime errors

- Change relative import path to use @calcom alias
- Prevents import resolution failures that cause app startup issues

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* Undo changes

* Update type

* Update typing

* Address feedback

* Address feedback

* chore: Provide a suggestion for pr 22396, new structure (#22491)

* chore: Provide a suggestion for pr 22396, new structure

* Refactor to create two create methods with bookingUid and id

* Use `createWithBookingUid`

* Extract routing form response parser to seperate util

* Added more and improved test cases

* Fix

---------

Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com>

* Factory included wrong calls

* Fix test for findFieldValueByIdentifier

* Add tests

* Fix test

* Fix test

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
2025-07-17 22:40:18 +01:00
Eunjae LeeGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
f4b48e863b fix: add missing ref parameter to SatSymbol forwardRef component (#22274)
- Fixed forwardRef render function to accept both props and ref parameters
- Added ref prop to SVG element to properly forward the ref
- Resolves React error: 'forwardRef render functions accept exactly two parameters: props and ref'

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-17 20:52:00 +00:00
Anik Dhabal BabuandGitHub 4dc22606d9 fix: create new meeting room (#22591) 2025-07-17 16:22:16 +00:00
Joe Au-YeungGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
292073eb4a feat: make Salesforce WriteToObjectSettings entries editable with save/cancel functionality (#22440)
* feat: make Salesforce WriteToObjectSettings entries editable with save/cancel functionality

- Add editingRows and editingData state to track which rows are being edited
- Implement startEditing, cancelEditing, and saveEditing functions for row-level edit management
- Replace read-only existing entries with editable fields when in edit mode
- Add save/cancel buttons with appropriate icons (check/x) for each row
- Include field name validation to prevent duplicate entries
- Maintain existing delete functionality alongside new edit capabilities
- Update action column width to accommodate save/cancel buttons

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

* fix: address Code Rabbit review feedback for WriteToObjectSettings

- Fix spread operator usage to use editData instead of prev[key]
- Add validation for empty field names
- Implement single-row editing for better UX

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-17 10:48:54 -04:00
Eunjae LeeandGitHub 1878802213 fix: update styles of charts on /insights (#22557)
* fix: update styles of charts on /insights

* clean up

* clean up

* share the same styles with ChartCardItem

* margin for event trends

* fix type error
2025-07-17 14:42:35 +00:00
9cfc74a74f fix: don't schedule reminder from the past (#22353)
* only schedule future reminders

* use new Date() instead

Co-authored-by: Alex van Andel <me@alexvanandel.com>

* use new Date() instead

Co-authored-by: Alex van Andel <me@alexvanandel.com>

* use new Date() instead

Co-authored-by: Alex van Andel <me@alexvanandel.com>

---------

Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
2025-07-17 14:33:56 +00:00
Lauris SkraucisandGitHub c472bce54f fix: v2 managed event type creation hosts (#22584)
* fix: v2 managed event type creation hosts

* refactor

* fix: test

* remove uncecessary call
2025-07-17 09:02:12 +00:00
Joe Au-YeungandGitHub a498641b61 Use WEBAPP_URL (#22568) 2025-07-17 07:29:58 +00:00
Hariom BalharaandGitHub ec58e59865 fix: Add new route to create team routing-form response again(after revert earlier) (#22407)
* Revert "revert: "fix: Add new route to create team routing-form response (#22347)" (#22399)"

This reverts commit e6c36af3b4.

* Update the documentation

* Remove versioning
2025-07-17 11:33:51 +05:30
emrysal 4f95cff70e chore: release v5.5.1 2025-07-16 22:58:49 +00:00
Benny JooandGitHub fa66f2531f fix: 400 is correct error code for computing slot for past booking (#22574)
* fix

* add test
2025-07-16 22:46:03 +00:00
Benny JooandGitHub b40d448e07 feat: migration for team booking page cache feature flag (#22566) 2025-07-16 19:34:42 +00:00
Alex van AndelGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
21add18ad8 perf: Remove isAfter/isBefore in date-ranges:subtract (#22549)
* perf: Remove isAfter/isBefore in date-ranges:subtract

* Small amend to also use valueOf here

* Addressed issue with utc offset in non-utc mode

* test: add failing test demonstrating timezone offset bug in subtract function

This test shows that when mixing UTC and timezone-aware dayjs objects,
the timezone offset adjustment (date.valueOf() + date.utcOffset() * 60000)
creates incorrect chronological comparisons that prevent proper exclusion.

The test expects 0 results but gets 6, reproducing the issue causing
futureLimit.timezone.test.ts to fail with extra time slots.

Co-Authored-By: alex@cal.com <me@alexvanandel.com>

* Fixed failing tests that proved the logic wasn't working correctly

* test: add scheduling pipeline reproduction test for futureLimit.timezone.test.ts failures

This test reproduces the exact scenario from getBusyTimes.ts that causes
the 6 extra slots (12:30-17:30 UTC) to appear in futureLimit.timezone.test.ts.

The test simulates:
- calendarBusyTimes from external calendar sources (converted to dayjs objects)
- openSeatsDateRanges from booking data with mixed timezone contexts
- The specific timezone mixing pattern that causes exclusion to fail

This demonstrates the remaining issue in the subtract function after
the timezone offset bug was fixed.

Co-Authored-By: alex@cal.com <me@alexvanandel.com>

* test: add getUserAvailability reproduction test showing subtract extends ranges instead of excluding busy times

This test reproduces the exact scenario from futureLimit.timezone.test.ts where the subtract function incorrectly extends available range end times to match busy time start times instead of properly subtracting the busy times from the available ranges.

Co-Authored-By: alex@cal.com <me@alexvanandel.com>

* test: fix getUserAvailability reproduction test to expect actual buggy behavior

The test now expects the current buggy behavior (5 ranges with 2024-06-02 missing)
instead of correct behavior, so it passes with current logic and would fail once
the subtract function is fixed to properly handle non-overlapping busy times.

Co-Authored-By: alex@cal.com <me@alexvanandel.com>

* test: fix getUserAvailability reproduction test to expect correct behavior and fail with buggy logic

The test now expects the correct behavior (ranges should remain at 12:30:00.000Z and all 6 ranges should be present) so it fails with the current buggy subtract function logic that incorrectly extends ranges to 18:30:00.000Z. Once the subtract function is fixed, this test will pass.

Co-Authored-By: alex@cal.com <me@alexvanandel.com>

* Push the valid fix for the futureLimits test failure

* test: update getUserAvailability test console output to match corrected behavior

The test now correctly expects 5 ranges (with June 2 properly excluded due to overlapping busy time) and the console output reflects this corrected behavior.

Co-Authored-By: alex@cal.com <me@alexvanandel.com>

* Remove console.log calls

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-16 12:50:35 -04:00
Eunjae LeeGitHubcubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
10fca86ddc feat: add drop off funnel chart for /insights/routing (#22106)
* feat: add Drop-off funnel chart for /insights/routing

* convert insights services to use kysely

* WIP

* implement drop-off data WIP

* updates

* revert services back to Prisma

* do not expose findMany

* WIP

* revert usage

* fix type errors

* updates

* clean up

* update playground

* update styles

* support columnFilters

* update tooltip

* add skeleton

* remove dynamic loading

* avoid using Prisma.raw

* update condition for user scope

* Update packages/features/insights/components/RoutingFunnelContent.tsx

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

* playground fix

* fix type error

* update playground

* update styles

* implement subtitle to ChartCard

* revert insights booking service

* update border

* update ChartCard style

* style updates

* convert the playground to a client component

* clean up

* apply feedback

* fix tests

* fix unit test

* hide scrollbar

---------

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
2025-07-16 16:36:41 +02:00
MorganandGitHub c2fc8774df Revert "refactor: filter out admins and owners from platform event types host…" (#22325)
This reverts commit c90fded6b7.
2025-07-16 13:59:44 +00:00
devin-ai-integration[bot]GitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>lauris@cal.com <lauris@cal.com>Lauris Skraucis
969b58f17d docs: clarify bookingFields replacement behavior in update event type input (#22554)
* docs: clarify bookingFields replacement behavior in update event type input

Update description to explain that bookingFields array completely replaces
existing fields rather than adding to them. Users must fetch existing fields
first before making modifications.

Co-Authored-By: lauris@cal.com <lauris@cal.com>

* Update update-event-type.input.ts

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: lauris@cal.com <lauris@cal.com>
Co-authored-by: Lauris Skraucis <lauris.skraucis@gmail.com>
2025-07-16 13:58:01 +00:00
devin-ai-integration[bot]GitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>anik@cal.com <anik@cal.com>Anik Dhabal Babuanik@cal.com <adhabal2002@gmail.com>
a0e25ff270 fix: eliminate flaky E2E tests by adding proper test isolation (#22488)
* fix: eliminate flaky E2E tests by adding proper test isolation

- Add targeted afterEach hooks to clean up bookings between cancel tests
- Modify cancel booking tests to create fresh data instead of relying on shared state
- Follow existing pattern from recurring-bookings.e2e-spec.ts for proper test isolation
- Fix recurring booking expectation from 4 to 3 bookings to match API behavior
- Fixes race conditions and data contamination issues in API V2 E2E suite

The specific 'should cancel recurring booking' test that was failing with 400 Bad Request
now passes consistently. Test suite improved from 34 passing to 66 passing tests.

Co-Authored-By: anik@cal.com <anik@cal.com>

* fix: replace strict host order assertion with order-agnostic matcher

- Replace exact array equality check with expect.arrayContaining()
- Fixes non-deterministic host ordering in 'should create a managed team event-type' test
- Prevents flaky failures when tests run together due to different host order

Co-Authored-By: anik@cal.com <anik@cal.com>

* fix: ensure roundRobinEventType is initialized before dependent test runs

- Add initialization check in 'should update round robin event type' test
- Creates roundRobinEventType if not already set by previous test
- Eliminates dependency on test execution order
- Fixes undefined variable errors when tests run together with other suites

Co-Authored-By: anik@cal.com <anik@cal.com>

* fix: add validation for roundRobinEventType and improve error handling in assign-all-team-members.e2e-spec.ts

- Add check to ensure roundRobinEventType is defined before dependent test runs
- Improve error handling in evaluateHost function with better error messages
- Prevents undefined variable errors when tests run together with other suites

Co-Authored-By: anik@cal.com <anik@cal.com>

* fix: remove hardcoded mandatory/priority values from evaluateHost calls

- Remove hardcoded mandatory: false, priority: 'medium' from all evaluateHost calls
- Update evaluateHost function to accept Partial<Host> for expected values
- Only validate userId field to prevent test failures when mandatory/priority are undefined
- Fixes user ID mismatch errors and mandatory field assertion failures

Co-Authored-By: anik@cal.com <anik@cal.com>

* refactor: extract managedEventType setup into reusable utility function

- Create ensureManagedEventType() utility function to eliminate code duplication
- Replace 5 instances of repetitive managedEventType setup code with utility function calls
- Maintain same functionality while reducing code duplication in teams-event-types.controller.e2e-spec.ts
- All tests continue to pass after refactoring

Co-Authored-By: anik@cal.com <anik@cal.com>

* fix: restore mandatory/priority props and exact equality assertions per review feedback

- Restore mandatory: false, priority: 'medium' props in evaluateHost calls in assign-all-team-members.e2e-spec.ts
- Change toBeGreaterThanOrEqual back to toEqual for exact count assertions in teams-event-types.controller.e2e-spec.ts
- Addresses review feedback from supalarry on PR #22488

Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

* Update Schedule.tsx

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: anik@cal.com <anik@cal.com>
Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
Co-authored-by: anik@cal.com <adhabal2002@gmail.com>
2025-07-16 13:43:06 +00:00
Lauris SkraucisandGitHub df30f5c703 fix: v2 dev (#22552) 2025-07-16 12:53:05 +00:00
Anik Dhabal BabuandGitHub fb59342de4 fix: Show the Stripe payment error message and change the status to 400 for charge card issues (#22463)
* fix: show stripe payment error message

* Update PaymentService.ts

* Update chargeCard.handler.ts

* Update chargeCard.handler.ts

* Update PaymentService.ts

* update

* update
2025-07-16 09:45:49 +00:00
Joe Au-YeungandGitHub a84e8987cb Add identifiers to log (#22537) 2025-07-16 02:42:04 +00:00
Benny JooandGitHub c4eda5f21d perf: caching + modularize data fetching for team booking pages (#22172)
* wip

* wip

* wip

* refactor

* refactor

* refactor

* refactor

* refactor

* fix

* better

* fix

* fix

* use notFound

* refactor

* wip

* refactor

* wip

* refactor

* wip

* wip

* finalize

* wip

* fix

* lots of refactors

* better code

* clean up

* fix

* fix type checks

* finalize

* select more fields

* select more fields

* fix

* fix

* fix

* fix

* better

* better

* fix

* fix

* fix

* fix

* add back comment

* fix

* better

* fix

* refactor

* fix

* fix type check

* add comment

* fix

* wip

* wip

* add more comment

* refactor

* rename

* refactors

* fix reschedule logic

* remove hard-coded true from isCachedEnabled

* better

* use revalidateTeamDataCache in team profile update

* fix invalidation

* better comment

* refactors

* add better comments

* add revalidations

* add comments

* fix

* remove hard code

* fix

* update tags

* use features package

* fix type check
2025-07-15 21:42:55 -03:00
Benny JooandGitHub e6da5c85e0 perf: remove me fetching from teams by refactoring (#22444) 2025-07-15 23:23:34 +00:00
Joe Au-YeungandGitHub bfc6d6e1e9 Change log (#22534) 2025-07-15 17:45:20 +00:00
10bf982028 feat: add setting to automatic start recording (#21853)
* feat: disable transcription setting in cal video

* feat: add enable automatic recording feature

* chore: only when organizer joins

* chore: update name of variable

* fix: improvements

* chore: improvements

* chore: add badge

* refactor: cal video premium

* tests: add tests for cal video

* fix: use isOrganizer

* Simplify type to remove 'as SessionUser' from new code

---------

Co-authored-by: Benny Joo <sldisek783@gmail.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
2025-07-15 16:54:23 +01:00
Eunjae LeeandGitHub 8ee7b12c2b docs: add review rules for agents (#22527) 2025-07-15 13:40:01 +00:00
afe5fea6eb fix: improve restriction schedule description (#22517)
* fix description

* add back isRestrictionScheduleEnabled

---------

Co-authored-by: CarinaWolli <wollencarina@gmail.com>
2025-07-15 14:22:56 +02:00
emrysal 5854de3c23 chore: release v5.5.0 2025-07-15 09:57:23 +00:00
Eunjae LeeGitHubDevin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
967442892a feat: convert InsightsBookingService to use Prisma.sql raw queries (#22345)
* fix: use raw query at InsightsBookingService

* feat: convert InsightsBookingService to use Prisma.sql raw queries

- Convert auth conditions from Prisma object notation to Prisma.sql
- Convert filter conditions from Prisma object notation to Prisma.sql
- Update return types from Prisma.BookingTimeStatusDenormalizedWhereInput to Prisma.Sql
- Fix type error in isOrgOwnerOrAdmin method
- Follow same pattern as InsightsRoutingService conversion

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* feat: convert InsightsBookingService to use Prisma.sql raw queries

- Convert auth conditions from Prisma object notation to Prisma.sql
- Convert filter conditions from Prisma object notation to Prisma.sql
- Update return types from Prisma.BookingTimeStatusDenormalizedWhereInput to Prisma.Sql
- Fix type error in isOrgOwnerOrAdmin method
- Follow same pattern as InsightsRoutingService conversion

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* fix: update InsightsBookingService integration tests for Prisma.sql format

- Replace Prisma object notation expectations with Prisma.sql template literals
- Add NOTHING_CONDITION constant for consistency with InsightsRoutingService
- Update all test cases to use direct Prisma.sql comparisons
- Use $queryRaw for actual database integration testing
- Follow same testing patterns as InsightsRoutingService

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* fix: exclude intentionally skipped jobs from required CI check failure

- Remove 'skipped' from failure condition in pr.yml and all-checks.yml
- Allow E2E jobs to be skipped without failing the required check
- Only actual failures and cancelled jobs will cause required check to fail

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

* fix tests

* Revert "fix: exclude intentionally skipped jobs from required CI check failure"

This reverts commit 6ff44fc9a8f14ad657f7bba7c2e454e192b66c8f.

* clean up tests

* address feedback

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2025-07-15 11:09:06 +02:00