## Summary Fixes #18744 — The workflow FIND_RECORDS action silently drops filter conditions when a variable resolves to null/empty, causing the query to return **all records** instead of erroring. **Root cause (three compounding layers):** 1. **`variable-resolver.ts`** — `resolveString` returns `undefined` when a variable lookup fails (e.g., `{{steps.trigger.output.userId}}` where `userId` doesn't exist in context). The return type says `string` but `evalFromContext` actually returns `undefined` at runtime. 2. **`checkIfShouldSkipFiltering.ts`** — Treats `undefined`/`null`/`""` values as "skip this filter." This is correct for the **UI filter builder** (user hasn't finished typing), but wrong for **workflow execution** (variable resolution failed = misconfigured workflow). 3. **`find-records.workflow-action.ts`** — When all filters are silently skipped, `computeRecordGqlOperationFilter` returns `{}` (match everything). The query runs with no filter, returning all records — silently succeeding with wrong results. ## Fix Added validation in `find-records.workflow-action.ts` **after** `resolveInput` but **before** `computeRecordGqlOperationFilter`. For each filter with a value-requiring operand (i.e., not IS_EMPTY, IS_NOT_EMPTY, IS_IN_PAST, IS_IN_FUTURE, IS_TODAY), if the resolved value is `undefined`, `null`, or `""`, throw `INVALID_STEP_INPUT` with a descriptive error message. **Why this approach:** - Scoped to the workflow executor — does **not** break the UI filter builder's intentional skip-on-empty behavior - Does not change shared utilities (`checkIfShouldSkipFiltering`, `resolveInput`) used across the app - Fails fast with a clear error instead of silently returning wrong data - 1 file changed, 23 lines added ## Test plan - [x] Backend typecheck passes - [x] oxlint passes (0 warnings, 0 errors) - [x] Prettier passes - [ ] Manual: Create a workflow with FIND_RECORDS using a variable that doesn't exist → should error with "Filter condition has an empty value after variable resolution" instead of returning all records - [ ] Manual: Create a workflow with FIND_RECORDS using IS_EMPTY operand (no value needed) → should still work correctly --------- Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]> Co-authored-by: Charles Bochet <[email protected]>
206 lines
14 KiB
TypeScript
206 lines
14 KiB
TypeScript
/*
|
|
* _____ _
|
|
*|_ _|_ _____ _ __ | |_ _ _
|
|
* | | \ \ /\ / / _ \ '_ \| __| | | | Auto-generated file
|
|
* | | \ V V / __/ | | | |_| |_| | Any edits to this will be overridden
|
|
* |_| \_/\_/ \___|_| |_|\__|\__, |
|
|
* |___/
|
|
*/
|
|
|
|
export { applyDiff } from './applyDiff';
|
|
export { compareArraysOfObjectsByProperty } from './array/compareArraysOfObjectsByProperty';
|
|
export { filterDuplicatesById } from './array/filterDuplicatesById';
|
|
export { filterOutByProperty } from './array/filterOutByProperty';
|
|
export { findById } from './array/findById';
|
|
export { findByProperty } from './array/findByProperty';
|
|
export { findOrThrow } from './array/findOrThrow';
|
|
export { getContiguousIncrementalValues } from './array/getContiguousIncrementalValues';
|
|
export { isNonEmptyArray } from './array/isNonEmptyArray';
|
|
export { mapById } from './array/mapById';
|
|
export { mapByProperty } from './array/mapByProperty';
|
|
export { sumByProperty } from './array/sumByProperty';
|
|
export { upsertIntoArrayOfObjectsComparingId } from './array/upsertIntoArrayOfObjectsComparingId';
|
|
export { upsertPropertiesOfItemIntoArrayOfObjectsComparingId } from './array/upsertPropertiesOfItemIntoArrayOfObjectsComparingId';
|
|
export { assertUnreachable } from './assertUnreachable';
|
|
export { base64UrlEncode } from './base64UrlEncode';
|
|
export { conditionalAvailabilityParser } from './command-menu-items/conditionalAvailabilityParser';
|
|
export { evaluateConditionalAvailabilityExpression } from './command-menu-items/evaluateConditionalAvailabilityExpression';
|
|
export { interpolateCommandMenuItemLabel } from './command-menu-items/interpolateCommandMenuItemLabel';
|
|
export { safeGetNestedProperty } from './command-menu-items/safeGetNestedProperty';
|
|
export { computeDiffBetweenObjects } from './compute-diff-between-objects';
|
|
export { isPlainDateAfter } from './date/isPlainDateAfter';
|
|
export { isPlainDateBefore } from './date/isPlainDateBefore';
|
|
export { isPlainDateBeforeOrEqual } from './date/isPlainDateBeforeOrEqual';
|
|
export { isPlainDateInSameMonth } from './date/isPlainDateInSameMonth';
|
|
export { isPlainDateInWeekend } from './date/isPlainDateInWeekend';
|
|
export { isSamePlainDate } from './date/isSamePlainDate';
|
|
export { parseToPlainDateOrThrow } from './date/parseToPlainDateOrThrow';
|
|
export { sortPlainDate } from './date/sortPlainDate';
|
|
export { turnJSDateToPlainDate } from './date/turnJSDateToPlainDate';
|
|
export { turnPlainDateIntoUserTimeZoneInstantString } from './date/turnPlainDateIntoUserTimeZoneInstantString';
|
|
export { turnPlainDateToShiftedDateInSystemTimeZone } from './date/turnPlainDateToShiftedDateInSystemTimeZone';
|
|
export { deepMerge } from './deepMerge';
|
|
export { CustomError } from './errors/CustomError';
|
|
export { evalFromContext } from './evalFromContext';
|
|
export { extractAndSanitizeObjectStringFields } from './extractAndSanitizeObjectStringFields';
|
|
export { computeMorphRelationFieldName } from './fieldMetadata/compute-morph-relation-field-name';
|
|
export { isFieldMetadataArrayKind } from './fieldMetadata/isFieldMetadataArrayKind';
|
|
export { isFieldMetadataDateKind } from './fieldMetadata/isFieldMetadataDateKind';
|
|
export { isFieldMetadataNumericKind } from './fieldMetadata/isFieldMetadataNumericKind';
|
|
export { isFieldMetadataSelectKind } from './fieldMetadata/isFieldMetadataSelectKind';
|
|
export { isFieldMetadataTextKind } from './fieldMetadata/isFieldMetadataTextKind';
|
|
export { extractFolderPathFilenameAndTypeOrThrow } from './files/extractFolderPathFilenameAndTypeOrThrow.util';
|
|
export { checkIfShouldComputeEmptinessFilter } from './filter/checkIfShouldComputeEmptinessFilter';
|
|
export { computeGqlOperationFilterForEmails } from './filter/compute-record-gql-operation-filter/for-composite-field/computeGqlOperationFilterForEmails';
|
|
export { computeGqlOperationFilterForLinks } from './filter/compute-record-gql-operation-filter/for-composite-field/computeGqlOperationFilterForLinks';
|
|
export { computeEmptyGqlOperationFilterForEmails } from './filter/computeEmptyGqlOperationFilterForEmails';
|
|
export { computeEmptyGqlOperationFilterForLinks } from './filter/computeEmptyGqlOperationFilterForLinks';
|
|
export { computeRecordGqlOperationFilter } from './filter/computeRecordGqlOperationFilter';
|
|
export type { DateTimePeriod } from './filter/dates/types/DateTimePeriod';
|
|
export { addUnitToDateTime } from './filter/dates/utils/addUnitToDateTime';
|
|
export { addUnitToZonedDateTime } from './filter/dates/utils/addUnitToZonedDateTime';
|
|
export { convertCalendarStartDayNonIsoNumberToFirstDayOfTheWeek } from './filter/dates/utils/convertCalendarStartDayNonIsoNumberToFirstDayOfTheWeek';
|
|
export { convertFirstDayOfTheWeekToCalendarStartDayNumber } from './filter/dates/utils/convertFirstDayOfTheWeekToCalendarStartDayNumber';
|
|
export type { FirstDayOfTheWeekSchema } from './filter/dates/utils/firstDayOfWeekSchema';
|
|
export { firstDayOfWeekSchema } from './filter/dates/utils/firstDayOfWeekSchema';
|
|
export { getFirstDayOfTheWeekAsANumberForDateFNS } from './filter/dates/utils/getFirstDayOfTheWeekAsANumberForDateFNS';
|
|
export { getFirstDayOfTheWeekAsISONumber } from './filter/dates/utils/getFirstDayOfTheWeekAsISONumber';
|
|
export {
|
|
FIRST_DAY_OF_WEEK_ISO_8601_MONDAY,
|
|
getNextPeriodStart,
|
|
} from './filter/dates/utils/getNextPeriodStart';
|
|
export { getPeriodStart } from './filter/dates/utils/getPeriodStart';
|
|
export { relativeDateFilterAmountSchema } from './filter/dates/utils/relativeDateFilterAmountSchema';
|
|
export type { RelativeDateFilterDirection } from './filter/dates/utils/relativeDateFilterDirectionSchema';
|
|
export { relativeDateFilterDirectionSchema } from './filter/dates/utils/relativeDateFilterDirectionSchema';
|
|
export type { RelativeDateFilter } from './filter/dates/utils/relativeDateFilterSchema';
|
|
export { relativeDateFilterSchema } from './filter/dates/utils/relativeDateFilterSchema';
|
|
export { relativeDateFilterStringifiedSchema } from './filter/dates/utils/relativeDateFilterStringifiedSchema';
|
|
export type { RelativeDateFilterUnit } from './filter/dates/utils/relativeDateFilterUnitSchema';
|
|
export { relativeDateFilterUnitSchema } from './filter/dates/utils/relativeDateFilterUnitSchema';
|
|
export type { ResolvedDateFilterValue } from './filter/dates/utils/resolveDateFilter';
|
|
export { resolveDateFilter } from './filter/dates/utils/resolveDateFilter';
|
|
export type { ResolvedDateTimeFilterValue } from './filter/dates/utils/resolveDateTimeFilter';
|
|
export { resolveDateTimeFilter } from './filter/dates/utils/resolveDateTimeFilter';
|
|
export { resolveRelativeDateFilter } from './filter/dates/utils/resolveRelativeDateFilter';
|
|
export { resolveRelativeDateFilterStringified } from './filter/dates/utils/resolveRelativeDateFilterStringified';
|
|
export { resolveRelativeDateTimeFilter } from './filter/dates/utils/resolveRelativeDateTimeFilter';
|
|
export { resolveRelativeDateTimeFilterStringified } from './filter/dates/utils/resolveRelativeDateTimeFilterStringified';
|
|
export { subUnitFromDateTime } from './filter/dates/utils/subUnitFromDateTime';
|
|
export { subUnitFromZonedDateTime } from './filter/dates/utils/subUnitFromZonedDateTime';
|
|
export { filterOutInvalidRecordFilters } from './filter/filterOutInvalidRecordFilters';
|
|
export { isEmptinessOperand } from './filter/isEmptinessOperand';
|
|
export { isRecordFilterOperandExpectingValue } from './filter/isRecordFilterOperandExpectingValue';
|
|
export { isRecordFilterValueValid } from './filter/isRecordFilterValueValid';
|
|
export { turnAnyFieldFilterIntoRecordGqlFilter } from './filter/turnAnyFieldFilterIntoRecordGqlFilter';
|
|
export type {
|
|
RecordFilter,
|
|
RecordFilterGroup,
|
|
} from './filter/turnRecordFilterGroupIntoGqlOperationFilter';
|
|
export { turnRecordFilterGroupsIntoGqlOperationFilter } from './filter/turnRecordFilterGroupIntoGqlOperationFilter';
|
|
export { turnRecordFilterIntoRecordGqlOperationFilter } from './filter/turnRecordFilterIntoGqlOperationFilter';
|
|
export { combineFilters } from './filter/utils/combineFilters';
|
|
export { convertViewFilterOperandToCoreOperand } from './filter/utils/convert-view-filter-operand-to-core-operand.util';
|
|
export { convertViewFilterValueToString } from './filter/utils/convertViewFilterValueToString';
|
|
export { createAnyFieldRecordFilterBaseProperties } from './filter/utils/createAnyFieldRecordFilterBaseProperties';
|
|
export {
|
|
convertGreaterThanOrEqualRatingToArrayOfRatingValues,
|
|
convertLessThanOrEqualRatingToArrayOfRatingValues,
|
|
convertRatingToRatingValue,
|
|
} from './filter/utils/fieldRatingConvertors';
|
|
export { filterSelectOptionsOfFieldMetadataItem } from './filter/utils/filterSelectOptionsOfFieldMetadataItem';
|
|
export { generateILikeFiltersForCompositeFields } from './filter/utils/generateILikeFiltersForCompositeFields';
|
|
export { getEmptyRecordGqlOperationFilter } from './filter/utils/getEmptyRecordGqlOperationFilter';
|
|
export { getFilterTypeFromFieldType } from './filter/utils/getFilterTypeFromFieldType';
|
|
export { isExpectedSubFieldName } from './filter/utils/isExpectedSubFieldName';
|
|
export { isMatchingArrayFilter } from './filter/utils/isMatchingArrayFilter';
|
|
export { isMatchingBooleanFilter } from './filter/utils/isMatchingBooleanFilter';
|
|
export { isMatchingCurrencyFilter } from './filter/utils/isMatchingCurrencyFilter';
|
|
export { isMatchingDateFilter } from './filter/utils/isMatchingDateFilter';
|
|
export { isMatchingFilesFilter } from './filter/utils/isMatchingFilesFilter';
|
|
export { isMatchingFloatFilter } from './filter/utils/isMatchingFloatFilter';
|
|
export { isMatchingMultiSelectFilter } from './filter/utils/isMatchingMultiSelectFilter';
|
|
export { isMatchingRatingFilter } from './filter/utils/isMatchingRatingFilter';
|
|
export { isMatchingRawJsonFilter } from './filter/utils/isMatchingRawJsonFilter';
|
|
export { isMatchingRichTextFilter } from './filter/utils/isMatchingRichTextFilter';
|
|
export { isMatchingSelectFilter } from './filter/utils/isMatchingSelectFilter';
|
|
export { isMatchingStringFilter } from './filter/utils/isMatchingStringFilter';
|
|
export { isMatchingTSVectorFilter } from './filter/utils/isMatchingTSVectorFilter';
|
|
export { isMatchingUUIDFilter } from './filter/utils/isMatchingUUIDFilter';
|
|
export { arrayOfStringsOrVariablesSchema } from './filter/utils/validation-schemas/arrayOfStringsOrVariablesSchema';
|
|
export { arrayOfUuidOrVariableSchema } from './filter/utils/validation-schemas/arrayOfUuidsOrVariablesSchema';
|
|
export {
|
|
relationFilterValueSchemaObject,
|
|
jsonRelationFilterValueSchema,
|
|
} from './filter/utils/validation-schemas/jsonRelationFilterValueSchema';
|
|
export { formatToShortNumber } from './format/formatToShortNumber';
|
|
export { fromArrayToUniqueKeyRecord } from './from-array-to-unique-key-record.util';
|
|
export { fromArrayToValuesByKeyRecord } from './fromArrayToValuesByKeyRecord.util';
|
|
export { getURLSafely } from './getURLSafely';
|
|
export { getImageAbsoluteURI } from './image/getImageAbsoluteURI';
|
|
export {
|
|
sanitizeURL,
|
|
getLogoUrlFromDomainName,
|
|
} from './image/getLogoUrlFromDomainName';
|
|
export { getUniqueConstraintsFields } from './indexMetadata/getUniqueConstraintsFields';
|
|
export { fastDeepEqual } from './json/fast-deep-equal';
|
|
export { getAppPath } from './navigation/getAppPath';
|
|
export { getSettingsPath } from './navigation/getSettingsPath';
|
|
export { parseJson } from './parseJson';
|
|
export { removePropertiesFromRecord } from './removePropertiesFromRecord';
|
|
export { removeUndefinedFields } from './removeUndefinedFields';
|
|
export { resolveRichTextVariables } from './rich-text-variable-resolver';
|
|
export { safeParseRelativeDateFilterJSONStringified } from './safeParseRelativeDateFilterJSONStringified';
|
|
export { getGenericOperationName } from './sentry/getGenericOperationName';
|
|
export { getHumanReadableNameFromCode } from './sentry/getHumanReadableNameFromCode';
|
|
export { appendCopySuffix } from './strings/appendCopySuffix';
|
|
export { camelToKebab } from './strings/camelToKebab';
|
|
export { camelToSnakeCase } from './strings/camelToSnakeCase';
|
|
export { capitalize } from './strings/capitalize';
|
|
export { kebabToCamelCase } from './strings/kebabToCamelCase';
|
|
export { pascalCase } from './strings/pascalCase';
|
|
export { pascalToKebab } from './strings/pascalToKebab';
|
|
export { stringifySafely } from './strings/stringifySafely';
|
|
export { uncapitalize } from './strings/uncapitalize';
|
|
export type {
|
|
TipTapMarkType,
|
|
TipTapNodeType,
|
|
LinkMarkAttributes,
|
|
TipTapMark,
|
|
} from './tiptap/tiptap-marks';
|
|
export {
|
|
TIPTAP_MARK_TYPES,
|
|
TIPTAP_NODE_TYPES,
|
|
TIPTAP_MARKS_RENDER_ORDER,
|
|
} from './tiptap/tiptap-marks';
|
|
export type { StringPropertyKeys } from './trim-and-remove-duplicated-whitespaces-from-object-string-properties';
|
|
export { trimAndRemoveDuplicatedWhitespacesFromObjectStringProperties } from './trim-and-remove-duplicated-whitespaces-from-object-string-properties';
|
|
export { trimAndRemoveDuplicatedWhitespacesFromString } from './trim-and-remove-duplicated-whitespaces-from-string';
|
|
export { isMetadataGqlOperationSignature } from './typeguard/isMetadataGqlOperationSignature';
|
|
export { isPlainObject } from './typeguard/isPlainObject';
|
|
export { isRecordGqlOperationSignature } from './typeguard/isRecordGqlOperationSignature';
|
|
export { throwIfNotDefined } from './typeguard/throwIfNotDefined';
|
|
export { absoluteUrlSchema } from './url/absoluteUrlSchema';
|
|
export { buildSignedPath } from './url/buildSignedPath';
|
|
export { ensureAbsoluteUrl } from './url/ensureAbsoluteUrl';
|
|
export { getAbsoluteUrlOrThrow } from './url/getAbsoluteUrlOrThrow';
|
|
export { getUrlHostnameOrThrow } from './url/getUrlHostnameOrThrow';
|
|
export { isValidHostname } from './url/isValidHostname';
|
|
export { isValidUrl } from './url/isValidUrl';
|
|
export { normalizeUrl } from './url/normalizeUrl';
|
|
export { normalizeUrlOrigin } from './url/normalizeUrlOrigin';
|
|
export { safeDecodeURIComponent } from './url/safeDecodeURIComponent';
|
|
export { uuidToBase36 } from './uuidToBase36';
|
|
export { assertIsDefinedOrThrow } from './validation/assertIsDefinedOrThrow';
|
|
export { isDefined } from './validation/isDefined';
|
|
export { isEmptyObject } from './validation/isEmptyObject';
|
|
export { isLabelIdentifierFieldMetadataTypes } from './validation/isLabelIdentifierFieldMetadataTypes';
|
|
export { isValidLocale } from './validation/isValidLocale';
|
|
export { isValidTwentySubdomain } from './validation/isValidTwentySubdomain';
|
|
export { isValidUuid } from './validation/isValidUuid';
|
|
export { isValidVariable } from './validation/isValidVariable';
|
|
export { normalizeLocale } from './validation/normalizeLocale';
|
|
export { getCountryCodesForCallingCode } from './validation/phones-value/getCountryCodesForCallingCode';
|
|
export { isValidCountryCode } from './validation/phones-value/isValidCountryCode';
|
|
export { resolveInput } from './variable-resolver';
|