Followup https://github.com/twentyhq/twenty/pull/19010 ## Dependency diagram ``` ┌─────────────────────┐ │ twenty-front │ │ (React frontend) │ └─────────┬───────────┘ │ imports runtime: │ FrontComponentRenderer │ FrontComponentRendererWithSdkClient │ useFrontComponentExecutionContext ▼ ┌──────────────────────────────────┐ ┌─────────────────────────┐ │ twenty-front-component-renderer │────────▶│ twenty-sdk │ │ (remote-dom host + worker) │ │ (app developer SDK) │ │ │ │ │ │ imports from twenty-sdk: │ │ Public API: │ │ • types only: │ │ defineFrontComponent │ │ FrontComponentExecutionContext│ │ navigate, closeSide… │ │ NavigateFunction │ │ useFrontComponent… │ │ CloseSidePanelFunction │ │ Command components │ │ CommandConfirmation… │ │ conditional avail. │ │ OpenCommandConfirmation… │ │ │ │ EnqueueSnackbarFunction │ │ Internal only: │ │ etc. │ │ frontComponentHost… │ │ │ │ front-component-build │ │ owns locally: │ │ esbuild plugins │ │ • ALLOWED_HTML_ELEMENTS │ │ │ │ • EVENT_TO_REACT │ └────────────┬────────────┘ │ • HTML_TAG_TO_CUSTOM_ELEMENT… │ │ │ • SerializedEventData │ │ types │ • PropertySchema │ ▼ │ • frontComponentHostComm… │ ┌─────────────────────────┐ │ (local ref to globalThis) │ │ twenty-shared │ │ • setFrontComponentExecution… │ │ (common types/utils) │ │ (local impl, same keys) │ │ AppPath, SidePanelP… │ │ │ │ EnqueueSnackbarParams │ └──────────────────────────────────┘ │ isDefined, … │ │ └─────────────────────────┘ │ also depends on ▼ twenty-shared (types) @remote-dom/* (runtime) @quilted/threads (runtime) react (runtime) ``` **Key points:** - **`twenty-front`** depends on the renderer, **not** on `twenty-sdk` directly (for rendering) - **`twenty-front-component-renderer`** depends on `twenty-sdk` for **types only** (function signatures, `FrontComponentExecutionContext`). The runtime bridge (`frontComponentHostCommunicationApi`) is shared via `globalThis` keys, not module imports - **`twenty-sdk`** has no dependency on the renderer — clean one-way dependency - The renderer owns all remote-dom infrastructure (element schemas, event mappings, custom element tags) that was previously leaking through the SDK's public API - The SDK's `./build` entry point was removed entirely (unused)
59 lines
1.5 KiB
TypeScript
59 lines
1.5 KiB
TypeScript
import type { Project, SourceFile } from 'ts-morph';
|
|
|
|
import { EVENT_TO_REACT } from '../../../src/constants/EventToReact';
|
|
import { type ComponentSchema } from './schemas';
|
|
import { addExportedConst } from './utils';
|
|
|
|
const generateComponentDefinition = (
|
|
sourceFile: SourceFile,
|
|
component: ComponentSchema,
|
|
): void => {
|
|
const hasEvents = component.events.length > 0;
|
|
|
|
let initializer: string;
|
|
|
|
if (hasEvents) {
|
|
const eventProps = component.events
|
|
.map((event) => {
|
|
const propName = EVENT_TO_REACT[event];
|
|
return ` ${propName}: { event: '${event}' },`;
|
|
})
|
|
.join('\n');
|
|
|
|
initializer = `createRemoteComponent('${component.customElementName}', ${component.name}Element, {
|
|
eventProps: {
|
|
${eventProps}
|
|
},
|
|
})`;
|
|
} else {
|
|
initializer = `createRemoteComponent('${component.customElementName}', ${component.name}Element)`;
|
|
}
|
|
|
|
addExportedConst(sourceFile, component.name, initializer);
|
|
};
|
|
|
|
export const generateRemoteComponents = (
|
|
project: Project,
|
|
components: ComponentSchema[],
|
|
): SourceFile => {
|
|
const sourceFile = project.createSourceFile('remote-components.ts', '', {
|
|
overwrite: true,
|
|
});
|
|
|
|
sourceFile.addImportDeclaration({
|
|
moduleSpecifier: '@remote-dom/react',
|
|
namedImports: ['createRemoteComponent'],
|
|
});
|
|
|
|
sourceFile.addImportDeclaration({
|
|
moduleSpecifier: './remote-elements',
|
|
namedImports: components.map((component) => `${component.name}Element`),
|
|
});
|
|
|
|
for (const component of components) {
|
|
generateComponentDefinition(sourceFile, component);
|
|
}
|
|
|
|
return sourceFile;
|
|
};
|