Charles BochetandGitHub
5c745059ad
## Summary
- **Remove all "core" prefixes** from the views system — the
metadata-based storage migration is complete, so `CoreView`,
`coreViewsSelector`, `getCoreViews`, etc. are now just `View`,
`viewsSelector`, `getViews`
- **Eliminate the entire converter layer** (15 files, ~850 lines
deleted) — `convertCoreViewToView` and all sub-converters were either
no-ops or trivially adding `__typename` / mapping identical enum values.
Local enums now re-export from generated GraphQL types directly (single
source of truth)
- **Unify `View` and `ViewWithRelations`** into one type —
`ViewWithRelations` is now a type alias for `View`, selectors return
data directly without conversion
### Backend
- Rename `@ObjectType('CoreView')` → `@ObjectType('View')` (and all
sub-entities)
- Rename resolver methods: `getCoreViews` → `getViews`, `createCoreView`
→ `createView`, etc.
- Rename `FIND_ALL_CORE_VIEWS_GRAPHQL_OPERATION` →
`FIND_ALL_VIEWS_GRAPHQL_OPERATION`
### Frontend
- Delete 15 converter files (`convertGqlView*ToView*`,
`convertView*ToGql`, `convertViewWithRelationsToView`)
- Re-export `ViewType`, `ViewKey`, `ViewFilterGroupLogicalOperator` from
generated enums (no more duplicate enum definitions with different
casing)
- Replace `ViewOpenRecordInType` with `ViewOpenRecordIn` from generated
- Remove `__typename` from all local view sub-types
- Remove unused `variant` from `ViewFilter`, make `displayValue` and
`definition` optional
- Rename ~45 GraphQL query/mutation files and all selectors to drop
"core" prefix
- Delete unused `viewsWithRelationsSelector`
40 lines
1.2 KiB
TypeScript
40 lines
1.2 KiB
TypeScript
import { createOneView } from 'test/integration/metadata/suites/view/utils/create-one-view.util';
|
|
|
|
import { type CreateViewInput } from 'src/engine/metadata-modules/view/dtos/inputs/create-view.input';
|
|
import { type ViewEntity } from 'src/engine/metadata-modules/view/entities/view.entity';
|
|
|
|
import { createViewData } from './view-data-factory.util';
|
|
|
|
export const createTestViewWithGraphQL = async (
|
|
overrides: Partial<ViewEntity> = {},
|
|
): Promise<ViewEntity> => {
|
|
const viewData = createViewData(overrides);
|
|
const input: CreateViewInput = {
|
|
name: viewData.name,
|
|
objectMetadataId: viewData.objectMetadataId as string,
|
|
icon: viewData.icon,
|
|
type: viewData.type,
|
|
position: viewData.position,
|
|
mainGroupByFieldMetadataId:
|
|
viewData.mainGroupByFieldMetadataId ?? undefined,
|
|
isCompact: viewData.isCompact,
|
|
openRecordIn: viewData.openRecordIn,
|
|
visibility: viewData.visibility,
|
|
};
|
|
|
|
const { data, errors } = await createOneView({
|
|
input,
|
|
expectToFail: false,
|
|
});
|
|
|
|
if (errors) {
|
|
throw new Error(`Failed to create test view: ${JSON.stringify(errors)}`);
|
|
}
|
|
|
|
if (!data) {
|
|
throw new Error('No data returned from createTestViewWithGraphQL');
|
|
}
|
|
|
|
return data.createView;
|
|
};
|