EtienneandGitHub
d562a384c2
Bug fixes exposed by always-on direct execution
1. GraphQL spec compliance — data[field] = null on resolver error
direct-execution.service.ts — Changed from Promise.allSettled (which
lost the responseKey on rejection) to Promise.all with per-field
try/catch; errors now set data[responseKey] = null per spec
2. Empty object arguments skipped (extractArgumentsFromAst)
extract-arguments-from-ast.util.ts — Removed isEmptyObject check;
filter: {}, data: {} now correctly passed to resolvers instead of
silently dropped (which caused permissions to never be checked)
3. orderBy: {} factory default treated as "no ordering"
direct-execution.service.ts — Before calling the resolver, strips
orderBy: {} and orderByForRecords: {} (empty-object factory defaults
that mean "no ordering")
assert-find-many-args.util.ts / assert-group-by-args.util.ts — Accept {}
for orderBy without throwing
4. orderBy: { field: '...' } object auto-coerced to [{ field: '...' }]
array
direct-execution.service.ts — Applies GraphQL list coercion: a
non-array, non-empty orderBy object is wrapped in an array before
assertion and resolver call
5. totalCount and aggregate fields returned as strings from PostgreSQL
graphql-format-result-from-selected-fields.util.ts — Added
coerceAggregateValue that parses numeric strings to numbers for
totalCount, sum*, avg*, min*, max*, count*, percentageOf* fields
Test updates
nested-relation-queries.integration-spec.ts — Updated expected error
message from Yoga schema-validation message to direct execution resolver
message
~30 snapshot files — Updated to reflect direct execution's error
messages (different from Yoga schema-validation messages for input type
errors)
66 lines
1.6 KiB
TypeScript
66 lines
1.6 KiB
TypeScript
import { readFile } from 'node:fs/promises';
|
|
import path from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
|
|
import { buildClientSchema, getIntrospectionQuery, printSchema } from 'graphql';
|
|
|
|
import { generateMetadataClient } from '../src/generate/generate-metadata-client';
|
|
|
|
const __filename = fileURLToPath(import.meta.url);
|
|
const __dirname = path.dirname(__filename);
|
|
|
|
const TEMPLATE_PATH = path.resolve(
|
|
__dirname,
|
|
'..',
|
|
'src',
|
|
'generate',
|
|
'twenty-client-template.ts',
|
|
);
|
|
|
|
const introspectSchema = async (url: string): Promise<string> => {
|
|
const response = await fetch(url, {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ query: getIntrospectionQuery() }),
|
|
});
|
|
|
|
const json = await response.json();
|
|
|
|
if (json.errors) {
|
|
throw new Error(
|
|
`GraphQL introspection errors: ${JSON.stringify(json.errors)}`,
|
|
);
|
|
}
|
|
|
|
return printSchema(buildClientSchema(json.data));
|
|
};
|
|
|
|
const main = async () => {
|
|
const serverUrl = process.env.TWENTY_API_URL ?? 'http://localhost:3000';
|
|
|
|
const schema = await introspectSchema(`${serverUrl}/metadata`);
|
|
|
|
const clientWrapperTemplateSource = await readFile(TEMPLATE_PATH, 'utf-8');
|
|
|
|
const outputPath = path.resolve(
|
|
__dirname,
|
|
'..',
|
|
'src',
|
|
'metadata',
|
|
'generated',
|
|
);
|
|
|
|
await generateMetadataClient({
|
|
schema,
|
|
outputPath,
|
|
clientWrapperTemplateSource,
|
|
});
|
|
|
|
console.log(`Metadata client generated at ${outputPath}`);
|
|
};
|
|
|
|
main().catch((error) => {
|
|
console.error('Failed to generate metadata client:', error);
|
|
process.exit(1);
|
|
});
|