## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
161 lines
3.7 KiB
TypeScript
161 lines
3.7 KiB
TypeScript
/* oxlint-disable no-console */
|
|
import { graphqlRequest, writeGeneratedFile } from './utils.js';
|
|
|
|
// Apollo Client automatically adds __typename to every object level;
|
|
// raw fetch does not, so we include it explicitly here.
|
|
const METADATA_QUERY = `
|
|
query ObjectMetadataItems {
|
|
objects(paging: { first: 1000 }) {
|
|
__typename
|
|
edges {
|
|
__typename
|
|
node {
|
|
__typename
|
|
id
|
|
universalIdentifier
|
|
nameSingular
|
|
namePlural
|
|
labelSingular
|
|
labelPlural
|
|
description
|
|
icon
|
|
isCustom
|
|
isRemote
|
|
isActive
|
|
isSystem
|
|
isUIReadOnly
|
|
createdAt
|
|
updatedAt
|
|
labelIdentifierFieldMetadataId
|
|
imageIdentifierFieldMetadataId
|
|
applicationId
|
|
shortcut
|
|
isLabelSyncedWithName
|
|
isSearchable
|
|
duplicateCriteria
|
|
indexMetadataList {
|
|
__typename
|
|
id
|
|
createdAt
|
|
updatedAt
|
|
name
|
|
indexWhereClause
|
|
indexType
|
|
isUnique
|
|
isCustom
|
|
indexFieldMetadataList {
|
|
__typename
|
|
id
|
|
fieldMetadataId
|
|
createdAt
|
|
updatedAt
|
|
order
|
|
}
|
|
}
|
|
fieldsList {
|
|
__typename
|
|
id
|
|
universalIdentifier
|
|
type
|
|
name
|
|
label
|
|
description
|
|
icon
|
|
isCustom
|
|
isActive
|
|
isSystem
|
|
isUIReadOnly
|
|
isNullable
|
|
isUnique
|
|
createdAt
|
|
updatedAt
|
|
defaultValue
|
|
options
|
|
settings
|
|
isLabelSyncedWithName
|
|
morphId
|
|
applicationId
|
|
relation {
|
|
__typename
|
|
type
|
|
sourceObjectMetadata {
|
|
__typename
|
|
id
|
|
nameSingular
|
|
namePlural
|
|
}
|
|
targetObjectMetadata {
|
|
__typename
|
|
id
|
|
nameSingular
|
|
namePlural
|
|
}
|
|
sourceFieldMetadata {
|
|
__typename
|
|
id
|
|
name
|
|
}
|
|
targetFieldMetadata {
|
|
__typename
|
|
id
|
|
name
|
|
}
|
|
}
|
|
morphRelations {
|
|
__typename
|
|
type
|
|
sourceObjectMetadata {
|
|
__typename
|
|
id
|
|
nameSingular
|
|
namePlural
|
|
}
|
|
targetObjectMetadata {
|
|
__typename
|
|
id
|
|
nameSingular
|
|
namePlural
|
|
}
|
|
sourceFieldMetadata {
|
|
__typename
|
|
id
|
|
name
|
|
}
|
|
targetFieldMetadata {
|
|
__typename
|
|
id
|
|
name
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
pageInfo {
|
|
__typename
|
|
hasNextPage
|
|
hasPreviousPage
|
|
startCursor
|
|
endCursor
|
|
}
|
|
}
|
|
}
|
|
`;
|
|
|
|
export const generateMetadata = async (token: string) => {
|
|
console.log('Fetching object metadata from /metadata ...');
|
|
|
|
const metadata = await graphqlRequest('/metadata', METADATA_QUERY, token);
|
|
|
|
writeGeneratedFile(
|
|
'metadata/objects/mock-objects-metadata.ts',
|
|
'mockedStandardObjectMetadataQueryResult',
|
|
'ObjectMetadataItemsQuery',
|
|
"import { ObjectMetadataItemsQuery } from '~/generated-metadata/graphql';",
|
|
metadata,
|
|
);
|
|
|
|
return metadata as {
|
|
objects: { edges: { node: Record<string, unknown> }[] };
|
|
};
|
|
};
|