Files
twenty/packages/twenty-eslint-rules/rules/no-angle-bracket-placeholders.ts
T
Félix Malfait c737028dd6 Move tools/eslint-rules to packages/twenty-eslint-rules (#17203)
## Summary

Moves the custom ESLint rules from `tools/eslint-rules` to
`packages/twenty-eslint-rules` for better organization within the
monorepo packages structure.

## Changes

- Move `eslint-rules` from `tools/` to `packages/twenty-eslint-rules`
- Use `loadWorkspaceRules` from `@nx/eslint-plugin` to load custom rules
- Update all ESLint configs to use the `twenty/` rule prefix instead of
`@nx/workspace-`
- Update `project.json`, `jest.config.mjs` with new paths
- Update `package.json` workspaces and `nx.json` cache inputs
- Update Dockerfile reference

## Technical Details

The custom ESLint rules are now loaded using Nx's `loadWorkspaceRules`
utility which:
- Handles TypeScript transpilation automatically
- Allows loading workspace rules from any directory
- Provides a cleaner approach than the previous `@nx/workspace-`
convention

## Testing

- Verified all 17 custom ESLint rules load correctly from the new
location
- Verified linting works on dependent packages (twenty-front,
twenty-server, etc.)
2026-01-17 07:37:17 +01:00

202 lines
4.7 KiB
TypeScript

import type { Rule } from 'eslint';
export const RULE_NAME = 'no-angle-bracket-placeholders';
const ALLOWED_TAGS = [
'img',
'div',
'span',
'p',
'a',
'b',
'strong',
'em',
'i',
'code',
'pre',
'br',
'hr',
'ul',
'ol',
'li',
'h1',
'h2',
'h3',
'h4',
'h5',
'h6',
'input',
'button',
'summary',
'details',
// MDX/Documentation components
'Frame',
'Warning',
'Tip',
'Info',
'Note',
'Card',
'Step',
'Tab',
'Tabs',
'ArticleTab',
'ArticleTabs',
'Accordion',
'AccordionGroup',
'Router',
'BrowserRouter',
'RecoilRoot',
];
export const rule: Rule.RuleModule = {
meta: {
type: 'problem',
docs: {
description:
'Disallow angle bracket placeholders in MDX files to prevent Crowdin translation errors. Use curly braces {placeholder} instead.',
recommended: true,
},
messages: {
noAngleBracketPlaceholder:
'Avoid angle bracket placeholders like "<{{name}}>" in documentation. Use curly braces "{{{name}}}" instead to prevent Crowdin translation errors.',
},
schema: [],
fixable: 'code',
},
create: (context) => {
const sourceCode = context.sourceCode || context.getSourceCode();
const filename = context.filename || context.getFilename();
if (!filename.endsWith('.mdx')) {
return {};
}
const isInsideCodeBlock = (position: number, text: string): boolean => {
const codeBlockRanges = [];
let searchStart = 0;
while (true) {
const openIndex = text.indexOf('```', searchStart);
if (openIndex === -1) {
break;
}
const closeIndex = text.indexOf('```', openIndex + 3);
if (closeIndex === -1) {
break;
}
codeBlockRanges.push({
start: openIndex,
end: closeIndex + 3,
});
searchStart = closeIndex + 3;
}
for (const range of codeBlockRanges) {
if (position >= range.start && position < range.end) {
return true;
}
}
const beforeText = text.substring(0, position);
let inlineBacktickCount = 0;
for (let i = 0; i < beforeText.length; i++) {
let insideFencedBlock = false;
for (const range of codeBlockRanges) {
if (i >= range.start && i < range.end) {
insideFencedBlock = true;
break;
}
}
if (!insideFencedBlock && beforeText[i] === '`') {
inlineBacktickCount++;
}
}
return inlineBacktickCount % 2 !== 0;
};
return {
Program: (node) => {
const text = sourceCode.getText();
// check for URL patterns with angle brackets (e.g., https://<your-domain>/)
const urlPlaceholderRegex = /(https?:\/\/)<([a-z][a-z0-9_-]+)>/g;
let urlMatch;
const foundPositions = new Set();
while ((urlMatch = urlPlaceholderRegex.exec(text)) !== null) {
const tagName = urlMatch[2];
const startPos = urlMatch.index + urlMatch[1].length; // Start after http(s)://
const endPos = startPos + tagName.length + 2; // +2 for < and >
foundPositions.add(startPos);
// Skip reporting errors inside code blocks
if (isInsideCodeBlock(startPos, text)) {
continue;
}
context.report({
node: node as any,
loc: {
start: sourceCode.getLocFromIndex(startPos),
end: sourceCode.getLocFromIndex(endPos),
},
messageId: 'noAngleBracketPlaceholder',
data: {
name: tagName,
},
});
}
const placeholderRegex = /<([a-z][a-z0-9_-]+)>/g;
let match;
while ((match = placeholderRegex.exec(text)) !== null) {
const tagName = match[1];
const startPos = match.index;
if (foundPositions.has(startPos)) {
continue;
}
if (ALLOWED_TAGS.includes(tagName)) {
continue;
}
const beforeMatch = text.charAt(match.index - 1);
if (beforeMatch === '/') {
continue;
}
const endPos = startPos + match[0].length;
// Skip reporting errors inside code blocks (valid syntax like Promise<object>)
if (isInsideCodeBlock(startPos, text)) {
continue;
}
context.report({
node: node as any,
loc: {
start: sourceCode.getLocFromIndex(startPos),
end: sourceCode.getLocFromIndex(endPos),
},
messageId: 'noAngleBracketPlaceholder',
data: {
name: tagName,
},
});
}
},
};
},
};