Paul RastoinandGitHub
37908114fc
Followup https://github.com/twentyhq/twenty/pull/19010 ## Dependency diagram ``` ┌─────────────────────┐ │ twenty-front │ │ (React frontend) │ └─────────┬───────────┘ │ imports runtime: │ FrontComponentRenderer │ FrontComponentRendererWithSdkClient │ useFrontComponentExecutionContext ▼ ┌──────────────────────────────────┐ ┌─────────────────────────┐ │ twenty-front-component-renderer │────────▶│ twenty-sdk │ │ (remote-dom host + worker) │ │ (app developer SDK) │ │ │ │ │ │ imports from twenty-sdk: │ │ Public API: │ │ • types only: │ │ defineFrontComponent │ │ FrontComponentExecutionContext│ │ navigate, closeSide… │ │ NavigateFunction │ │ useFrontComponent… │ │ CloseSidePanelFunction │ │ Command components │ │ CommandConfirmation… │ │ conditional avail. │ │ OpenCommandConfirmation… │ │ │ │ EnqueueSnackbarFunction │ │ Internal only: │ │ etc. │ │ frontComponentHost… │ │ │ │ front-component-build │ │ owns locally: │ │ esbuild plugins │ │ • ALLOWED_HTML_ELEMENTS │ │ │ │ • EVENT_TO_REACT │ └────────────┬────────────┘ │ • HTML_TAG_TO_CUSTOM_ELEMENT… │ │ │ • SerializedEventData │ │ types │ • PropertySchema │ ▼ │ • frontComponentHostComm… │ ┌─────────────────────────┐ │ (local ref to globalThis) │ │ twenty-shared │ │ • setFrontComponentExecution… │ │ (common types/utils) │ │ (local impl, same keys) │ │ AppPath, SidePanelP… │ │ │ │ EnqueueSnackbarParams │ └──────────────────────────────────┘ │ isDefined, … │ │ └─────────────────────────┘ │ also depends on ▼ twenty-shared (types) @remote-dom/* (runtime) @quilted/threads (runtime) react (runtime) ``` **Key points:** - **`twenty-front`** depends on the renderer, **not** on `twenty-sdk` directly (for rendering) - **`twenty-front-component-renderer`** depends on `twenty-sdk` for **types only** (function signatures, `FrontComponentExecutionContext`). The runtime bridge (`frontComponentHostCommunicationApi`) is shared via `globalThis` keys, not module imports - **`twenty-sdk`** has no dependency on the renderer — clean one-way dependency - The renderer owns all remote-dom infrastructure (element schemas, event mappings, custom element tags) that was previously leaking through the SDK's public API - The SDK's `./build` entry point was removed entirely (unused)
24 lines
677 B
TypeScript
24 lines
677 B
TypeScript
export const CUSTOM_ELEMENT_NAMES = {
|
|
ROOT: 'remote-root',
|
|
FRAGMENT: 'remote-fragment',
|
|
} as const;
|
|
|
|
export const INTERNAL_ELEMENT_CLASSES = {
|
|
ROOT: 'RemoteRootElement',
|
|
FRAGMENT: 'RemoteFragmentElement',
|
|
} as const;
|
|
|
|
export const OUTPUT_FILES = {
|
|
REMOTE_ELEMENTS: 'remote-elements.ts',
|
|
REMOTE_COMPONENTS: 'remote-components.ts',
|
|
HOST_REGISTRY: 'host-component-registry.ts',
|
|
} as const;
|
|
|
|
export const TYPE_NAMES = {
|
|
COMMON_PROPERTIES: 'HtmlCommonProperties',
|
|
COMMON_EVENTS: 'HtmlCommonEvents',
|
|
COMMON_PROPERTIES_CONFIG: 'HTML_COMMON_PROPERTIES_CONFIG',
|
|
COMMON_EVENTS_ARRAY: 'HTML_COMMON_EVENTS_ARRAY',
|
|
EMPTY_RECORD: 'Record<string, never>',
|
|
} as const;
|