Charles BochetandGitHub
1be87eb97b
## Summary - **Delete 10 unused files**: 7 hooks (`useWorkflowRunUnsafe`, `useGetViewById`, `useCreateViewFieldGroup`, `useDeleteViewFieldGroup`, `useUpdateViewFieldGroup`, `useCreateManyViewFieldGroups`, `useMoveViewColumns` + test), 1 component (`SettingsSummaryCard`), 1 utility (`createEventContext`) - **Rename `objectMetadataItemsState` → `objectMetadataItemsSelector`** across ~85 files to accurately reflect it is a derived selector (via `createAtomSelector`), not a base Jotai atom ## Details ### Dead code removed | Type | Name | Reason | |------|------|--------| | Hook | `useWorkflowRunUnsafe` | Never imported — duplicate of `useWorkflowRun` without schema validation | | Hook | `useGetViewById` | Never imported — `useViewById` is used instead | | Hook | `useCreateViewFieldGroup` | Never imported — CRUD done via `usePerformViewFieldGroupAPIPersist` | | Hook | `useDeleteViewFieldGroup` | Same as above | | Hook | `useUpdateViewFieldGroup` | Same as above | | Hook | `useCreateManyViewFieldGroups` | Same as above | | Hook | `useMoveViewColumns` | Only imported by its own test — no production usage | | Component | `SettingsSummaryCard` | Never imported anywhere | | Utility | `createEventContext` | Never imported anywhere | ### Rename `objectMetadataItemsState` is created via `createAtomSelector` (it derives from `objectMetadataItemsWithFieldsSelector`), so naming it `*State` is misleading. Renamed to `objectMetadataItemsSelector` for consistency with sibling selectors like `objectMetadataItemsByNamePluralMapSelector`.
66 lines
2.4 KiB
TypeScript
66 lines
2.4 KiB
TypeScript
import { type CommandMenuContextType } from '@/command-menu-item/contexts/CommandMenuContext';
|
|
import { CommandMenuContextProviderDefault } from '@/command-menu-item/contexts/CommandMenuContextProviderDefault';
|
|
import { CommandMenuContextProviderWorkflowObjects } from '@/command-menu-item/contexts/CommandMenuContextProviderWorkflowObjects';
|
|
import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataItemIdComponentState';
|
|
import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';
|
|
import { CoreObjectNameSingular } from 'twenty-shared/types';
|
|
import { type ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
|
|
import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';
|
|
import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
export const CommandMenuContextProviderLegacy = ({
|
|
children,
|
|
isInSidePanel,
|
|
displayType,
|
|
containerType,
|
|
objectMetadataItemOverride,
|
|
}: Omit<CommandMenuContextType, 'commandMenuItems'> & {
|
|
children: React.ReactNode;
|
|
objectMetadataItemOverride?: ObjectMetadataItem;
|
|
}) => {
|
|
const contextStoreCurrentObjectMetadataItemId = useAtomComponentStateValue(
|
|
contextStoreCurrentObjectMetadataItemIdComponentState,
|
|
);
|
|
|
|
const objectMetadataItems = useAtomStateValue(objectMetadataItemsSelector);
|
|
|
|
const objectMetadataItem =
|
|
objectMetadataItemOverride ??
|
|
objectMetadataItems.find(
|
|
(objectMetadataItem) =>
|
|
objectMetadataItem.id === contextStoreCurrentObjectMetadataItemId,
|
|
);
|
|
|
|
if (!isDefined(objectMetadataItem)) {
|
|
return null;
|
|
}
|
|
|
|
const isWorkflowObject =
|
|
objectMetadataItem.nameSingular === CoreObjectNameSingular.Workflow;
|
|
|
|
if (isWorkflowObject) {
|
|
return (
|
|
<CommandMenuContextProviderWorkflowObjects
|
|
isInSidePanel={isInSidePanel}
|
|
displayType={displayType}
|
|
containerType={containerType}
|
|
objectMetadataItem={objectMetadataItem}
|
|
>
|
|
{children}
|
|
</CommandMenuContextProviderWorkflowObjects>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<CommandMenuContextProviderDefault
|
|
isInSidePanel={isInSidePanel}
|
|
displayType={displayType}
|
|
containerType={containerType}
|
|
objectMetadataItem={objectMetadataItem}
|
|
>
|
|
{children}
|
|
</CommandMenuContextProviderDefault>
|
|
);
|
|
};
|