Charles BochetandGitHub
9e21e55db4
## Fix resolver schema leaking between `/metadata` and `/graphql` endpoints ### Summary - Patch `@nestjs/graphql` to support a `resolverSchemaScope` option that filters resolvers at both schema generation and runtime, preventing cross-endpoint leaking - Introduce `@CoreResolver()` and `@MetadataResolver()` decorators to explicitly scope each resolver to its endpoint - Move most resolvers (auth, billing, workspace, user, etc.) to the metadata schema where the frontend expects them; only workflow and timeline calendar/messaging resolvers remain on `/graphql` - Fix frontend `SSEQuerySubscribeEffect` to use the default (metadata) Apollo client instead of the core client ### Problem NestJS GraphQL's module-based resolver discovery traverses transitive imports, causing resolvers from `/metadata` modules to leak into the `/graphql` schema and vice versa. This made the schemas unpredictable and tightly coupled to module import order. ### Approach - Added `resolverSchemaScope` to `GqlModuleOptions` via a patch on `@nestjs/graphql`, filtering in both `filterResolvers()` (runtime binding) and `getAllCtors()` (schema generation) - Each resolver is explicitly decorated with `@CoreResolver()` or `@MetadataResolver()` - Organized decorator, constant, and type files under `graphql-config/` following project conventions Core GQL Schema: (see: no more fields!) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/668f3f0f-485e-43f0-92be-4345aeccacb6" /> Metadata GQL Schema (see no more getTimelineCalendarEventsFromCompany) <img width="827" height="894" alt="image" src="https://github.com/user-attachments/assets/443913db-e5fe-4161-b0e7-4a971cc80a71" />
74 lines
2.2 KiB
TypeScript
74 lines
2.2 KiB
TypeScript
import request from 'supertest';
|
|
|
|
const client = request(`http://localhost:${APP_PORT}`);
|
|
|
|
describe('objectsResolver (e2e)', () => {
|
|
it('should find many objects', () => {
|
|
const queryData = {
|
|
query: `
|
|
query objects {
|
|
objects {
|
|
edges {
|
|
node {
|
|
id
|
|
nameSingular
|
|
namePlural
|
|
labelSingular
|
|
labelPlural
|
|
description
|
|
icon
|
|
isCustom
|
|
isRemote
|
|
isActive
|
|
isSystem
|
|
createdAt
|
|
updatedAt
|
|
labelIdentifierFieldMetadataId
|
|
imageIdentifierFieldMetadataId
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`,
|
|
};
|
|
|
|
return client
|
|
.post('/metadata')
|
|
.set('Authorization', `Bearer ${APPLE_JANE_ADMIN_ACCESS_TOKEN}`)
|
|
.send(queryData)
|
|
.expect(200)
|
|
.expect((res) => {
|
|
expect(res.body.data).toBeDefined();
|
|
expect(res.body.errors).toBeUndefined();
|
|
})
|
|
.expect((res) => {
|
|
const data = res.body.data.objects;
|
|
|
|
expect(data).toBeDefined();
|
|
expect(Array.isArray(data.edges)).toBe(true);
|
|
|
|
const edges = data.edges;
|
|
|
|
if (edges.length > 0) {
|
|
const objects = edges[0].node;
|
|
|
|
expect(objects).toHaveProperty('id');
|
|
expect(objects).toHaveProperty('nameSingular');
|
|
expect(objects).toHaveProperty('namePlural');
|
|
expect(objects).toHaveProperty('labelSingular');
|
|
expect(objects).toHaveProperty('labelPlural');
|
|
expect(objects).toHaveProperty('description');
|
|
expect(objects).toHaveProperty('icon');
|
|
expect(objects).toHaveProperty('isCustom');
|
|
expect(objects).toHaveProperty('isRemote');
|
|
expect(objects).toHaveProperty('isActive');
|
|
expect(objects).toHaveProperty('isSystem');
|
|
expect(objects).toHaveProperty('createdAt');
|
|
expect(objects).toHaveProperty('updatedAt');
|
|
expect(objects).toHaveProperty('labelIdentifierFieldMetadataId');
|
|
expect(objects).toHaveProperty('imageIdentifierFieldMetadataId');
|
|
}
|
|
});
|
|
});
|
|
});
|