Charles BochetandGitHub
9d57bc39e5
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
135 lines
3.4 KiB
JSON
135 lines
3.4 KiB
JSON
{
|
|
"name": "twenty-ui",
|
|
"$schema": "../../node_modules/nx/schemas/project-schema.json",
|
|
"sourceRoot": "packages/twenty-ui/src",
|
|
"projectType": "library",
|
|
"tags": [
|
|
"scope:shared"
|
|
],
|
|
"targets": {
|
|
"build": {
|
|
"dependsOn": [
|
|
"^build",
|
|
"generateBarrels"
|
|
],
|
|
"outputs": [
|
|
"{projectRoot}/dist",
|
|
"{projectRoot}/accessibility/package.json",
|
|
"{projectRoot}/accessibility/dist",
|
|
"{projectRoot}/assets/package.json",
|
|
"{projectRoot}/assets/dist",
|
|
"{projectRoot}/components/package.json",
|
|
"{projectRoot}/components/dist",
|
|
"{projectRoot}/display/package.json",
|
|
"{projectRoot}/display/dist",
|
|
"{projectRoot}/feedback/package.json",
|
|
"{projectRoot}/feedback/dist",
|
|
"{projectRoot}/input/package.json",
|
|
"{projectRoot}/input/dist",
|
|
"{projectRoot}/json-visualizer/package.json",
|
|
"{projectRoot}/json-visualizer/dist",
|
|
"{projectRoot}/layout/package.json",
|
|
"{projectRoot}/layout/dist",
|
|
"{projectRoot}/navigation/package.json",
|
|
"{projectRoot}/navigation/dist",
|
|
"{projectRoot}/testing/package.json",
|
|
"{projectRoot}/testing/dist",
|
|
"{projectRoot}/theme/package.json",
|
|
"{projectRoot}/theme/dist",
|
|
"{projectRoot}/theme-constants/package.json",
|
|
"{projectRoot}/theme-constants/dist",
|
|
"{projectRoot}/utilities/package.json",
|
|
"{projectRoot}/utilities/dist"
|
|
]
|
|
},
|
|
"generateThemeConstants": {
|
|
"executor": "nx:run-commands",
|
|
"dependsOn": [
|
|
"build"
|
|
],
|
|
"cache": true,
|
|
"inputs": [
|
|
"{projectRoot}/scripts/generateThemeConstants.ts"
|
|
],
|
|
"outputs": [
|
|
"{projectRoot}/src/theme-constants/generated"
|
|
],
|
|
"options": {
|
|
"command": "tsx {projectRoot}/scripts/generateThemeConstants.ts"
|
|
}
|
|
},
|
|
"generateBarrels": {
|
|
"executor": "nx:run-commands",
|
|
"cache": true,
|
|
"inputs": [
|
|
"production",
|
|
"{projectRoot}/scripts/generateBarrels.ts"
|
|
],
|
|
"outputs": [
|
|
"{projectRoot}/src/**/*/index.ts",
|
|
"{projectRoot}/package.json"
|
|
],
|
|
"options": {
|
|
"command": "tsx {projectRoot}/scripts/generateBarrels.ts"
|
|
}
|
|
},
|
|
"build:individual": {
|
|
"executor": "nx:run-commands",
|
|
"cache": true,
|
|
"dependsOn": [
|
|
"build"
|
|
],
|
|
"inputs": [
|
|
"production",
|
|
"^production"
|
|
],
|
|
"outputs": [
|
|
"{projectRoot}/dist/individual"
|
|
],
|
|
"options": {
|
|
"cwd": "{projectRoot}",
|
|
"command": "npx vite build -c vite.config.individual.ts"
|
|
}
|
|
},
|
|
"clean": {
|
|
"executor": "nx:run-commands",
|
|
"options": {
|
|
"command": "rimraf {projectRoot}/dist"
|
|
}
|
|
},
|
|
"lint": {},
|
|
"fmt": {
|
|
"options": {
|
|
"files": "src"
|
|
},
|
|
"configurations": {
|
|
"fix": {}
|
|
}
|
|
},
|
|
"test": {},
|
|
"typecheck": {},
|
|
"storybook:build": {
|
|
"configurations": {
|
|
"test": {}
|
|
}
|
|
},
|
|
"storybook:serve:dev": {
|
|
"options": {
|
|
"port": 6007
|
|
}
|
|
},
|
|
"storybook:serve:static": {
|
|
"options": {
|
|
"buildTarget": "twenty-ui:storybook:build",
|
|
"port": 6007
|
|
},
|
|
"configurations": {
|
|
"test": {}
|
|
}
|
|
},
|
|
"storybook:test": {},
|
|
"storybook:test:no-coverage": {},
|
|
"storybook:coverage": {}
|
|
}
|
|
}
|