44aee860d9
## Summary Clean up and consolidate formatting configuration across the monorepo. ## Changes ### 1. Remove Redundant Configs - ❌ Delete `packages/twenty-server/.prettierrc` (had invalid `brakeBeforeElse` typo) - ❌ Delete `packages/twenty-zapier/.prettierrc` - ✅ Use root `.prettierrc` only (Prettier searches up directory tree automatically) ### 2. Improve Root Prettier Config - Change `endOfLine: 'auto'` → `'lf'` for consistent Unix line endings across all OSes ### 3. Enhance VSCode Settings - `files.eol: 'auto'` → `'\\n'` (consistent with Prettier) - Add `files.insertFinalNewline: true` (explicit editor behavior) - Add `files.trimTrailingWhitespace: true` (cleaner files) ### 4. Add `.gitattributes` - Enforce LF line endings at Git level - Prevents `core.autocrlf` from converting based on contributor's OS - Mark patch files as binary (they have mixed line endings by design) - Explicitly define binary file types ### 5. Fix Line Endings - Convert 3 selectable-list state files from CRLF → LF - These were the only source files with Windows line endings ## Why These Changes Matter **Before:** - 3 different Prettier configs (inconsistent, one had typo) - Mixed CRLF/LF depending on contributor's OS - No Git-level enforcement **After:** - Single source of truth for formatting - All files use LF (Unix standard) - Git enforces line endings regardless of OS - Prettier warning about invalid option removed ## Result - ✅ Single `.prettierrc` config - ✅ Consistent LF line endings enforced by Git - ✅ Better VSCode defaults - ✅ No more CRLF files sneaking in from Windows contributors
48 lines
1.3 KiB
TypeScript
48 lines
1.3 KiB
TypeScript
import { ESLintUtils, type TSESTree } from '@typescript-eslint/utils';
|
|
import ts from 'typescript';
|
|
|
|
export const RULE_NAME = 'explicit-boolean-predicates-in-if';
|
|
|
|
const isBooleanType = (type: ts.Type) => {
|
|
// check if boolean flag(s) is set on the type (e.g. boolean, true, false, etc.)
|
|
return type && (type.flags & ts.TypeFlags.BooleanLike) !== 0;
|
|
};
|
|
|
|
export const rule = ESLintUtils.RuleCreator(() => __filename)({
|
|
name: RULE_NAME,
|
|
meta: {
|
|
type: 'suggestion',
|
|
docs: {
|
|
description: 'Enforce explicit boolean predicates in if statements',
|
|
},
|
|
fixable: 'code',
|
|
schema: [],
|
|
messages: {
|
|
nonExplicitPredicate:
|
|
'Use an explicit boolean predicate in if statements.',
|
|
},
|
|
},
|
|
defaultOptions: [],
|
|
create: (context) => {
|
|
const services = ESLintUtils.getParserServices(context);
|
|
const typeChecker = services.program.getTypeChecker();
|
|
|
|
return {
|
|
IfStatement: (node: TSESTree.IfStatement) => {
|
|
const tsNode = services.esTreeNodeToTSNodeMap.get(node.test);
|
|
const type = typeChecker.getTypeAtLocation(tsNode);
|
|
|
|
if (!isBooleanType(type)) {
|
|
const { test } = node;
|
|
context.report({
|
|
node: test,
|
|
messageId: 'nonExplicitPredicate',
|
|
});
|
|
}
|
|
},
|
|
};
|
|
},
|
|
});
|
|
|
|
export default rule;
|