## Summary
The `lint:changed` command was not using the correct ESLint config for
`twenty-server`, causing it to use the root `eslint.config.mjs` instead
of the package-specific one. This PR fixes the issue and renames the
command to `lint:diff-with-main` for clarity.
## Problem
- `twenty-front` correctly specified `--config
packages/twenty-front/eslint.config.mjs`
- `twenty-server` just called `npx eslint` without specifying a config
- This meant `twenty-server` was missing important rules like:
- `@typescript-eslint/no-explicit-any: 'error'`
- `@stylistic/*` rules (linebreak-style, padding, etc.)
- `import/order` with NestJS patterns
- Custom workspace rules (`@nx/workspace-inject-workspace-repository`,
etc.)
## Solution
1. **Renamed** `lint:changed` to `lint:diff-with-main` to be explicit
about what the command does
2. **Centralized** the configuration in `nx.json` targetDefaults:
- Uses `{projectRoot}` interpolation for paths (resolved by Nx at
runtime)
- Each package automatically uses its own ESLint config
- Packages can override specific options (e.g., file extension pattern)
3. **Simplified** `project.json` files by inheriting from defaults
## Usage
```bash
# Lint only files changed vs main branch
npx nx lint:diff-with-main twenty-front
npx nx lint:diff-with-main twenty-server
# Auto-fix files changed vs main
npx nx lint:diff-with-main twenty-front --configuration=fix
```
## Changes
- **nx.json**: Added `lint:diff-with-main` target default with
configurable pattern
- **twenty-front/project.json**: Simplified to inherit from defaults
- **twenty-server/project.json**: Overrides pattern to include `.json`
files
- **CLAUDE.md** and **.cursor/rules**: Updated documentation
277 lines
5.5 KiB
JSON
277 lines
5.5 KiB
JSON
{
|
|
"name": "twenty-front",
|
|
"$schema": "../../node_modules/nx/schemas/project-schema.json",
|
|
"projectType": "application",
|
|
"tags": [
|
|
"scope:frontend"
|
|
],
|
|
"targets": {
|
|
"build": {
|
|
"outputs": [
|
|
"{options.outputPath}"
|
|
],
|
|
"options": {
|
|
"outputPath": "{projectRoot}/build"
|
|
},
|
|
"dependsOn": [
|
|
"^build"
|
|
]
|
|
},
|
|
"build:sourcemaps": {
|
|
"outputs": [
|
|
"{options.outputPath}"
|
|
],
|
|
"options": {
|
|
"outputPath": "{projectRoot}/build"
|
|
},
|
|
"dependsOn": [
|
|
"^build"
|
|
]
|
|
},
|
|
"serve": {
|
|
"executor": "nx:run-commands",
|
|
"options": {
|
|
"command": "npx serve -s {projectRoot}/build"
|
|
}
|
|
},
|
|
"start": {
|
|
"executor": "@nx/vite:dev-server",
|
|
"options": {
|
|
"buildTarget": "twenty-front:build",
|
|
"hmr": true
|
|
}
|
|
},
|
|
"preview": {
|
|
"executor": "@nx/vite:preview-server",
|
|
"options": {
|
|
"buildTarget": "twenty-front:build",
|
|
"port": 3001,
|
|
"open": true
|
|
}
|
|
},
|
|
"reset:env": {
|
|
"executor": "nx:run-commands",
|
|
"inputs": [
|
|
"{projectRoot}/.env.example"
|
|
],
|
|
"outputs": [
|
|
"{projectRoot}/.env"
|
|
],
|
|
"cache": true,
|
|
"options": {
|
|
"cwd": "{projectRoot}",
|
|
"command": "cp .env.example .env"
|
|
}
|
|
},
|
|
"typecheck": {},
|
|
"lint": {
|
|
"options": {
|
|
"maxWarnings": 0
|
|
},
|
|
"configurations": {
|
|
"ci": {},
|
|
"fix": {}
|
|
}
|
|
},
|
|
"lint:diff-with-main": {},
|
|
"fmt": {
|
|
"options": {
|
|
"files": "src"
|
|
},
|
|
"configurations": {
|
|
"fix": {}
|
|
}
|
|
},
|
|
"test": {},
|
|
"storybook:build": {
|
|
"options": {
|
|
"env": {
|
|
"NODE_OPTIONS": "--max_old_space_size=8000"
|
|
}
|
|
},
|
|
"configurations": {
|
|
"docs": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "ui-docs"
|
|
}
|
|
},
|
|
"modules": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "modules"
|
|
}
|
|
},
|
|
"pages": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "pages"
|
|
}
|
|
},
|
|
"performance": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "performance"
|
|
}
|
|
}
|
|
}
|
|
},
|
|
"storybook:serve:dev": {
|
|
"options": {
|
|
"port": 6006
|
|
},
|
|
"configurations": {
|
|
"docs": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "ui-docs"
|
|
}
|
|
},
|
|
"modules": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "modules"
|
|
}
|
|
},
|
|
"pages": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "pages"
|
|
}
|
|
},
|
|
"performance": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "performance"
|
|
}
|
|
}
|
|
}
|
|
},
|
|
"storybook:serve:static": {
|
|
"options": {
|
|
"port": 6006
|
|
},
|
|
"configurations": {
|
|
"docs": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "ui-docs"
|
|
}
|
|
},
|
|
"modules": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "modules"
|
|
}
|
|
},
|
|
"pages": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "pages"
|
|
}
|
|
},
|
|
"performance": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "performance"
|
|
}
|
|
}
|
|
}
|
|
},
|
|
"storybook:coverage": {
|
|
"configurations": {
|
|
"text": {},
|
|
"docs": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "ui-docs"
|
|
}
|
|
},
|
|
"modules": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "modules"
|
|
}
|
|
},
|
|
"pages": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "pages"
|
|
}
|
|
},
|
|
"performance": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "performance"
|
|
}
|
|
}
|
|
}
|
|
},
|
|
"storybook:test": {
|
|
"options": {
|
|
"port": 6006
|
|
},
|
|
"configurations": {
|
|
"docs": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "ui-docs"
|
|
}
|
|
},
|
|
"modules": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "modules"
|
|
}
|
|
},
|
|
"pages": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "pages"
|
|
}
|
|
},
|
|
"performance": {
|
|
"env": {
|
|
"STORYBOOK_SCOPE": "performance"
|
|
}
|
|
}
|
|
}
|
|
},
|
|
"storybook:serve-and-test:static": {
|
|
"options": {
|
|
"port": 6006
|
|
},
|
|
"configurations": {
|
|
"docs": {
|
|
"scope": "ui-docs"
|
|
},
|
|
"modules": {
|
|
"scope": "modules"
|
|
},
|
|
"pages": {
|
|
"scope": "pages"
|
|
},
|
|
"performance": {
|
|
"scope": "performance"
|
|
}
|
|
}
|
|
},
|
|
"graphql:generate": {
|
|
"executor": "nx:run-commands",
|
|
"defaultConfiguration": "data",
|
|
"options": {
|
|
"cwd": "{projectRoot}",
|
|
"command": "dotenv graphql-codegen -- --config={args.config}"
|
|
},
|
|
"configurations": {
|
|
"data": {
|
|
"config": "codegen.cjs"
|
|
},
|
|
"metadata": {
|
|
"config": "codegen-metadata.cjs"
|
|
}
|
|
}
|
|
},
|
|
"chromatic": {
|
|
"configurations": {
|
|
"ci": {}
|
|
}
|
|
},
|
|
"lingui:extract": {
|
|
"executor": "nx:run-commands",
|
|
"options": {
|
|
"cwd": "{projectRoot}",
|
|
"command": "lingui extract --overwrite --clean"
|
|
}
|
|
},
|
|
"lingui:compile": {
|
|
"executor": "nx:run-commands",
|
|
"options": {
|
|
"cwd": "{projectRoot}",
|
|
"command": "lingui compile --typescript"
|
|
}
|
|
}
|
|
}
|
|
}
|