Files
twenty/packages/twenty-server/test/integration/rest/suites/view.integration-spec.ts
T
Charles BochetandGitHub 5c745059ad refactor: remove "core" naming from views and eliminate converter layer (#18667)
## Summary

- **Remove all "core" prefixes** from the views system — the
metadata-based storage migration is complete, so `CoreView`,
`coreViewsSelector`, `getCoreViews`, etc. are now just `View`,
`viewsSelector`, `getViews`
- **Eliminate the entire converter layer** (15 files, ~850 lines
deleted) — `convertCoreViewToView` and all sub-converters were either
no-ops or trivially adding `__typename` / mapping identical enum values.
Local enums now re-export from generated GraphQL types directly (single
source of truth)
- **Unify `View` and `ViewWithRelations`** into one type —
`ViewWithRelations` is now a type alias for `View`, selectors return
data directly without conversion

### Backend
- Rename `@ObjectType('CoreView')` → `@ObjectType('View')` (and all
sub-entities)
- Rename resolver methods: `getCoreViews` → `getViews`, `createCoreView`
→ `createView`, etc.
- Rename `FIND_ALL_CORE_VIEWS_GRAPHQL_OPERATION` →
`FIND_ALL_VIEWS_GRAPHQL_OPERATION`

### Frontend
- Delete 15 converter files (`convertGqlView*ToView*`,
`convertView*ToGql`, `convertViewWithRelationsToView`)
- Re-export `ViewType`, `ViewKey`, `ViewFilterGroupLogicalOperator` from
generated enums (no more duplicate enum definitions with different
casing)
- Replace `ViewOpenRecordInType` with `ViewOpenRecordIn` from generated
- Remove `__typename` from all local view sub-types
- Remove unused `variant` from `ViewFilter`, make `displayValue` and
`definition` optional
- Rename ~45 GraphQL query/mutation files and all selectors to drop
"core" prefix
- Delete unused `viewsWithRelationsSelector`
2026-03-16 09:57:18 +01:00

303 lines
9.3 KiB
TypeScript

import { createOneSelectFieldMetadataForIntegrationTests } from 'test/integration/metadata/suites/field-metadata/utils/create-one-select-field-metadata-for-integration-tests.util';
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
import { destroyOneView } from 'test/integration/metadata/suites/view/utils/destroy-one-view.util';
import { makeRestAPIRequest } from 'test/integration/rest/utils/make-rest-api-request.util';
import {
assertRestApiErrorNotFoundResponse,
assertRestApiSuccessfulResponse,
} from 'test/integration/rest/utils/rest-test-assertions.util';
import { createTestViewWithRestApi } from 'test/integration/rest/utils/view-rest-api.util';
import { generateRecordName } from 'test/integration/utils/generate-record-name';
import { assertViewStructure } from 'test/integration/utils/view-test.util';
import { ViewOpenRecordIn, ViewType } from 'twenty-shared/types';
import { ViewKey } from 'twenty-shared/types';
describe('View REST API', () => {
let testObjectMetadataId: string;
let testSelectFieldMetadataId: string;
let testViewId: string | undefined;
beforeAll(async () => {
const {
data: {
createOneObject: { id: objectMetadataId },
},
} = await createOneObjectMetadata({
input: {
nameSingular: 'testViewObject',
namePlural: 'testViewObjects',
labelSingular: 'Test View Object',
labelPlural: 'Test View Objects',
icon: 'IconView',
},
});
testObjectMetadataId = objectMetadataId;
const { selectFieldMetadataId } =
await createOneSelectFieldMetadataForIntegrationTests({
input: {
objectMetadataId,
},
});
testSelectFieldMetadataId = selectFieldMetadataId;
});
afterAll(async () => {
await updateOneObjectMetadata({
expectToFail: false,
input: {
idToUpdate: testObjectMetadataId,
updatePayload: {
isActive: false,
},
},
});
await deleteOneObjectMetadata({
input: { idToDelete: testObjectMetadataId },
});
});
afterEach(async () => {
if (!testViewId) return;
await destroyOneView({
viewId: testViewId,
expectToFail: false,
});
testViewId = undefined;
});
describe('GET /metadata/views', () => {
it('should return all views for workspace', async () => {
const response = await makeRestAPIRequest({
method: 'get',
path: '/metadata/views',
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(response);
expect(Array.isArray(response.body)).toBe(true);
});
it('should return views filtered by objectMetadataId', async () => {
const response = await makeRestAPIRequest({
method: 'get',
path: `/metadata/views?objectMetadataId=${testObjectMetadataId}`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(response);
expect(Array.isArray(response.body)).toBe(true);
if (response.body.length > 0) {
assertViewStructure(response.body[0]);
}
});
});
describe('POST /metadata/views', () => {
it('should create a new view', async () => {
const viewName = generateRecordName('Test View');
const view = await createTestViewWithRestApi({
name: viewName,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = view.id;
assertViewStructure(view, {
name: viewName,
objectMetadataId: testObjectMetadataId,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
});
});
it('should create a kanban view', async () => {
const viewName = generateRecordName('Test Kanban View');
const kanbanView = await createTestViewWithRestApi({
name: viewName,
icon: 'IconKanban',
type: ViewType.KANBAN,
key: null,
position: 1,
isCompact: true,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
mainGroupByFieldMetadataId: testSelectFieldMetadataId,
});
testViewId = kanbanView.id;
assertViewStructure(kanbanView, {
name: viewName,
type: ViewType.KANBAN,
isCompact: true,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
});
});
describe('GET /metadata/views/:id', () => {
it('should return a view by id', async () => {
const viewName = generateRecordName('Test View for Get');
const view = await createTestViewWithRestApi({
name: viewName,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = view.id;
const response = await makeRestAPIRequest({
method: 'get',
path: `/metadata/views/${view.id}`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(response);
assertViewStructure(response.body, {
id: view.id,
name: viewName,
objectMetadataId: testObjectMetadataId,
});
});
it('should return empty object for non-existent view', async () => {
const response = await makeRestAPIRequest({
method: 'get',
path: `/metadata/views/20202020-b7a4-4f8e-9c1d-2e3f4a5b6c7d`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiErrorNotFoundResponse(response);
});
});
describe('PATCH /metadata/views/:id', () => {
it('should update an existing view', async () => {
const viewName = generateRecordName('Test View for Update');
const view = await createTestViewWithRestApi({
name: viewName,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = view.id;
const updatedName = generateRecordName('Updated View');
const updateData = {
name: updatedName,
type: ViewType.KANBAN,
isCompact: true,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
mainGroupByFieldMetadataId: testSelectFieldMetadataId,
};
const response = await makeRestAPIRequest({
method: 'patch',
path: `/metadata/views/${view.id}`,
body: updateData,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(response);
assertViewStructure(response.body, {
id: view.id,
name: updatedName,
type: ViewType.KANBAN,
isCompact: true,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
});
it('should return 404 error when updating non-existent view', async () => {
const updateData = {
name: 'Updated View',
type: ViewType.KANBAN,
};
const response = await makeRestAPIRequest({
method: 'patch',
path: `/metadata/views/20202020-b7a4-4f8e-9c1d-2e3f4a5b6c7d`,
body: updateData,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiErrorNotFoundResponse(response);
});
});
describe('DELETE /metadata/views/:id', () => {
it('should delete an existing view', async () => {
const viewName = generateRecordName('Test View for Delete');
const view = await createTestViewWithRestApi({
name: viewName,
icon: 'IconTable',
type: ViewType.TABLE,
key: ViewKey.INDEX,
position: 0,
isCompact: false,
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
objectMetadataId: testObjectMetadataId,
});
testViewId = view.id;
const deleteResponse = await makeRestAPIRequest({
method: 'delete',
path: `/metadata/views/${view.id}`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiSuccessfulResponse(deleteResponse);
expect(deleteResponse.body.success).toBe(true);
const getResponse = await makeRestAPIRequest({
method: 'get',
path: `/metadata/views/${view.id}`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiErrorNotFoundResponse(getResponse);
});
it('should return 404 error when deleting non-existent view', async () => {
const response = await makeRestAPIRequest({
method: 'delete',
path: `/metadata/views/20202020-b7a4-4f8e-9c1d-2e3f4a5b6c7d`,
bearer: APPLE_JANE_ADMIN_ACCESS_TOKEN,
});
assertRestApiErrorNotFoundResponse(response);
});
});
});