## Summary Replaces the bolted-on `isTool` + `toolInputSchema` fields on `LogicFunctionManifest` with two distinct, opt-in triggers that align with the existing `cron` / `databaseEvent` / `httpRoute` trigger pattern: - **`toolTriggerSettings`** — exposes the function as an AI tool (chat / MCP / function calling). Uses standard JSON Schema (the format LLMs natively understand). - **`workflowActionTriggerSettings`** — exposes the function as a step in the visual workflow builder. Uses Twenty's rich `InputSchema` so the builder can render proper `FieldMetadataType`-aware editors, variable pickers, labels, and an optional `outputSchema`. A function can opt into none, one, or both. Each surface gets the schema format appropriate for it. ### Why `isTool: true` previously exposed the function as both an AI tool AND a workflow node, with the same JSON Schema feeding both — but the workflow builder really wants Twenty's `InputSchema` (with `CURRENCY`, `RELATION`, `EMAILS`, etc.) and the AI surface really wants standard JSON Schema. Today the workflow builder hacks around this by treating JSON Schema as `InputSchema`, which silently breaks for any non-primitive field type. Splitting the triggers fixes that and lets each surface evolve independently. ### Migration - **Fast** instance command adds the two new nullable columns. - **Slow** instance command backfills `toolTriggerSettings` + `workflowActionTriggerSettings` from `isTool=true` rows (preserving today's both-surfaces behaviour) then drops the legacy columns. ### Stacked Stacked on top of #20181. Merge that first, then this. ## Test plan - [ ] CI green (oxlint, typecheck, jest, vitest) - [ ] Run `--include-slow` upgrade against a workspace with existing `isTool=true` logic functions; verify both new columns populated and old columns dropped - [ ] Verify AI chat sees migrated tool functions (Linear create-issue, Exa search) and can call them with the JSON Schema - [ ] Add an AI-tool function from the Settings UI (toggles `toolTriggerSettings`) and verify it shows up in chat - [ ] Add a workflow-action function from the Settings UI (toggles `workflowActionTriggerSettings`) and verify it appears in the workflow node picker - [ ] In the workflow builder, edit a `LOGIC_FUNCTION` step and verify input fields render (no more JSON-Schema-as-InputSchema hack) - [ ] Try defining a function with no triggers in the SDK and verify `defineLogicFunction` rejects it 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: martmull <martmull@hotmail.fr>
294 lines
9.1 KiB
TypeScript
294 lines
9.1 KiB
TypeScript
import { createOneLogicFunction } from 'test/integration/metadata/suites/logic-function/utils/create-logic-function.util';
|
|
import { deleteLogicFunction } from 'test/integration/metadata/suites/logic-function/utils/delete-logic-function.util';
|
|
import { executeLogicFunction } from 'test/integration/metadata/suites/logic-function/utils/execute-logic-function.util';
|
|
import { updateLogicFunctionSource } from 'test/integration/metadata/suites/logic-function/utils/update-logic-function-source.util';
|
|
|
|
import { LogicFunctionExecutionStatus } from 'src/engine/metadata-modules/logic-function/dtos/logic-function-execution-result.dto';
|
|
|
|
// Default template function code that matches the expected behavior
|
|
const DEFAULT_TEMPLATE_FUNCTION_CODE = `export const main = async (params: { a: string; b: number }): Promise<object> => {
|
|
return { message: \`Toto: \${params.a} and \${params.b}\` };
|
|
};`;
|
|
|
|
// Test function using external packages from default layer (lodash.groupby)
|
|
const EXTERNAL_PACKAGES_FUNCTION_CODE = `import groupBy from 'lodash.groupby';
|
|
|
|
export const main = async (params: { items: Array<{ category: string; name: string }> }): Promise<object> => {
|
|
const grouped = groupBy(params.items, 'category');
|
|
return {
|
|
grouped,
|
|
categories: Object.keys(grouped),
|
|
};
|
|
};`;
|
|
|
|
// Test function that throws an error
|
|
const ERROR_FUNCTION_CODE = `export const main = async (params: { shouldFail: boolean }): Promise<object> => {
|
|
if (params.shouldFail) {
|
|
throw new Error('Intentional test error');
|
|
}
|
|
return { success: true };
|
|
};`;
|
|
|
|
describe('Logic Function Execution', () => {
|
|
const createdFunctionIds: string[] = [];
|
|
|
|
afterAll(async () => {
|
|
// Clean up all created functions
|
|
for (const functionId of createdFunctionIds) {
|
|
try {
|
|
await deleteLogicFunction({
|
|
input: { id: functionId },
|
|
expectToFail: false,
|
|
});
|
|
} catch {
|
|
// Ignore cleanup errors
|
|
}
|
|
}
|
|
});
|
|
|
|
it('should execute the default logic function template', async () => {
|
|
// Create the function with default template code
|
|
const { data: createData } = await createOneLogicFunction({
|
|
input: {
|
|
name: 'Test Default Function',
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const functionId = createData?.createOneLogicFunction?.id;
|
|
|
|
expect(functionId).toBeDefined();
|
|
createdFunctionIds.push(functionId);
|
|
|
|
await updateLogicFunctionSource({
|
|
input: {
|
|
id: createData.createOneLogicFunction.id,
|
|
update: {
|
|
sourceHandlerCode: DEFAULT_TEMPLATE_FUNCTION_CODE,
|
|
},
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
// Execute with the default template's expected params: { a: string, b: number }
|
|
const { data: executeData } = await executeLogicFunction({
|
|
input: {
|
|
id: functionId,
|
|
payload: { a: 'hello', b: 42 },
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const result = executeData?.executeOneLogicFunction;
|
|
|
|
if (result?.status !== LogicFunctionExecutionStatus.SUCCESS) {
|
|
throw new Error(JSON.stringify(result?.error, null, 2));
|
|
}
|
|
|
|
expect(result?.status).toBe(LogicFunctionExecutionStatus.SUCCESS);
|
|
expect(result?.data).toMatchObject({
|
|
message: 'Toto: hello and 42',
|
|
});
|
|
expect(result?.duration).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('should execute a function with external packages (lodash.groupby)', async () => {
|
|
// Create the function with the external packages code
|
|
const { data: createData } = await createOneLogicFunction({
|
|
input: {
|
|
name: 'External Packages Test',
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const functionId = createData?.createOneLogicFunction?.id;
|
|
|
|
expect(functionId).toBeDefined();
|
|
createdFunctionIds.push(functionId);
|
|
|
|
await updateLogicFunctionSource({
|
|
input: {
|
|
id: createData.createOneLogicFunction.id,
|
|
update: {
|
|
sourceHandlerCode: EXTERNAL_PACKAGES_FUNCTION_CODE,
|
|
},
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
// Execute the function with items to group
|
|
const { data: executeData } = await executeLogicFunction({
|
|
input: {
|
|
id: functionId,
|
|
payload: {
|
|
items: [
|
|
{ category: 'fruit', name: 'apple' },
|
|
{ category: 'vegetable', name: 'carrot' },
|
|
{ category: 'fruit', name: 'banana' },
|
|
],
|
|
},
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const result = executeData?.executeOneLogicFunction;
|
|
|
|
if (result?.status !== LogicFunctionExecutionStatus.SUCCESS) {
|
|
throw new Error(JSON.stringify(result?.error, null, 2));
|
|
}
|
|
|
|
expect(result?.status).toBe(LogicFunctionExecutionStatus.SUCCESS);
|
|
|
|
const data = result?.data as unknown as {
|
|
grouped: Record<string, Array<{ category: string; name: string }>>;
|
|
categories: string[];
|
|
};
|
|
|
|
expect(data?.grouped).toMatchObject({
|
|
fruit: [
|
|
{ category: 'fruit', name: 'apple' },
|
|
{ category: 'fruit', name: 'banana' },
|
|
],
|
|
vegetable: [{ category: 'vegetable', name: 'carrot' }],
|
|
});
|
|
expect(data?.categories).toEqual(
|
|
expect.arrayContaining(['fruit', 'vegetable']),
|
|
);
|
|
});
|
|
|
|
it('should create logic function without source', async () => {
|
|
// Create the function with default template code
|
|
const { data: createData } = await createOneLogicFunction({
|
|
input: {
|
|
name: 'Test Default Function',
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const functionId = createData?.createOneLogicFunction?.id;
|
|
|
|
expect(functionId).toBeDefined();
|
|
createdFunctionIds.push(functionId);
|
|
|
|
// Execute with the default template's expected params: { a: string, b: number }
|
|
const { data: executeData } = await executeLogicFunction({
|
|
input: {
|
|
id: functionId,
|
|
payload: { a: 'hello', b: 42 },
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const result = executeData?.executeOneLogicFunction;
|
|
|
|
if (result?.status !== LogicFunctionExecutionStatus.SUCCESS) {
|
|
throw new Error(JSON.stringify(result?.error, null, 2));
|
|
}
|
|
|
|
expect(result?.status).toBe(LogicFunctionExecutionStatus.SUCCESS);
|
|
expect(result?.data).toMatchObject({
|
|
message: 'Hello, input: hello and 42',
|
|
});
|
|
expect(result?.duration).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('should create logic function with source', async () => {
|
|
// Create the function with default template code
|
|
const { data: createData } = await createOneLogicFunction({
|
|
input: {
|
|
name: 'Test Default Function',
|
|
source: {
|
|
sourceHandlerCode: DEFAULT_TEMPLATE_FUNCTION_CODE,
|
|
handlerName: 'main',
|
|
},
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const functionId = createData?.createOneLogicFunction?.id;
|
|
|
|
expect(functionId).toBeDefined();
|
|
createdFunctionIds.push(functionId);
|
|
|
|
// Execute with the default template's expected params: { a: string, b: number }
|
|
const { data: executeData } = await executeLogicFunction({
|
|
input: {
|
|
id: functionId,
|
|
payload: { a: 'hello', b: 42 },
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const result = executeData?.executeOneLogicFunction;
|
|
|
|
if (result?.status !== LogicFunctionExecutionStatus.SUCCESS) {
|
|
throw new Error(JSON.stringify(result?.error, null, 2));
|
|
}
|
|
|
|
expect(result?.status).toBe(LogicFunctionExecutionStatus.SUCCESS);
|
|
expect(result?.data).toMatchObject({
|
|
message: 'Toto: hello and 42',
|
|
});
|
|
expect(result?.duration).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('should handle errors thrown by logic functions', async () => {
|
|
// Create the function with error-throwing code
|
|
const { data: createData } = await createOneLogicFunction({
|
|
input: {
|
|
name: 'Error Test Function',
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
const functionId = createData?.createOneLogicFunction?.id;
|
|
|
|
expect(functionId).toBeDefined();
|
|
createdFunctionIds.push(functionId);
|
|
|
|
await updateLogicFunctionSource({
|
|
input: {
|
|
id: createData.createOneLogicFunction.id,
|
|
update: {
|
|
sourceHandlerCode: ERROR_FUNCTION_CODE,
|
|
},
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
// Execute with shouldFail = false (should succeed)
|
|
const { data: successData } = await executeLogicFunction({
|
|
input: {
|
|
id: functionId,
|
|
payload: { shouldFail: false },
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
expect(successData?.executeOneLogicFunction?.status).toBe(
|
|
LogicFunctionExecutionStatus.SUCCESS,
|
|
);
|
|
expect(successData?.executeOneLogicFunction?.data).toMatchObject({
|
|
success: true,
|
|
});
|
|
|
|
// Execute with shouldFail = true (should return error status)
|
|
const { data: errorData } = await executeLogicFunction({
|
|
input: {
|
|
id: functionId,
|
|
payload: { shouldFail: true },
|
|
},
|
|
expectToFail: false, // The GraphQL call succeeds, but the function execution fails
|
|
});
|
|
|
|
const errorResult = errorData?.executeOneLogicFunction;
|
|
|
|
expect(errorResult?.status).toBe(LogicFunctionExecutionStatus.ERROR);
|
|
expect(errorResult?.error).toMatchObject({
|
|
errorType: 'UnhandledError',
|
|
errorMessage: expect.stringContaining('Intentional test error'),
|
|
});
|
|
expect(errorResult?.data).toBeNull();
|
|
});
|
|
});
|