Common api - findMany query (#15004)

Done in this PR : 
- simplify rest input parsing by removing metadata validation (for
filter and orderBy - to add in common) (1st commit)
- simplify result getter handlers signature (array of objectRecord only
for input)


closes https://github.com/twentyhq/core-team-issues/issues/1614
closes https://github.com/twentyhq/core-team-issues/issues/1615
closes https://github.com/twentyhq/core-team-issues/issues/1616

packages/twenty-server/src/engine/api/graphql/graphql-query-runner/helpers/object-records-to-graphql-connection.helper.ts

@@ -25,6 +25,7 @@ import { getObjectMetadataMapItemByNameSingular } from 'src/engine/metadata-modu
 import { type CompositeFieldMetadataType } from 'src/engine/metadata-modules/workspace-migration/factories/composite-column-action.factory';
 import { isPlainObject } from 'src/utils/is-plain-object';
 
+// TODO: Refacto-common - Rename CommonRecordsToGraphqlConnectionHelper
 export class ObjectRecordsToGraphqlConnectionHelper {
   private objectMetadataMaps: ObjectMetadataMaps;
 

packages/twenty-server/src/engine/api/graphql/graphql-query-runner/resolvers/graphql-query-find-many-resolver.service.ts

@@ -175,7 +175,9 @@ export class GraphqlQueryFindManyResolverService extends GraphqlQueryBaseResolve
       new ObjectRecordsToGraphqlConnectionHelper(objectMetadataMaps);
 
     return typeORMObjectRecordsParser.createConnection({
-      objectRecords,
+      objectRecords: isForwardPagination
+        ? objectRecords
+        : objectRecords.reverse(),
       objectRecordsAggregatedValues: parentObjectRecordsAggregatedValues,
       selectedAggregatedFields:
         executionArgs.graphqlQuerySelectedFieldsResult.aggregate,

packages/twenty-server/src/engine/api/graphql/graphql-query-runner/utils/cursors.util.ts

@@ -64,8 +64,7 @@ export const getCursor = (
 };
 
 export const getPaginationInfo = (
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  objectRecords: any[],
+  objectRecords: ObjectRecord[],
   limit: number,
   isForwardPagination: boolean,
 ) => {

packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/factories/find-many-resolver.factory.ts

@@ -1,15 +1,23 @@
 import { Injectable } from '@nestjs/common';
 
-import { type WorkspaceQueryRunnerOptions } from 'src/engine/api/graphql/workspace-query-runner/interfaces/query-runner-option.interface';
+import graphqlFields from 'graphql-fields';
+import { QUERY_MAX_RECORDS } from 'twenty-shared/constants';
+
 import { type WorkspaceResolverBuilderFactoryInterface } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolver-builder-factory.interface';
 import {
   type FindManyResolverArgs,
   type Resolver,
 } from 'src/engine/api/graphql/workspace-resolver-builder/interfaces/workspace-resolvers-builder.interface';
-import { type WorkspaceSchemaBuilderContext } from 'src/engine/api/graphql/workspace-schema-builder/interfaces/workspace-schema-builder-context.interface';
+import { WorkspaceSchemaBuilderContext } from 'src/engine/api/graphql/workspace-schema-builder/interfaces/workspace-schema-builder-context.interface';
 
+import { CommonFindManyQueryRunnerService } from 'src/engine/api/common/common-query-runners/common-find-many-query-runner.service';
+import { GraphqlQueryParser } from 'src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser';
+import { ObjectRecordsToGraphqlConnectionHelper } from 'src/engine/api/graphql/graphql-query-runner/helpers/object-records-to-graphql-connection.helper';
 import { GraphqlQueryFindManyResolverService } from 'src/engine/api/graphql/graphql-query-runner/resolvers/graphql-query-find-many-resolver.service';
+import { workspaceQueryRunnerGraphqlApiExceptionHandler } from 'src/engine/api/graphql/workspace-query-runner/utils/workspace-query-runner-graphql-api-exception-handler.util';
 import { RESOLVER_METHOD_NAMES } from 'src/engine/api/graphql/workspace-resolver-builder/constants/resolver-method-names';
+import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
+import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
 
 @Injectable()
 export class FindManyResolverFactory
@@ -18,7 +26,9 @@ export class FindManyResolverFactory
   public static methodName = RESOLVER_METHOD_NAMES.FIND_MANY;
 
   constructor(
+    private readonly commonFindManyQueryRunnerService: CommonFindManyQueryRunnerService,
     private readonly graphqlQueryRunnerService: GraphqlQueryFindManyResolverService,
+    private readonly featureFlagService: FeatureFlagService,
   ) {}
 
   create(
@@ -27,17 +37,64 @@ export class FindManyResolverFactory
     const internalContext = context;
 
     return async (_source, args, _context, info) => {
-      const options: WorkspaceQueryRunnerOptions = {
-        authContext: internalContext.authContext,
-        info,
-        objectMetadataMaps: internalContext.objectMetadataMaps,
-        objectMetadataItemWithFieldMaps:
+      const isCommonApiEnabled = await this.featureFlagService.isFeatureEnabled(
+        FeatureFlagKey.IS_COMMON_API_ENABLED,
+        internalContext.authContext.workspace?.id as string,
+      );
+
+      if (isCommonApiEnabled) {
+        const graphqlQueryParser = new GraphqlQueryParser(
           internalContext.objectMetadataItemWithFieldMaps,
-      };
+          internalContext.objectMetadataMaps,
+        );
+
+        const selectedFieldsResult = graphqlQueryParser.parseSelectedFields(
+          internalContext.objectMetadataItemWithFieldMaps,
+          graphqlFields(info),
+          internalContext.objectMetadataMaps,
+        );
+
+        try {
+          const { records, aggregatedValues, totalCount, pageInfo } =
+            await this.commonFindManyQueryRunnerService.run({
+              args: { ...args, selectedFieldsResult },
+              authContext: internalContext.authContext,
+              objectMetadataMaps: internalContext.objectMetadataMaps,
+              objectMetadataItemWithFieldMaps:
+                internalContext.objectMetadataItemWithFieldMaps,
+            });
+
+          const typeORMObjectRecordsParser =
+            new ObjectRecordsToGraphqlConnectionHelper(
+              internalContext.objectMetadataMaps,
+            );
+
+          return typeORMObjectRecordsParser.createConnection({
+            objectRecords: records,
+            objectRecordsAggregatedValues: aggregatedValues,
+            selectedAggregatedFields: selectedFieldsResult.aggregate,
+            objectName:
+              internalContext.objectMetadataItemWithFieldMaps.nameSingular,
+            take: args.first ?? args.last ?? QUERY_MAX_RECORDS,
+            totalCount,
+            order: args.orderBy,
+            hasNextPage: pageInfo.hasNextPage,
+            hasPreviousPage: pageInfo.hasPreviousPage,
+          });
+        } catch (error) {
+          return workspaceQueryRunnerGraphqlApiExceptionHandler(error);
+        }
+      }
 
       return await this.graphqlQueryRunnerService.execute(
         args,
-        options,
+        {
+          authContext: internalContext.authContext,
+          info,
+          objectMetadataMaps: internalContext.objectMetadataMaps,
+          objectMetadataItemWithFieldMaps:
+            internalContext.objectMetadataItemWithFieldMaps,
+        },
         FindManyResolverFactory.methodName,
       );
     };

packages/twenty-server/src/engine/api/graphql/workspace-resolver-builder/factories/find-one-resolver.factory.ts

@@ -11,6 +11,7 @@ import { WorkspaceSchemaBuilderContext } from 'src/engine/api/graphql/workspace-
 
 import { CommonFindOneQueryRunnerService } from 'src/engine/api/common/common-query-runners/common-find-one-query-runner.service';
 import { GraphqlQueryParser } from 'src/engine/api/graphql/graphql-query-runner/graphql-query-parsers/graphql-query.parser';
+import { ObjectRecordsToGraphqlConnectionHelper } from 'src/engine/api/graphql/graphql-query-runner/helpers/object-records-to-graphql-connection.helper';
 import { GraphqlQueryFindOneResolverService } from 'src/engine/api/graphql/graphql-query-runner/resolvers/graphql-query-find-one-resolver.service';
 import { workspaceQueryRunnerGraphqlApiExceptionHandler } from 'src/engine/api/graphql/workspace-query-runner/utils/workspace-query-runner-graphql-api-exception-handler.util';
 import { RESOLVER_METHOD_NAMES } from 'src/engine/api/graphql/workspace-resolver-builder/constants/resolver-method-names';
@@ -53,15 +54,28 @@ export class FindOneResolverFactory
             internalContext.objectMetadataMaps,
           );
 
-          return await this.commonFindOneQueryRunnerService.run({
+          const record = await this.commonFindOneQueryRunnerService.run({
             args: { ...args, selectedFieldsResult },
             authContext: internalContext.authContext,
             objectMetadataMaps: internalContext.objectMetadataMaps,
             objectMetadataItemWithFieldMaps:
               internalContext.objectMetadataItemWithFieldMaps,
           });
+
+          const typeORMObjectRecordsParser =
+            new ObjectRecordsToGraphqlConnectionHelper(
+              internalContext.objectMetadataMaps,
+            );
+
+          return typeORMObjectRecordsParser.processRecord({
+            objectRecord: record,
+            objectName:
+              internalContext.objectMetadataItemWithFieldMaps.nameSingular,
+            take: 1,
+            totalCount: 1,
+          });
         } catch (error) {
-          workspaceQueryRunnerGraphqlApiExceptionHandler(error);
+          return workspaceQueryRunnerGraphqlApiExceptionHandler(error);
         }
       }