add is not operand on numeric fields (#16299)

closes https://github.com/twentyhq/twenty/issues/16162
This commit is contained in:
nitin
2025-12-04 18:55:24 +05:30
committed by GitHub
parent 2f36c2e82e
commit f0f648181e
8 changed files with 47 additions and 0 deletions
@@ -484,6 +484,31 @@ describe('evaluateFilterConditions', () => {
expect(evaluateFilterConditions({ filters: [filter2] })).toBe(false);
expect(evaluateFilterConditions({ filters: [filter3] })).toBe(false);
});
it('should handle IsNot operand correctly', () => {
const filter1 = createFilter(
ViewFilterOperand.IS_NOT,
25,
25,
'NUMBER',
);
const filter2 = createFilter(
ViewFilterOperand.IS_NOT,
20,
25,
'NUMBER',
);
const filter3 = createFilter(
ViewFilterOperand.IS_NOT,
30,
25,
'NUMBER',
);
expect(evaluateFilterConditions({ filters: [filter1] })).toBe(false);
expect(evaluateFilterConditions({ filters: [filter2] })).toBe(true);
expect(evaluateFilterConditions({ filters: [filter3] })).toBe(true);
});
});
describe('string and array operands', () => {
@@ -349,6 +349,9 @@ function evaluateNumberFilter(filter: ResolvedFilter): boolean {
case ViewFilterOperand.IS:
return Number(leftValue) === Number(rightValue);
case ViewFilterOperand.IS_NOT:
return Number(leftValue) !== Number(rightValue);
default:
throw new Error(
`Operand ${filter.operand} not supported for number filter`,