From eba3b0ca884fe06a93e37fd01ab5db8500d07101 Mon Sep 17 00:00:00 2001 From: Charles Bochet Date: Thu, 30 Oct 2025 13:36:30 +0100 Subject: [PATCH] Simplify Code on FetchMore (#15465) Simplifying a bit more fetchMore / lazyQuery api --- .../hooks/useLazyFindManyRecords.ts | 32 ------------------- 1 file changed, 32 deletions(-) diff --git a/packages/twenty-front/src/modules/object-record/hooks/useLazyFindManyRecords.ts b/packages/twenty-front/src/modules/object-record/hooks/useLazyFindManyRecords.ts index bbd005ca7a8..d11fafad71e 100644 --- a/packages/twenty-front/src/modules/object-record/hooks/useLazyFindManyRecords.ts +++ b/packages/twenty-front/src/modules/object-record/hooks/useLazyFindManyRecords.ts @@ -58,33 +58,6 @@ export const useLazyFindManyRecords = ({ const hasReadPermission = objectPermissions.canReadObjectRecords; - const handleFindManyRecordsCompleted = useRecoilCallback( - ({ set, snapshot }) => - (data: RecordGqlOperationFindManyResult) => { - const pageInfo = data?.[objectMetadataItem.namePlural]?.pageInfo; - - const existingCursor = snapshot - .getLoadable(cursorFamilyState(queryIdentifier)) - .getValue(); - const existingHasNextPage = snapshot - .getLoadable(hasNextPageFamilyState(queryIdentifier)) - .getValue(); - - if (isDefined(data?.[objectMetadataItem.namePlural])) { - if (existingCursor !== pageInfo.endCursor) { - set(cursorFamilyState(queryIdentifier), pageInfo.endCursor ?? ''); - } - if (existingHasNextPage !== pageInfo.hasNextPage) { - set( - hasNextPageFamilyState(queryIdentifier), - pageInfo.hasNextPage ?? false, - ); - } - } - }, - [objectMetadataItem.namePlural, queryIdentifier], - ); - const [findManyRecords, { data, error, fetchMore }] = useLazyQuery(findManyRecordsQuery, { variables: { @@ -128,10 +101,6 @@ export const useLazyFindManyRecords = ({ handleFindManyRecordsError(result.error); } - if (isDefined(result?.data)) { - handleFindManyRecordsCompleted(result.data); - } - const hasNextPage = result?.data?.[objectMetadataItem.namePlural]?.pageInfo.hasNextPage ?? false; @@ -173,7 +142,6 @@ export const useLazyFindManyRecords = ({ objectMetadataItem.namePlural, queryIdentifier, handleFindManyRecordsError, - handleFindManyRecordsCompleted, ], );