Add applicationId to syncableEntity and fix syncApp deletion (#15170)

## Context
- All flatEntity should extend SyncableEntity
- SyncableEntity should now have applicationId and application relation
- Fix syncApp deletion, should now properly use migration v2 to delete
syncable entities

packages/twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.entity.ts

@@ -18,9 +18,8 @@ import { SyncableEntity } from 'src/engine/workspace-manager/workspace-sync/inte
 import { CronTrigger } from 'src/engine/metadata-modules/cron-trigger/entities/cron-trigger.entity';
 import { DatabaseEventTrigger } from 'src/engine/metadata-modules/database-event-trigger/entities/database-event-trigger.entity';
 import { RouteTrigger } from 'src/engine/metadata-modules/route-trigger/route-trigger.entity';
-import { ServerlessFunctionEntityRelationProperties } from 'src/engine/metadata-modules/serverless-function/types/flat-serverless-function.type';
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
 import { ServerlessFunctionLayerEntity } from 'src/engine/metadata-modules/serverless-function-layer/serverless-function-layer.entity';
+import { ServerlessFunctionEntityRelationProperties } from 'src/engine/metadata-modules/serverless-function/types/flat-serverless-function.type';
 
 const DEFAULT_SERVERLESS_TIMEOUT_SECONDS = 300; // 5 minutes
 
@@ -66,9 +65,6 @@ export class ServerlessFunctionEntity
   @Column({ nullable: false, type: 'uuid' })
   workspaceId: string;
 
-  @Column({ nullable: true, type: 'uuid' })
-  applicationId: string | null;
-
   @Column({ nullable: true, type: 'text' })
   checksum: string | null;
 
@@ -84,17 +80,6 @@ export class ServerlessFunctionEntity
   @JoinColumn({ name: 'serverlessFunctionLayerId' })
   serverlessFunctionLayer: Relation<ServerlessFunctionLayerEntity>;
 
-  @ManyToOne(
-    () => ApplicationEntity,
-    (application) => application.serverlessFunctions,
-    {
-      onDelete: 'CASCADE',
-      nullable: true,
-    },
-  )
-  @JoinColumn({ name: 'applicationId' })
-  application: Relation<ApplicationEntity> | null;
-
   @OneToMany(
     () => CronTrigger,
     (cronTrigger) => cronTrigger.serverlessFunction,

packages/twenty-server/src/engine/metadata-modules/serverless-function/services/workspace-flat-serverless-function-map-cache.service.ts

@@ -9,6 +9,7 @@ import { CacheStorageService } from 'src/engine/core-modules/cache-storage/servi
 import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
 import { EMPTY_FLAT_ENTITY_MAPS } from 'src/engine/metadata-modules/flat-entity/constant/empty-flat-entity-maps.constant';
 import { FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
+import { addFlatEntityToFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/add-flat-entity-to-flat-entity-maps-or-throw.util';
 import {
   SERVERLESS_FUNCTION_ENTITY_RELATION_PROPERTIES,
   ServerlessFunctionEntity,
@@ -43,29 +44,23 @@ export class WorkspaceFlatServerlessFunctionMapCacheService extends WorkspaceFla
       withDeleted: true,
     });
 
-    const flatServerlessFunctionMaps = serverlessFunctions.reduce<
-      FlatEntityMaps<FlatServerlessFunction>
-    >((flatEntityMaps, serverlessFunction) => {
-      const flatServerlessFunction = {
-        ...removePropertiesFromRecord(serverlessFunction, [
-          ...SERVERLESS_FUNCTION_ENTITY_RELATION_PROPERTIES,
-        ]),
-        universalIdentifier: serverlessFunction.universalIdentifier ?? '',
-      } satisfies FlatServerlessFunction;
+    return serverlessFunctions.reduce(
+      (flatServerlessFunctionMaps, serverlessFunctionEntity) => {
+        const flatServerlessFunction = {
+          ...removePropertiesFromRecord(serverlessFunctionEntity, [
+            ...SERVERLESS_FUNCTION_ENTITY_RELATION_PROPERTIES,
+          ]),
+          universalIdentifier:
+            serverlessFunctionEntity.universalIdentifier ??
+            serverlessFunctionEntity.id,
+        } satisfies FlatServerlessFunction;
 
-      return {
-        byId: {
-          ...flatEntityMaps.byId,
-          [flatServerlessFunction.id]: flatServerlessFunction,
-        },
-        idByUniversalIdentifier: {
-          ...flatEntityMaps.idByUniversalIdentifier,
-          [flatServerlessFunction.universalIdentifier]:
-            flatServerlessFunction.id,
-        },
-      };
-    }, EMPTY_FLAT_ENTITY_MAPS);
-
-    return flatServerlessFunctionMaps;
+        return addFlatEntityToFlatEntityMapsOrThrow({
+          flatEntity: flatServerlessFunction,
+          flatEntityMaps: flatServerlessFunctionMaps,
+        });
+      },
+      EMPTY_FLAT_ENTITY_MAPS,
+    );
   }
 }

packages/twenty-server/src/engine/metadata-modules/serverless-function/types/flat-serverless-function.type.ts

@@ -1,12 +1,12 @@
 import { type Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
 import { type CronTrigger } from 'src/engine/metadata-modules/cron-trigger/entities/cron-trigger.entity';
 import { type DatabaseEventTrigger } from 'src/engine/metadata-modules/database-event-trigger/entities/database-event-trigger.entity';
+import { type FlatEntityFrom } from 'src/engine/metadata-modules/flat-entity/types/flat-entity.type';
 import { type RouteTrigger } from 'src/engine/metadata-modules/route-trigger/route-trigger.entity';
-import { type ServerlessFunctionEntity } from 'src/engine/metadata-modules/serverless-function/serverless-function.entity';
-import { type ExtractRecordTypeOrmRelationProperties } from 'src/engine/workspace-manager/workspace-migration-v2/types/extract-record-typeorm-relation-properties.type';
-import { type ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
 import { type ServerlessFunctionLayerEntity } from 'src/engine/metadata-modules/serverless-function-layer/serverless-function-layer.entity';
+import { type ServerlessFunctionEntity } from 'src/engine/metadata-modules/serverless-function/serverless-function.entity';
 import { type ServerlessFunctionCode } from 'src/engine/metadata-modules/serverless-function/types/serverless-function-code.type';
+import { type ExtractRecordTypeOrmRelationProperties } from 'src/engine/workspace-manager/workspace-migration-v2/types/extract-record-typeorm-relation-properties.type';
 
 export type ServerlessFunctionEntityRelationProperties =
   ExtractRecordTypeOrmRelationProperties<
@@ -15,14 +15,12 @@ export type ServerlessFunctionEntityRelationProperties =
     | DatabaseEventTrigger
     | RouteTrigger
     | Workspace
-    | ApplicationEntity
     | ServerlessFunctionLayerEntity
   >;
 
-export type FlatServerlessFunction = Omit<
+export type FlatServerlessFunction = FlatEntityFrom<
   ServerlessFunctionEntity,
   ServerlessFunctionEntityRelationProperties
 > & {
-  universalIdentifier: string;
   code?: ServerlessFunctionCode;
 };