Refactor validate build and run for configuration to be less verbose and more reliable (#16343)

# Introduction Refactored the api `validateBuildAndRunWorkspaceMigration` to be require less configuration but to infer required args dynamically depending on provided metadata maps to compare ## `inferDeletionFromMissingEntities` Is not dynamically computed avoiding any miss configuration issue and any missleading devxp ## Maps computation Making only one call to redis to build both dependency and to be compared entity maps. It does not matter to avoid passing a about to compared flat entity maps to could also be a depedency, it's handled directly in the builder setup optimistic cache logic Please note that the flat maps used for the service input transpilation might differ from the one that we will dynamically compute and inject in the builder. Leading to do 2 redis calls but also race condition prone validation error We prefer that this occurs at the builder rather than at the runner level as the pg instance is not cache and reflect the real state of a given workspace In a nutshell, there's a possible race condition between cache invalidation and computation in both service input transpilers and builder but we're totally ok with that
2025-12-05 15:41:56 +00:00
parent fee3e6b7a1
commit c8f541618d
22 changed files with 554 additions and 976 deletions
@@ -4,7 +4,6 @@ import { isDefined } from 'twenty-shared/utils';

 import { ApplicationService } from 'src/engine/core-modules/application/application.service';
 import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { computeFlatEntityMapsFromTo } from 'src/engine/metadata-modules/flat-entity/utils/compute-flat-entity-maps-from-to.util';
 import { findFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps-or-throw.util';
 import type { CreateServerlessFunctionInput } from 'src/engine/metadata-modules/serverless-function/dtos/create-serverless-function.input';
 import { ServerlessFunctionIdInput } from 'src/engine/metadata-modules/serverless-function/dtos/serverless-function-id.input';
@@ -49,17 +48,6 @@ export class ServerlessFunctionV2Service {
        },
      );

-    const flatEntityMaps =
-      await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
-        {
-          workspaceId,
-          flatMapsKeys: ['flatServerlessFunctionMaps'],
-        },
-      );
-
-    const existingFlatServerlessFunctionMaps =
-      flatEntityMaps.flatServerlessFunctionMaps;
-
    const flatServerlessFunctionToCreate =
      fromCreateServerlessFunctionInputToFlatServerlessFunction({
        createServerlessFunctionInput,
@@ -71,18 +59,15 @@ export class ServerlessFunctionV2Service {
    const validateAndBuildResult =
      await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
        {
-          workspaceId,
-          fromToAllFlatEntityMaps: {
-            flatServerlessFunctionMaps: computeFlatEntityMapsFromTo({
-              flatEntityMaps: existingFlatServerlessFunctionMaps,
+          allFlatEntityOperationByMetadataName: {
+            serverlessFunction: {
              flatEntityToCreate: [flatServerlessFunctionToCreate],
              flatEntityToDelete: [],
              flatEntityToUpdate: [],
-            }),
-          },
-          buildOptions: {
-            isSystemBuild: false,
+            },
          },
+          workspaceId,
+          isSystemBuild: false,
        },
      );

@@ -113,7 +98,7 @@ export class ServerlessFunctionV2Service {
    serverlessFunctionInput: UpdateServerlessFunctionInput,
    workspaceId: string,
  ) {
-    const flatEntityMaps =
+    const { flatServerlessFunctionMaps } =
      await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
        {
          workspaceId,
@@ -121,30 +106,24 @@ export class ServerlessFunctionV2Service {
        },
      );

-    const existingFlatServerlessFunctionMaps =
-      flatEntityMaps.flatServerlessFunctionMaps;
-
    const optimisticallyUpdatedFlatServerlessFunction =
      fromUpdateServerlessFunctionInputToFlatServerlessFunctionToUpdateOrThrow({
-        flatServerlessFunctionMaps: existingFlatServerlessFunctionMaps,
+        flatServerlessFunctionMaps,
        updateServerlessFunctionInput: serverlessFunctionInput,
      });

    const validateAndBuildResult =
      await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
        {
-          workspaceId,
-          fromToAllFlatEntityMaps: {
-            flatServerlessFunctionMaps: computeFlatEntityMapsFromTo({
-              flatEntityMaps: existingFlatServerlessFunctionMaps,
+          allFlatEntityOperationByMetadataName: {
+            serverlessFunction: {
              flatEntityToCreate: [],
              flatEntityToDelete: [],
              flatEntityToUpdate: [optimisticallyUpdatedFlatServerlessFunction],
-            }),
-          },
-          buildOptions: {
-            isSystemBuild: false,
+            },
          },
+          workspaceId,
+          isSystemBuild: false,
        },
      );

@@ -206,20 +185,17 @@ export class ServerlessFunctionV2Service {
    const validateAndBuildResult =
      await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
        {
-          fromToAllFlatEntityMaps: {
-            flatServerlessFunctionMaps: computeFlatEntityMapsFromTo({
-              flatEntityMaps: existingFlatServerlessFunctionMaps,
+          allFlatEntityOperationByMetadataName: {
+            serverlessFunction: {
              flatEntityToCreate: [],
              flatEntityToDelete: [],
              flatEntityToUpdate: [
                optimisticallyUpdatedFlatServerlessFunctionWithDeletedAt,
              ],
-            }),
-          },
-          buildOptions: {
-            isSystemBuild,
+            },
          },
          workspaceId,
+          isSystemBuild,
        },
      );

@@ -278,21 +254,15 @@ export class ServerlessFunctionV2Service {
    const validateAndBuildResult =
      await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
        {
-          fromToAllFlatEntityMaps: {
-            flatServerlessFunctionMaps: computeFlatEntityMapsFromTo({
-              flatEntityMaps: existingFlatServerlessFunctionMaps,
+          allFlatEntityOperationByMetadataName: {
+            serverlessFunction: {
              flatEntityToCreate: [],
              flatEntityToDelete: [existingFlatServerlessFunction],
              flatEntityToUpdate: [],
-            }),
-          },
-          buildOptions: {
-            isSystemBuild,
-            inferDeletionFromMissingEntities: {
-              serverlessFunction: true,
            },
          },
          workspaceId,
+          isSystemBuild,
        },
      );