From 83e1efc4964ec44ffe16259d91aa68c65f5e20d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix=20Malfait?= Date: Wed, 4 Mar 2026 09:38:15 +0100 Subject: [PATCH] fix: typecheck and prettier errors in upload controller and upgrade service Made-with: Cursor --- .../app-registration-upload.controller.ts | 6 ++++-- .../application/services/app-upgrade.service.ts | 15 +++++---------- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/packages/twenty-server/src/engine/core-modules/application-registration/controllers/app-registration-upload.controller.ts b/packages/twenty-server/src/engine/core-modules/application-registration/controllers/app-registration-upload.controller.ts index 6a5195d8469..99e511d3ae8 100644 --- a/packages/twenty-server/src/engine/core-modules/application-registration/controllers/app-registration-upload.controller.ts +++ b/packages/twenty-server/src/engine/core-modules/application-registration/controllers/app-registration-upload.controller.ts @@ -99,10 +99,12 @@ export class AppRegistrationUploadController { const manifestPath = await this.extractAndValidate(tarballPath, tempDir); const manifestContent = await fs.readFile(manifestPath, 'utf-8'); - let manifest: Record; + let manifest: { + application?: { universalIdentifier?: string; displayName?: string }; + }; try { - manifest = JSON.parse(manifestContent) as Record; + manifest = JSON.parse(manifestContent); } catch { throw new ApplicationException( 'manifest.json contains invalid JSON', diff --git a/packages/twenty-server/src/engine/core-modules/application/services/app-upgrade.service.ts b/packages/twenty-server/src/engine/core-modules/application/services/app-upgrade.service.ts index 21474c49dd7..7fc25cf26ba 100644 --- a/packages/twenty-server/src/engine/core-modules/application/services/app-upgrade.service.ts +++ b/packages/twenty-server/src/engine/core-modules/application/services/app-upgrade.service.ts @@ -40,17 +40,12 @@ export class AppUpgradeService { this.twentyConfigService.get('APP_REGISTRY_URL'); try { - const encodedPackage = encodeURIComponent( - appRegistration.sourcePackage!, - ); + const encodedPackage = encodeURIComponent(appRegistration.sourcePackage!); - const response = await fetch( - `${registryUrl}/${encodedPackage}/latest`, - { - headers: { 'User-Agent': 'Twenty-AppUpgrade' }, - signal: AbortSignal.timeout(10_000), - }, - ); + const response = await fetch(`${registryUrl}/${encodedPackage}/latest`, { + headers: { 'User-Agent': 'Twenty-AppUpgrade' }, + signal: AbortSignal.timeout(10_000), + }); if (!response.ok) { this.logger.warn(