Small improvements with views (#16821)

- when a view is deleted, it is removed from left menu + from list views
in dropdown
- deactivated fields are not suggested as options to group records by
for a view (only in FE, not forbidden by BE)
This commit is contained in:
Marie
2025-12-27 07:11:04 +01:00
committed by GitHub
parent 265345fd69
commit 7400a3051c
2 changed files with 10 additions and 1 deletions
@@ -6,6 +6,7 @@ import { getSnapshotValue } from '@/ui/utilities/state/utils/getSnapshotValue';
import { usePersistView } from '@/views/hooks/internal/usePersistView';
import { useChangeView } from '@/views/hooks/useChangeView';
import { useGetCurrentViewOnly } from '@/views/hooks/useGetCurrentViewOnly';
import { coreViewsByObjectMetadataIdFamilySelector } from '@/views/states/selectors/coreViewsByObjectMetadataIdFamilySelector';
import { coreViewsFromObjectMetadataItemFamilySelector } from '@/views/states/selectors/coreViewsFromObjectMetadataItemFamilySelector';
import { useCloseAndResetViewPicker } from '@/views/view-picker/hooks/useCloseAndResetViewPicker';
import { viewPickerIsDirtyComponentState } from '@/views/view-picker/states/viewPickerIsDirtyComponentState';
@@ -67,11 +68,18 @@ export const useDeleteViewFromCurrentState = (viewBarInstanceId?: string) => {
);
}
set(
coreViewsByObjectMetadataIdFamilySelector(objectMetadataItem.id),
(views) =>
views.filter((view) => view.id !== viewPickerReferenceViewId),
);
await deleteView({ id: viewPickerReferenceViewId });
},
[
currentView,
closeAndResetViewPicker,
objectMetadataItem.id,
changeView,
deleteView,
viewPickerIsDirtyCallbackState,
@@ -27,7 +27,8 @@ export const useGetAvailableFieldsForKanban = () => {
const availableFieldsForKanban =
objectMetadataItem?.readableFields.filter(
(field) => field.type === FieldMetadataType.SELECT,
(field) =>
field.type === FieldMetadataType.SELECT && field.isActive === true,
) ?? [];
const navigate = useNavigateSettings();