Refactorings, error handling and logout

This commit is contained in:
Dries Augustyns
2025-12-03 20:39:11 +01:00
parent 113b94cf2c
commit 382e97e5b2
12 changed files with 306 additions and 189 deletions
+5
View File
@@ -116,6 +116,11 @@ export class CampaignService {
} }
if (data.segmentId !== undefined) { if (data.segmentId !== undefined) {
// Prevent changing segment on scheduled campaigns
if (campaign.status === CampaignStatus.SCHEDULED) {
throw new HttpException(400, 'Cannot change segment for scheduled campaigns');
}
if (data.segmentId) { if (data.segmentId) {
const segment = await prisma.segment.findFirst({ const segment = await prisma.segment.findFirst({
where: {id: data.segmentId, projectId}, where: {id: data.segmentId, projectId},
+23 -2
View File
@@ -109,7 +109,28 @@ export class DomainService {
); );
} }
// Check if domain is used in any campaigns // Check if domain is used in any workflow steps (via templates)
const workflowStepsUsingDomain = await prisma.workflowStep.count({
where: {
workflow: {
projectId: domain.projectId,
},
template: {
from: {
contains: `@${domainName}`,
},
},
},
});
if (workflowStepsUsingDomain > 0) {
throw new HttpException(
409,
`Cannot delete domain: it is currently used in ${workflowStepsUsingDomain} workflow step(s). Update the workflow templates first.`,
);
}
// Check if domain is used in any active campaigns
const campaignsUsingDomain = await prisma.campaign.count({ const campaignsUsingDomain = await prisma.campaign.count({
where: { where: {
projectId: domain.projectId, projectId: domain.projectId,
@@ -117,7 +138,7 @@ export class DomainService {
contains: `@${domainName}`, contains: `@${domainName}`,
}, },
status: { status: {
not: 'SENT', // Allow deletion if all campaigns using it are completed in: ['DRAFT', 'SCHEDULED', 'SENDING'],
}, },
}, },
}); });
+2 -2
View File
@@ -180,12 +180,12 @@ export class SegmentService {
// First verify segment exists and belongs to project // First verify segment exists and belongs to project
await this.get(projectId, segmentId); await this.get(projectId, segmentId);
// Check if segment is used in any campaigns // Check if segment is used in any active campaigns
const campaignsUsingSegment = await prisma.campaign.count({ const campaignsUsingSegment = await prisma.campaign.count({
where: { where: {
segmentId, segmentId,
status: { status: {
not: 'SENT', // Allow deletion if all campaigns using it are completed in: ['DRAFT', 'SCHEDULED', 'SENDING'],
}, },
}, },
}); });
+10
View File
@@ -242,6 +242,16 @@ export class WorkflowService {
// Verify workflow exists and belongs to project // Verify workflow exists and belongs to project
const workflow = await this.get(projectId, workflowId); const workflow = await this.get(projectId, workflowId);
// Check if workflow has active executions
const activeExecutions = await this.hasActiveExecutions(workflowId);
if (activeExecutions > 0) {
throw new HttpException(
409,
`Cannot delete workflow: it has ${activeExecutions} active execution(s). Please wait for them to complete or cancel them first.`,
);
}
await prisma.workflow.delete({ await prisma.workflow.delete({
where: {id: workflowId}, where: {id: workflowId},
}); });
+16 -4
View File
@@ -11,6 +11,17 @@ interface TypedSchema extends ZodSchema {
_type: unknown; _type: unknown;
} }
interface ApiResponse {
message?: string;
error?: {
message?: string;
code?: string;
[key: string]: unknown;
};
[key: string]: unknown;
}
export class network { export class network {
/** /**
* Fetcher function that includes toast support * Fetcher function that includes toast support
@@ -31,13 +42,14 @@ export class network {
credentials: 'include', credentials: 'include',
}); });
const res = await response.json(); const res = (await response.json()) as ApiResponse;
if (response.status >= 400) { if (response.status >= 400) {
// Extract error message from standardized error response or fall back to direct message property
throw new Error(res?.message ?? 'Something went wrong!'); const errorMessage = res.error?.message ?? res.message ?? 'Something went wrong!';
throw new Error(errorMessage);
} }
return res; return res as T;
} }
} }
+32 -6
View File
@@ -1,5 +1,6 @@
import {useActiveProject} from '../lib/contexts/ActiveProjectProvider'; import {useActiveProject} from '../lib/contexts/ActiveProjectProvider';
import {useUser} from '../lib/hooks/useUser'; import {useUser} from '../lib/hooks/useUser';
import {network} from '../lib/network';
import { import {
Activity, Activity,
BarChart3, BarChart3,
@@ -60,7 +61,7 @@ const navigation: NavSection[] = [
export function DashboardLayout({children}: DashboardLayoutProps) { export function DashboardLayout({children}: DashboardLayoutProps) {
const router = useRouter(); const router = useRouter();
const {data: user} = useUser(); const {data: user, mutate: mutateUser} = useUser();
const {activeProject, availableProjects, setActiveProject} = useActiveProject(); const {activeProject, availableProjects, setActiveProject} = useActiveProject();
const [showProjectMenu, setShowProjectMenu] = useState(false); const [showProjectMenu, setShowProjectMenu] = useState(false);
const [showUserMenu, setShowUserMenu] = useState(false); const [showUserMenu, setShowUserMenu] = useState(false);
@@ -86,10 +87,31 @@ export function DashboardLayout({children}: DashboardLayoutProps) {
} }
}, [showProjectMenu, showUserMenu]); }, [showProjectMenu, showUserMenu]);
const handleLogout = () => { const handleLogout = async () => {
localStorage.removeItem('token'); try {
localStorage.removeItem('activeProjectId'); // Call the logout endpoint to clear the cookie
void router.push('/auth/login'); await network.fetch('GET', '/auth/logout');
// Clear local storage
localStorage.removeItem('token');
localStorage.removeItem('activeProjectId');
// Clear SWR cache for user data
await mutateUser(null, false);
// Close the menu
setShowUserMenu(false);
// Redirect to login
await router.push('/auth/login');
} catch (error) {
console.error('Logout failed:', error);
// Even if the API call fails, try to redirect to login
localStorage.removeItem('token');
localStorage.removeItem('activeProjectId');
await mutateUser(null, false);
await router.push('/auth/login');
}
}; };
return ( return (
@@ -209,7 +231,11 @@ export function DashboardLayout({children}: DashboardLayoutProps) {
{showUserMenu && ( {showUserMenu && (
<div className="absolute bottom-full left-0 right-0 mb-1 bg-white border border-neutral-200 rounded-lg shadow-lg z-50 py-1"> <div className="absolute bottom-full left-0 right-0 mb-1 bg-white border border-neutral-200 rounded-lg shadow-lg z-50 py-1">
<button <button
onClick={handleLogout} onClick={(e) => {
e.preventDefault();
e.stopPropagation();
void handleLogout();
}}
className="w-full flex items-center gap-2 px-3 py-2 text-sm hover:bg-neutral-50 transition-colors text-red-600" className="w-full flex items-center gap-2 px-3 py-2 text-sm hover:bg-neutral-50 transition-colors text-red-600"
> >
<LogOut className="h-4 w-4" /> <LogOut className="h-4 w-4" />
+5 -4
View File
@@ -40,15 +40,16 @@ export interface DashboardStats {
*/ */
export function useDashboardStats(): DashboardStats { export function useDashboardStats(): DashboardStats {
// Fetch activity stats (last 30 days by default) // Fetch activity stats (last 30 days by default)
const {data: activityStats, error: activityError} = useSWR<ActivityStats>('/activity/stats'); const {data: activityStats, error: activityError, isLoading: isLoadingActivity} = useSWR<ActivityStats>('/activity/stats');
// Fetch contacts (only need the total count) // Fetch contacts (only need the total count)
const {data: contactsData, error: contactsError} = useSWR<ContactsResponse>('/contacts?limit=1'); const {data: contactsData, error: contactsError, isLoading: isLoadingContacts} = useSWR<ContactsResponse>('/contacts?limit=1');
// Fetch campaigns (only need the total count) // Fetch campaigns (only need the total count)
const {data: campaignsData, error: campaignsError} = useSWR<CampaignsResponse>('/campaigns?pageSize=1'); const {data: campaignsData, error: campaignsError, isLoading: isLoadingCampaigns} = useSWR<CampaignsResponse>('/campaigns?pageSize=1');
const isLoading = !activityStats && !contactsData && !campaignsData; // Still loading if ANY of the requests are still in progress
const isLoading = isLoadingActivity || isLoadingContacts || isLoadingCampaigns;
const error = activityError || contactsError || campaignsError; const error = activityError || contactsError || campaignsError;
return { return {
+11 -2
View File
@@ -14,6 +14,11 @@ interface TypedSchema extends ZodSchema {
interface ApiResponse { interface ApiResponse {
message?: string; message?: string;
error?: {
message?: string;
code?: string;
[key: string]: unknown;
};
[key: string]: unknown; [key: string]: unknown;
} }
@@ -52,7 +57,9 @@ export class network {
const res = (await response.json()) as ApiResponse; const res = (await response.json()) as ApiResponse;
if (response.status >= 400) { if (response.status >= 400) {
throw new Error(res.message ?? 'Something went wrong!'); // Extract error message from standardized error response or fall back to direct message property
const errorMessage = res.error?.message ?? res.message ?? 'Something went wrong!';
throw new Error(errorMessage);
} }
return res as T; return res as T;
@@ -84,7 +91,9 @@ export class network {
const res = (await response.json()) as ApiResponse; const res = (await response.json()) as ApiResponse;
if (response.status >= 400) { if (response.status >= 400) {
throw new Error(res.message ?? 'Something went wrong!'); // Extract error message from standardized error response or fall back to direct message property
const errorMessage = res.error?.message ?? res.message ?? 'Something went wrong!';
throw new Error(errorMessage);
} }
return res as T; return res as T;
+53 -13
View File
@@ -14,6 +14,10 @@ import {
DialogFooter, DialogFooter,
DialogHeader, DialogHeader,
DialogTitle, DialogTitle,
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
Input, Input,
Label, Label,
Select, Select,
@@ -32,7 +36,7 @@ import {EmailEditor} from '../../components/EmailEditor';
import {network} from '../../lib/network'; import {network} from '../../lib/network';
import {formatFullDateTime, formatUTCDateTime, getUserTimezone, schedulePresets} from '../../lib/dateUtils'; import {formatFullDateTime, formatUTCDateTime, getUserTimezone, schedulePresets} from '../../lib/dateUtils';
import {useChangeTracking} from '../../lib/hooks/useChangeTracking'; import {useChangeTracking} from '../../lib/hooks/useChangeTracking';
import {ArrowLeft, Calendar, Mail, MousePointer, Save, Send, TestTube, TrendingUp, Users, XCircle} from 'lucide-react'; import {ArrowLeft, Calendar, ChevronDown, Mail, MousePointer, Save, Send, TestTube, Trash2, TrendingUp, Users, XCircle} from 'lucide-react';
import Link from 'next/link'; import Link from 'next/link';
import {useRouter} from 'next/router'; import {useRouter} from 'next/router';
import {useEffect, useState} from 'react'; import {useEffect, useState} from 'react';
@@ -91,6 +95,7 @@ export default function CampaignDetailsPage() {
const [sendingTestEmail, setSendingTestEmail] = useState(false); const [sendingTestEmail, setSendingTestEmail] = useState(false);
const [showCancelDialog, setShowCancelDialog] = useState(false); const [showCancelDialog, setShowCancelDialog] = useState(false);
const [showSendDialog, setShowSendDialog] = useState(false); const [showSendDialog, setShowSendDialog] = useState(false);
const [showDeleteDialog, setShowDeleteDialog] = useState(false);
// Automatically initialize edit fields when campaign is loaded and is a draft // Automatically initialize edit fields when campaign is loaded and is a draft
const isEditMode = campaign?.data.status === CampaignStatus.DRAFT; const isEditMode = campaign?.data.status === CampaignStatus.DRAFT;
@@ -105,6 +110,16 @@ export default function CampaignDetailsPage() {
} }
}; };
const handleDelete = async () => {
try {
await network.fetch('DELETE', `/campaigns/${id}`);
toast.success('Campaign deleted successfully');
void router.push('/campaigns');
} catch (error) {
toast.error(error instanceof Error ? error.message : 'Failed to delete campaign');
}
};
const handleSend = async () => { const handleSend = async () => {
try { try {
await network.fetch<void>('POST', `/campaigns/${id}/send`); await network.fetch<void>('POST', `/campaigns/${id}/send`);
@@ -322,22 +337,37 @@ export default function CampaignDetailsPage() {
{!hasChanges && !isSubmitting && <span className="text-sm text-neutral-500">All changes saved</span>} {!hasChanges && !isSubmitting && <span className="text-sm text-neutral-500">All changes saved</span>}
{hasChanges && !isSubmitting && <span className="text-sm text-amber-600">Unsaved changes</span>} {hasChanges && !isSubmitting && <span className="text-sm text-amber-600">Unsaved changes</span>}
<div className="flex gap-2"> <div className="flex gap-2">
<Button type="button" variant="destructive" onClick={() => setShowDeleteDialog(true)}>
<Trash2 className="h-4 w-4" />
Delete
</Button>
<Button type="submit" disabled={!hasChanges || isSubmitting} variant="outline"> <Button type="submit" disabled={!hasChanges || isSubmitting} variant="outline">
<Save className="h-4 w-4" /> <Save className="h-4 w-4" />
{isSubmitting ? 'Saving...' : 'Save'} {isSubmitting ? 'Saving...' : 'Save'}
</Button> </Button>
<Button type="button" variant="outline" onClick={() => setIsTestEmailDialogOpen(true)}> <DropdownMenu>
<TestTube className="h-4 w-4" /> <DropdownMenuTrigger asChild>
Send Test <Button type="button">
</Button> <Send className="h-4 w-4" />
<Button type="button" onClick={() => setShowSendDialog(true)}> Send
<Send className="h-4 w-4" /> <ChevronDown className="h-4 w-4 ml-1" />
Send Now </Button>
</Button> </DropdownMenuTrigger>
<Button type="button" variant="outline" onClick={() => setIsScheduleDialogOpen(true)}> <DropdownMenuContent align="end">
<Calendar className="h-4 w-4" /> <DropdownMenuItem onClick={() => setIsTestEmailDialogOpen(true)}>
Schedule <TestTube className="h-4 w-4 mr-2" />
</Button> Send Test Email
</DropdownMenuItem>
<DropdownMenuItem onClick={() => setShowSendDialog(true)}>
<Send className="h-4 w-4 mr-2" />
Send Now
</DropdownMenuItem>
<DropdownMenuItem onClick={() => setIsScheduleDialogOpen(true)}>
<Calendar className="h-4 w-4 mr-2" />
Schedule for Later
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
</div> </div>
</div> </div>
</div> </div>
@@ -680,6 +710,16 @@ export default function CampaignDetailsPage() {
confirmText="Send Now" confirmText="Send Now"
variant="default" variant="default"
/> />
<ConfirmDialog
open={showDeleteDialog}
onOpenChange={setShowDeleteDialog}
onConfirm={handleDelete}
title="Delete Campaign"
description="Are you sure you want to delete this draft campaign? This action cannot be undone."
confirmText="Delete Campaign"
variant="destructive"
/>
</DashboardLayout> </DashboardLayout>
); );
} }
+40 -1
View File
@@ -17,7 +17,7 @@ import type {Campaign} from '@plunk/db';
import {CampaignStatus} from '@plunk/db'; import {CampaignStatus} from '@plunk/db';
import {DashboardLayout} from '../../components/DashboardLayout'; import {DashboardLayout} from '../../components/DashboardLayout';
import {network} from '../../lib/network'; import {network} from '../../lib/network';
import {Calendar, Copy, Mail, Plus, Users} from 'lucide-react'; import {Calendar, Copy, Mail, Plus, Trash2, Users} from 'lucide-react';
import {NextSeo} from 'next-seo'; import {NextSeo} from 'next-seo';
import Link from 'next/link'; import Link from 'next/link';
import {useState} from 'react'; import {useState} from 'react';
@@ -37,6 +37,8 @@ export default function CampaignsPage() {
const [statusFilter, setStatusFilter] = useState<string>('ALL'); const [statusFilter, setStatusFilter] = useState<string>('ALL');
const [showCancelDialog, setShowCancelDialog] = useState(false); const [showCancelDialog, setShowCancelDialog] = useState(false);
const [campaignToCancel, setCampaignToCancel] = useState<string | null>(null); const [campaignToCancel, setCampaignToCancel] = useState<string | null>(null);
const [showDeleteDialog, setShowDeleteDialog] = useState(false);
const [campaignToDelete, setCampaignToDelete] = useState<string | null>(null);
const {data, mutate, isLoading} = useSWR<PaginatedCampaigns>( const {data, mutate, isLoading} = useSWR<PaginatedCampaigns>(
`/campaigns?page=${page}&pageSize=20${statusFilter !== 'ALL' ? `&status=${statusFilter}` : ''}`, `/campaigns?page=${page}&pageSize=20${statusFilter !== 'ALL' ? `&status=${statusFilter}` : ''}`,
@@ -87,6 +89,20 @@ export default function CampaignsPage() {
} }
}; };
const handleDelete = async () => {
if (!campaignToDelete) return;
try {
await network.fetch('DELETE', `/campaigns/${campaignToDelete}`);
toast.success('Campaign deleted successfully');
void mutate();
} catch (error) {
toast.error(error instanceof Error ? error.message : 'Failed to delete campaign');
} finally {
setCampaignToDelete(null);
}
};
return ( return (
<> <>
<NextSeo title="Campaigns" /> <NextSeo title="Campaigns" />
@@ -266,6 +282,19 @@ export default function CampaignsPage() {
<Copy className="h-4 w-4" /> <Copy className="h-4 w-4" />
</Button> </Button>
{campaign.status === 'DRAFT' && (
<Button
variant="destructive"
size="sm"
onClick={() => {
setCampaignToDelete(campaign.id);
setShowDeleteDialog(true);
}}
>
<Trash2 className="h-4 w-4" />
</Button>
)}
{(campaign.status === 'SCHEDULED' || campaign.status === 'SENDING') && ( {(campaign.status === 'SCHEDULED' || campaign.status === 'SENDING') && (
<Button <Button
variant="destructive" variant="destructive"
@@ -314,6 +343,16 @@ export default function CampaignsPage() {
confirmText="Cancel Campaign" confirmText="Cancel Campaign"
variant="destructive" variant="destructive"
/> />
<ConfirmDialog
open={showDeleteDialog}
onOpenChange={setShowDeleteDialog}
onConfirm={handleDelete}
title="Delete Campaign"
description="Are you sure you want to delete this draft campaign? This action cannot be undone."
confirmText="Delete Campaign"
variant="destructive"
/>
</DashboardLayout> </DashboardLayout>
</> </>
); );
+83 -61
View File
@@ -5,6 +5,7 @@ import {
CardDescription, CardDescription,
CardHeader, CardHeader,
CardTitle, CardTitle,
ConfirmDialog,
Input, Input,
Label, Label,
Select, Select,
@@ -20,7 +21,7 @@ import {EmailSettings} from '../../components/EmailSettings';
import {EmailEditor} from '../../components/EmailEditor'; import {EmailEditor} from '../../components/EmailEditor';
import {network} from '../../lib/network'; import {network} from '../../lib/network';
import {useChangeTracking} from '../../lib/hooks/useChangeTracking'; import {useChangeTracking} from '../../lib/hooks/useChangeTracking';
import {ArrowLeft, Save} from 'lucide-react'; import {ArrowLeft, Save, Trash2} from 'lucide-react';
import Link from 'next/link'; import Link from 'next/link';
import {useRouter} from 'next/router'; import {useRouter} from 'next/router';
import {useEffect, useState} from 'react'; import {useEffect, useState} from 'react';
@@ -38,67 +39,63 @@ export default function TemplateEditorPage() {
revalidateOnFocus: false, revalidateOnFocus: false,
}); });
const [name, setName] = useState(''); const [editedTemplate, setEditedTemplate] = useState<Partial<Template>>({});
const [description, setDescription] = useState('');
const [subject, setSubject] = useState('');
const [from, setFrom] = useState('');
const [fromName, setFromName] = useState('');
const [replyTo, setReplyTo] = useState('');
const [body, setBody] = useState('');
const [type, setType] = useState<'MARKETING' | 'TRANSACTIONAL'>('MARKETING');
const [isSubmitting, setIsSubmitting] = useState(false); const [isSubmitting, setIsSubmitting] = useState(false);
const [hasChanges, setHasChanges] = useState(false); const [hasChanges, setHasChanges] = useState(false);
const [showDeleteDialog, setShowDeleteDialog] = useState(false);
// Load template data into form // Initialize edit fields when template loads
useEffect(() => { useEffect(() => {
if (template) { if (template && Object.keys(editedTemplate).length === 0) {
setName(template.name); setEditedTemplate({
setDescription(template.description ?? ''); name: template.name,
setSubject(template.subject); description: template.description || '',
setFrom(template.from); subject: template.subject,
setFromName(template.fromName ?? ''); body: template.body,
setReplyTo(template.replyTo ?? ''); from: template.from,
setBody(template.body); fromName: template.fromName || '',
setType(template.type); replyTo: template.replyTo || '',
type: template.type,
});
// Reset hasChanges when loading fresh data // Reset hasChanges when loading fresh data
setHasChanges(false); setHasChanges(false);
} }
}, [template]); }, [template, editedTemplate]);
// Track changes // Track changes
useEffect(() => { useEffect(() => {
if (!template) return; if (!template || Object.keys(editedTemplate).length === 0) return;
const changed = const changed =
name !== template.name || editedTemplate.name !== template.name ||
description !== (template.description ?? '') || (editedTemplate.description || '') !== (template.description || '') ||
subject !== template.subject || editedTemplate.subject !== template.subject ||
from !== template.from || editedTemplate.body !== template.body ||
fromName !== (template.fromName ?? '') || editedTemplate.from !== template.from ||
replyTo !== (template.replyTo ?? '') || (editedTemplate.fromName || '') !== (template.fromName || '') ||
body !== template.body || (editedTemplate.replyTo || '') !== (template.replyTo || '') ||
type !== template.type; editedTemplate.type !== template.type;
setHasChanges(changed); setHasChanges(changed);
}, [name, description, subject, from, fromName, replyTo, body, type, template]); }, [editedTemplate, template]);
// Warn before leaving page with unsaved changes // Warn before leaving page with unsaved changes
useChangeTracking(hasChanges); useChangeTracking(hasChanges);
const handleSave = async (e: React.FormEvent) => { const handleSave = async (e?: React.FormEvent) => {
e.preventDefault(); if (e) e.preventDefault();
setIsSubmitting(true); setIsSubmitting(true);
try { try {
await network.fetch<Template, typeof TemplateSchemas.update>('PATCH', `/templates/${id}`, { await network.fetch<Template, typeof TemplateSchemas.update>('PATCH', `/templates/${id}`, {
name, name: editedTemplate.name,
description: description || undefined, description: editedTemplate.description || undefined,
subject, subject: editedTemplate.subject,
body, body: editedTemplate.body,
from, from: editedTemplate.from,
fromName: fromName || undefined, fromName: editedTemplate.fromName || undefined,
replyTo: replyTo || undefined, replyTo: editedTemplate.replyTo || undefined,
type, type: editedTemplate.type,
}); });
// Silent save - no toast notification // Silent save - no toast notification
@@ -111,6 +108,16 @@ export default function TemplateEditorPage() {
} }
}; };
const handleDelete = async () => {
try {
await network.fetch('DELETE', `/templates/${id}`);
toast.success('Template deleted successfully');
void router.push('/templates');
} catch (error) {
toast.error(error instanceof Error ? error.message : 'Failed to delete template');
}
};
if (!template) { if (!template) {
return ( return (
<DashboardLayout> <DashboardLayout>
@@ -155,6 +162,10 @@ export default function TemplateEditorPage() {
<div className="flex items-center gap-3"> <div className="flex items-center gap-3">
{!hasChanges && !isSubmitting && <span className="text-sm text-neutral-500">All changes saved</span>} {!hasChanges && !isSubmitting && <span className="text-sm text-neutral-500">All changes saved</span>}
{hasChanges && !isSubmitting && <span className="text-sm text-amber-600">Unsaved changes</span>} {hasChanges && !isSubmitting && <span className="text-sm text-amber-600">Unsaved changes</span>}
<Button type="button" variant="destructive" onClick={() => setShowDeleteDialog(true)}>
<Trash2 className="h-4 w-4" />
Delete
</Button>
<Button type="submit" disabled={!hasChanges || isSubmitting}> <Button type="submit" disabled={!hasChanges || isSubmitting}>
<Save className="h-4 w-4" /> <Save className="h-4 w-4" />
{isSubmitting ? 'Saving...' : 'Save Changes'} {isSubmitting ? 'Saving...' : 'Save Changes'}
@@ -177,8 +188,8 @@ export default function TemplateEditorPage() {
<Input <Input
id="name" id="name"
type="text" type="text"
value={name} value={editedTemplate.name || ''}
onChange={e => setName(e.target.value)} onChange={e => setEditedTemplate({...editedTemplate, name: e.target.value})}
required required
placeholder="Welcome Email" placeholder="Welcome Email"
/> />
@@ -189,15 +200,18 @@ export default function TemplateEditorPage() {
<Input <Input
id="description" id="description"
type="text" type="text"
value={description} value={editedTemplate.description || ''}
onChange={e => setDescription(e.target.value)} onChange={e => setEditedTemplate({...editedTemplate, description: e.target.value})}
placeholder="Sent to new subscribers" placeholder="Sent to new subscribers"
/> />
</div> </div>
<div> <div>
<Label htmlFor="type">Type *</Label> <Label htmlFor="type">Type *</Label>
<Select value={type} onValueChange={value => setType(value as 'MARKETING' | 'TRANSACTIONAL')}> <Select
value={editedTemplate.type}
onValueChange={value => setEditedTemplate({...editedTemplate, type: value as 'MARKETING' | 'TRANSACTIONAL'})}
>
<SelectTrigger id="type"> <SelectTrigger id="type">
<SelectValue /> <SelectValue />
</SelectTrigger> </SelectTrigger>
@@ -216,8 +230,8 @@ export default function TemplateEditorPage() {
<Input <Input
id="subject" id="subject"
type="text" type="text"
value={subject} value={editedTemplate.subject || ''}
onChange={e => setSubject(e.target.value)} onChange={e => setEditedTemplate({...editedTemplate, subject: e.target.value})}
required required
placeholder="Welcome to our platform!" placeholder="Welcome to our platform!"
/> />
@@ -225,12 +239,12 @@ export default function TemplateEditorPage() {
</div> </div>
<EmailSettings <EmailSettings
from={from} from={editedTemplate.from || ''}
fromName={fromName} fromName={editedTemplate.fromName || ''}
replyTo={replyTo} replyTo={editedTemplate.replyTo || ''}
onFromChange={setFrom} onFromChange={value => setEditedTemplate({...editedTemplate, from: value})}
onFromNameChange={setFromName} onFromNameChange={value => setEditedTemplate({...editedTemplate, fromName: value})}
onReplyToChange={setReplyTo} onReplyToChange={value => setEditedTemplate({...editedTemplate, replyTo: value})}
fromNamePlaceholder={activeProject?.name || 'Your Company'} fromNamePlaceholder={activeProject?.name || 'Your Company'}
showFromNameHelpText showFromNameHelpText
layout="vertical" layout="vertical"
@@ -248,16 +262,13 @@ export default function TemplateEditorPage() {
</CardHeader> </CardHeader>
<CardContent> <CardContent>
<EmailEditor <EmailEditor
value={body} value={editedTemplate.body || ''}
onChange={newBody => { onChange={body => setEditedTemplate({...editedTemplate, body})}
setBody(newBody);
setHasChanges(true);
}}
placeholder="<h1>Welcome!</h1><p>Thanks for subscribing to our newsletter.</p>" placeholder="<h1>Welcome!</h1><p>Thanks for subscribing to our newsletter.</p>"
canUploadImages={true} canUploadImages={true}
subject={subject} subject={editedTemplate.subject}
from={from} from={editedTemplate.from}
replyTo={replyTo} replyTo={editedTemplate.replyTo || undefined}
/> />
</CardContent> </CardContent>
</Card> </Card>
@@ -267,6 +278,17 @@ export default function TemplateEditorPage() {
{/* Sticky Save Bar */} {/* Sticky Save Bar */}
<StickySaveBar hasChanges={hasChanges} isSubmitting={isSubmitting} onSave={handleSave} /> <StickySaveBar hasChanges={hasChanges} isSubmitting={isSubmitting} onSave={handleSave} />
{/* Delete Template Confirmation */}
<ConfirmDialog
open={showDeleteDialog}
onOpenChange={setShowDeleteDialog}
onConfirm={handleDelete}
title="Delete Template"
description="Are you sure you want to delete this template? This action cannot be undone."
confirmText="Delete Template"
variant="destructive"
/>
</DashboardLayout> </DashboardLayout>
); );
} }
+26 -94
View File
@@ -38,7 +38,6 @@ import {
Info, Info,
LogOut, LogOut,
Mail, Mail,
Play,
Plus, Plus,
Power, Power,
PowerOff, PowerOff,
@@ -115,11 +114,11 @@ export default function WorkflowEditorPage() {
const {id} = router.query; const {id} = router.query;
const [activeTab, setActiveTab] = useState<'builder' | 'executions'>('builder'); const [activeTab, setActiveTab] = useState<'builder' | 'executions'>('builder');
const [showSettingsDialog, setShowSettingsDialog] = useState(false); const [showSettingsDialog, setShowSettingsDialog] = useState(false);
const [showTestDialog, setShowTestDialog] = useState(false);
const [editingStep, setEditingStep] = useState<WorkflowStep | null>(null); const [editingStep, setEditingStep] = useState<WorkflowStep | null>(null);
const [showCancelAllDialog, setShowCancelAllDialog] = useState(false); const [showCancelAllDialog, setShowCancelAllDialog] = useState(false);
const [executionToCancel, setExecutionToCancel] = useState<string | null>(null); const [executionToCancel, setExecutionToCancel] = useState<string | null>(null);
const [isCancelling, setIsCancelling] = useState(false); const [isCancelling, setIsCancelling] = useState(false);
const [showDeleteDialog, setShowDeleteDialog] = useState(false);
const {data: workflow, mutate} = useSWR<WorkflowWithDetails>(id ? `/workflows/${id}` : null, { const {data: workflow, mutate} = useSWR<WorkflowWithDetails>(id ? `/workflows/${id}` : null, {
revalidateOnFocus: false, revalidateOnFocus: false,
@@ -326,6 +325,16 @@ export default function WorkflowEditorPage() {
} }
}; };
const handleDelete = async () => {
try {
await network.fetch('DELETE', `/workflows/${id}`);
toast.success('Workflow deleted successfully');
void router.push('/workflows');
} catch (error) {
toast.error(error instanceof Error ? error.message : 'Failed to delete workflow');
}
};
// Listen for edit step events from the WorkflowBuilder // Listen for edit step events from the WorkflowBuilder
useEffect(() => { useEffect(() => {
const handleEditStepEvent = (event: Event) => { const handleEditStepEvent = (event: Event) => {
@@ -406,14 +415,14 @@ export default function WorkflowEditorPage() {
</div> </div>
</div> </div>
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">
<Button variant="outline" onClick={() => setShowTestDialog(true)}>
<Play className="h-4 w-4" />
Test
</Button>
<Button variant="outline" onClick={() => setShowSettingsDialog(true)}> <Button variant="outline" onClick={() => setShowSettingsDialog(true)}>
<Settings className="h-4 w-4" /> <Settings className="h-4 w-4" />
Settings Settings
</Button> </Button>
<Button variant="destructive" onClick={() => setShowDeleteDialog(true)}>
<Trash2 className="h-4 w-4" />
Delete
</Button>
<Button onClick={handleToggleEnabled}> <Button onClick={handleToggleEnabled}>
{workflow.enabled ? ( {workflow.enabled ? (
<> <>
@@ -653,7 +662,6 @@ export default function WorkflowEditorPage() {
onOpenChange={setShowSettingsDialog} onOpenChange={setShowSettingsDialog}
onSave={handleUpdateSettings} onSave={handleUpdateSettings}
/> />
<TestWorkflowDialog open={showTestDialog} onOpenChange={setShowTestDialog} workflowId={id as string} />
{editingStep && ( {editingStep && (
<EditStepDialog <EditStepDialog
step={editingStep} step={editingStep}
@@ -722,6 +730,17 @@ export default function WorkflowEditorPage() {
variant="destructive" variant="destructive"
isLoading={isCancelling} isLoading={isCancelling}
/> />
{/* Delete Workflow Confirmation */}
<ConfirmDialog
open={showDeleteDialog}
onOpenChange={setShowDeleteDialog}
onConfirm={handleDelete}
title="Delete Workflow"
description="Are you sure you want to delete this workflow? This action cannot be undone."
confirmText="Delete Workflow"
variant="destructive"
/>
</> </>
)} )}
</DashboardLayout> </DashboardLayout>
@@ -803,93 +822,6 @@ function SettingsDialog({workflow, open, onOpenChange, onSave}: SettingsDialogPr
); );
} }
// Test Workflow Dialog Component
interface TestWorkflowDialogProps {
open: boolean;
onOpenChange: (open: boolean) => void;
workflowId: string;
}
function TestWorkflowDialog({open, onOpenChange, workflowId}: TestWorkflowDialogProps) {
const [email, setEmail] = useState('');
const [isSubmitting, setIsSubmitting] = useState(false);
const handleSubmit = async (e: React.FormEvent) => {
e.preventDefault();
setIsSubmitting(true);
try {
// First, find or create the contact
const contacts = await network.fetch<{contacts: {id: string; email: string}[]}>(
'GET',
`/contacts?search=${email}`,
);
let contactId = contacts.contacts.find(c => c.email === email)?.id;
if (!contactId) {
const newContact = await network.fetch<{id: string}, typeof ContactSchemas.create>('POST', '/contacts', {
email,
subscribed: true,
});
contactId = newContact.id;
}
// Start workflow execution
await network.fetch<WorkflowExecution, typeof WorkflowSchemas.startExecution>(
'POST',
`/workflows/${workflowId}/executions`,
{
contactId,
},
);
toast.success('Workflow test started successfully');
setEmail('');
onOpenChange(false);
} catch (error) {
toast.error(error instanceof Error ? error.message : 'Failed to start workflow test');
} finally {
setIsSubmitting(false);
}
};
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent>
<DialogHeader>
<DialogTitle>Test Workflow</DialogTitle>
</DialogHeader>
<form onSubmit={handleSubmit} className="space-y-4">
<div>
<Label htmlFor="email">Test Email Address *</Label>
<Input
id="email"
type="email"
value={email}
onChange={e => setEmail(e.target.value)}
required
placeholder="[email protected]"
/>
<p className="text-xs text-neutral-500 mt-1">
The workflow will be executed for this email address. If the contact doesn&apos;t exist, it will be
created.
</p>
</div>
<DialogFooter>
<Button type="button" variant="outline" onClick={() => onOpenChange(false)} disabled={isSubmitting}>
Cancel
</Button>
<Button type="submit" disabled={isSubmitting}>
{isSubmitting ? 'Starting...' : 'Start Test'}
</Button>
</DialogFooter>
</form>
</DialogContent>
</Dialog>
);
}
// Add Step Dialog Component // Add Step Dialog Component
interface AddStepDialogProps { interface AddStepDialogProps {
open: boolean; open: boolean;