From 5afa686a21410863eb725886b60a3b3d2a7c5525 Mon Sep 17 00:00:00 2001 From: Bavisetti Narayan <72156168+NarayanBavisetti@users.noreply.github.com> Date: Wed, 23 Oct 2024 20:11:01 +0530 Subject: [PATCH 1/2] chore: issue attachment deletion (#5903) --- apiserver/plane/app/views/asset/v2.py | 6 +++--- apiserver/plane/app/views/issue/attachment.py | 2 +- apiserver/plane/space/views/asset.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/apiserver/plane/app/views/asset/v2.py b/apiserver/plane/app/views/asset/v2.py index c307bbd4b3..76a9351ea5 100644 --- a/apiserver/plane/app/views/asset/v2.py +++ b/apiserver/plane/app/views/asset/v2.py @@ -209,7 +209,7 @@ class UserAssetsV2Endpoint(BaseAPIView): # update the attributes asset.attributes = request.data.get("attributes", asset.attributes) # save the asset - asset.save() + asset.save(created_by=request.user) return Response(status=status.HTTP_204_NO_CONTENT) def delete(self, request, asset_id): @@ -459,7 +459,7 @@ class WorkspaceFileAssetEndpoint(BaseAPIView): # update the attributes asset.attributes = request.data.get("attributes", asset.attributes) # save the asset - asset.save() + asset.save(created_by=request.user) return Response(status=status.HTTP_204_NO_CONTENT) def delete(self, request, slug, asset_id): @@ -690,7 +690,7 @@ class ProjectAssetEndpoint(BaseAPIView): # update the attributes asset.attributes = request.data.get("attributes", asset.attributes) # save the asset - asset.save() + asset.save(created_by=request.user) return Response(status=status.HTTP_204_NO_CONTENT) @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST]) diff --git a/apiserver/plane/app/views/issue/attachment.py b/apiserver/plane/app/views/issue/attachment.py index 1fb230a553..2ec40f5b80 100644 --- a/apiserver/plane/app/views/issue/attachment.py +++ b/apiserver/plane/app/views/issue/attachment.py @@ -257,5 +257,5 @@ class IssueAttachmentV2Endpoint(BaseAPIView): # Get the storage metadata if not issue_attachment.storage_metadata: get_asset_object_metadata.delay(str(issue_attachment.id)) - issue_attachment.save() + issue_attachment.save(created_by=request.user) return Response(status=status.HTTP_204_NO_CONTENT) diff --git a/apiserver/plane/space/views/asset.py b/apiserver/plane/space/views/asset.py index 0ffe20ce7e..631866d557 100644 --- a/apiserver/plane/space/views/asset.py +++ b/apiserver/plane/space/views/asset.py @@ -169,7 +169,7 @@ class EntityAssetEndpoint(BaseAPIView): # update the attributes asset.attributes = request.data.get("attributes", asset.attributes) # save the asset - asset.save() + asset.save(created_by=request.user) return Response(status=status.HTTP_204_NO_CONTENT) def delete(self, request, anchor, pk): From 56bb6e1f48fe6f0225998171b118f763778f1dce Mon Sep 17 00:00:00 2001 From: Anmol Singh Bhatia <121005188+anmolsinghbhatia@users.noreply.github.com> Date: Wed, 23 Oct 2024 20:11:28 +0530 Subject: [PATCH 2/2] fix: draft issue type update outside click (#5902) --- web/core/components/issues/issue-modal/base.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/core/components/issues/issue-modal/base.tsx b/web/core/components/issues/issue-modal/base.tsx index ab0d988709..315dbde379 100644 --- a/web/core/components/issues/issue-modal/base.tsx +++ b/web/core/components/issues/issue-modal/base.tsx @@ -204,7 +204,7 @@ export const CreateUpdateIssueModalBase: React.FC = observer(( issueTypeId: response.type_id, projectId: response.project_id, workspaceSlug: workspaceSlug.toString(), - isDraft: isDraft, + isDraft: is_draft_issue, }); }