* fix: remove @calcom/web imports from packages/features to eliminate circular dependency - Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts - Migrate useGeo hook to packages/features/geo/GeoContext.tsx - Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts - Migrate Calendar component to packages/features/calendars/weeklyview/components/ - Move test utilities (bookingScenario, fixtures) to packages/features/test/ - Update all imports in packages/features to use new locations - Add re-exports in apps/web for backward compatibility Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: delete original implementation files and fix type issues - Delete original calendar component files in apps/web (keep only re-export stubs) - Migrate OutOfOfficeInSlots to packages/features/bookings/components - Convert apps/web OutOfOfficeInSlots to re-export stub - Fix className vs class issue in Calendar.tsx - Fix @calcom/trpc import violation in user-table.ts by using structural type Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: add missing isGroup and contains fields to UserTableUser attributes type Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: update customRole type to match actual Prisma Role model Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix build * fix * fix * cleanup weeklyview * fix * refactor to mv MemberPermissions to types package * add types dependency to features * fix * fix * fix * fix * fix * fix * rename * rename * migrate * migrate * migrate * fix * fix * fix * refactor: move test utilities from packages/features/test to tests/libs - Move bookingScenario utilities to tests/libs/bookingScenario - Move fixtures to tests/libs/fixtures - Update all imports in packages/features test files to use new location - Update all imports in apps/web test files to use new location - Eliminates duplication of test utilities between packages/features and apps/web Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: correct relative import paths for tests/libs in test files Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * refactor: replace test utility implementations with re-exports to tests/libs Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: fix test import paths and move signup handler tests to apps/web Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: move buildLegacyCtx to packages/lib and restore handlers to packages/features - Move buildLegacyCtx from apps/web/lib to packages/lib to break circular dependency - Update apps/web/lib/buildLegacyCtx.ts to re-export from @calcom/lib - Restore signup handlers and tests to packages/features/auth/signup/handlers - Update handler imports to use @calcom/lib/buildLegacyCtx instead of @calcom/web/lib/buildLegacyCtx Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: update recurring-event.test.ts imports to use tests/libs path Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * refactor: delete test re-export files and update imports to use tests/libs directly Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: update remaining test imports to use tests/libs directly Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: update handleRecurringEventBooking calls to match function signature (1 arg) Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * remove * migrate tests * migrate tests * refactor: update test mock imports by removing and using async for mock creators. * fix type errors * fix: add type assertion for MockUser in p2002.test-suite.ts Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: restore locale import in compareReminderBodyToTemplate.test.ts using relative path Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * feat: create @calcom/testing package and migrate tests from /tests directory - Created new @calcom/testing package in /packages/testing - Moved all files from /tests to /packages/testing - Updated all imports across the codebase to use @calcom/testing alias - Removed /tests directory at root level This allows other packages like @calcom/features and @calcom/web to import testing utilities using the @calcom/testing alias instead of relative paths. Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix * fix * fix: add missing useBookings export to @calcom/atoms package Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: add missing useCalendarsBusyTimes and useConnectedCalendars exports to @calcom/atoms Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * chore: add @calcom/testing as explicit devDependency to packages that use it Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * refactor: move setupVitest.ts into @calcom/testing package Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix * chore: add biome rules to restrict @calcom/testing imports Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix * rename libs to lib * rename libs to lib * add rule * add rule * refactor: remove @calcom/features imports from @calcom/testing - Move mockPaymentSuccessWebhookFromStripe to fresh-booking.test.ts - Replace ProfileRepository.generateProfileUid() with uuidv4() - Clone Tracking type into @calcom/testing/src/lib/types.ts - Update imports in expects.ts and getMockRequestDataForBooking.ts - Move source files into src/ folder - Move CalendarManager mock to @calcom/features Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * fix: add explicit exports for nested paths in @calcom/testing Co-Authored-By: benny@cal.com <sldisek783@gmail.com> * improve * improve * fix * fix * fix type checks * fix type checks * fix type checks * fix tests --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
531 lines
16 KiB
TypeScript
531 lines
16 KiB
TypeScript
import prismock from "@calcom/testing/lib/__mocks__/prisma";
|
|
|
|
import { v4 } from "uuid";
|
|
import { describe, expect, it, vi, beforeEach } from "vitest";
|
|
|
|
import { getCRMContactOwnerForRRLeadSkip } from "@calcom/app-store/_utils/CRMRoundRobinSkip";
|
|
import bookingFormHandlers from "@calcom/app-store/routing-forms/appBookingFormHandler";
|
|
import {
|
|
ROUTING_FORM_RESPONSE_ID_QUERY_STRING,
|
|
ROUTING_FORM_QUEUED_RESPONSE_ID_QUERY_STRING,
|
|
} from "@calcom/app-store/routing-forms/lib/constants";
|
|
import { RouteActionType } from "@calcom/app-store/routing-forms/zod";
|
|
import { getTeamMemberEmailForResponseOrContactUsingUrlQuery } from "@calcom/features/ee/teams/lib/getTeamMemberEmailFromCrm";
|
|
import { SchedulingType } from "@calcom/prisma/enums";
|
|
|
|
vi.mock("@calcom/app-store/routing-forms/appBookingFormHandler", () => ({
|
|
default: {
|
|
salesforce: vi.fn(),
|
|
},
|
|
}));
|
|
|
|
vi.mock("@calcom/app-store/_utils/CRMRoundRobinSkip", () => ({
|
|
getCRMContactOwnerForRRLeadSkip: vi.fn(),
|
|
}));
|
|
|
|
function mockGetCRMContactOwnerForRRLeadSkip({
|
|
bookerEmail,
|
|
teamMemberEmail,
|
|
}: {
|
|
bookerEmail: string;
|
|
teamMemberEmail: string;
|
|
}) {
|
|
vi.mocked(getCRMContactOwnerForRRLeadSkip).mockImplementation((_bookerEmail, _eventMetadata) => {
|
|
if (_bookerEmail === bookerEmail) {
|
|
return Promise.resolve({ email: teamMemberEmail, recordType: null, crmAppSlug: null, recordId: null });
|
|
}
|
|
return Promise.resolve({ email: null, recordType: null, crmAppSlug: null, recordId: null });
|
|
});
|
|
}
|
|
|
|
function mockBookingFormHandler({
|
|
bookerEmail,
|
|
teamMemberEmail,
|
|
}: {
|
|
bookerEmail: string;
|
|
teamMemberEmail: string;
|
|
}) {
|
|
vi.mocked(bookingFormHandlers.salesforce).mockImplementation(
|
|
(_bookerEmail, _attributeRoutingConfig, _eventTypeId) => {
|
|
if (_bookerEmail === bookerEmail) {
|
|
return Promise.resolve({ email: teamMemberEmail, recordType: null, recordId: null });
|
|
}
|
|
return Promise.resolve({ email: null, recordType: null, recordId: null });
|
|
}
|
|
);
|
|
}
|
|
|
|
type RoutingFormData = {
|
|
routes: {
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
queryValue?: any;
|
|
action: {
|
|
eventTypeId: number;
|
|
type: RouteActionType;
|
|
value: string;
|
|
};
|
|
attributeRoutingConfig: {
|
|
skipContactOwner: boolean;
|
|
};
|
|
}[];
|
|
};
|
|
|
|
async function _createRoutingFormBase({ formData }: { formData: RoutingFormData }) {
|
|
const user = await prismock.user.create({
|
|
data: {
|
|
name: "Routing Form User",
|
|
username: "routing-form-user",
|
|
email: "routing-form-user@example.com",
|
|
},
|
|
});
|
|
|
|
const routeId = v4();
|
|
|
|
const form = await prismock.app_RoutingForms_Form.create({
|
|
data: {
|
|
...formData,
|
|
name: "Test Form",
|
|
routes: formData.routes.map((route) => ({
|
|
queryValue: {
|
|
id: v4(),
|
|
type: "group",
|
|
},
|
|
id: routeId,
|
|
...route,
|
|
})),
|
|
user: {
|
|
connect: {
|
|
id: user.id,
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
return { form, routeId };
|
|
}
|
|
|
|
async function createRoutingFormWithResponse({ formData }: { formData: RoutingFormData }) {
|
|
const { form, routeId } = await _createRoutingFormBase({ formData });
|
|
|
|
const responseRecord = await prismock.app_RoutingForms_FormResponse.create({
|
|
data: {
|
|
chosenRouteId: routeId,
|
|
response: {},
|
|
form: {
|
|
connect: {
|
|
id: form.id,
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
return { form, responseRecord };
|
|
}
|
|
|
|
async function createRoutingFormWithQueuedResponse({ formData }: { formData: RoutingFormData }) {
|
|
const { form, routeId } = await _createRoutingFormBase({ formData });
|
|
|
|
const queuedResponseId = v4();
|
|
const queuedResponseRecord = await prismock.app_RoutingForms_QueuedFormResponse.create({
|
|
data: {
|
|
id: queuedResponseId,
|
|
chosenRouteId: routeId,
|
|
response: {},
|
|
form: {
|
|
connect: {
|
|
id: form.id,
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
return { form, queuedResponseRecord };
|
|
}
|
|
|
|
async function createHostForEvent({
|
|
eventTypeData,
|
|
userData,
|
|
}: {
|
|
eventTypeData: { id: number } & Partial<{
|
|
title: string;
|
|
slug: string;
|
|
length: number;
|
|
}>;
|
|
userData: {
|
|
email: string;
|
|
} & Partial<{
|
|
name: string;
|
|
username: string;
|
|
}>;
|
|
}) {
|
|
const user = await prismock.user.create({
|
|
data: {
|
|
name: "Test User",
|
|
username: "testuser",
|
|
...userData,
|
|
},
|
|
});
|
|
await prismock.eventType.create({
|
|
data: {
|
|
title: "Title",
|
|
slug: "slug",
|
|
length: 30,
|
|
...eventTypeData,
|
|
hosts: {
|
|
create: {
|
|
userId: user.id,
|
|
isFixed: true,
|
|
},
|
|
},
|
|
},
|
|
});
|
|
}
|
|
|
|
describe("getTeamMemberEmailForResponseOrContactUsingUrlQuery", () => {
|
|
beforeEach(() => {
|
|
vi.resetAllMocks();
|
|
});
|
|
|
|
const mockEventData = {
|
|
id: 1,
|
|
isInstantEvent: false,
|
|
schedulingType: SchedulingType.ROUND_ROBIN,
|
|
metadata: null,
|
|
length: 30,
|
|
hosts: [
|
|
{
|
|
user: {
|
|
email: "owner@example.com",
|
|
},
|
|
},
|
|
],
|
|
};
|
|
|
|
it("should return null when email is not provided in query", async () => {
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: {},
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
const ownerEmail = result.email;
|
|
|
|
expect(ownerEmail).toBeNull();
|
|
});
|
|
|
|
it("should return null when scheduling type is not ROUND_ROBIN", async () => {
|
|
const bookerEmail = "booker@example.com";
|
|
const teamMemberEmail = "teamMember@example.com";
|
|
mockGetCRMContactOwnerForRRLeadSkip({ bookerEmail, teamMemberEmail });
|
|
await createHostForEvent({
|
|
eventTypeData: {
|
|
id: mockEventData.id,
|
|
},
|
|
userData: {
|
|
email: teamMemberEmail,
|
|
},
|
|
});
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: { email: bookerEmail },
|
|
eventData: { ...mockEventData, schedulingType: SchedulingType.COLLECTIVE },
|
|
});
|
|
|
|
expect(result.email).toBeNull();
|
|
});
|
|
|
|
it("should return CRM owner email when valid", async () => {
|
|
const ownerEmail = "owner@example.com";
|
|
const bookerEmail = "booker@example.com";
|
|
mockGetCRMContactOwnerForRRLeadSkip({ bookerEmail, teamMemberEmail: ownerEmail });
|
|
await createHostForEvent({
|
|
eventTypeData: {
|
|
id: mockEventData.id,
|
|
},
|
|
userData: {
|
|
email: ownerEmail,
|
|
},
|
|
});
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: { email: "booker@example.com" },
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
expect(result.email).toBe(ownerEmail);
|
|
});
|
|
|
|
it("should return null when CRM owner is not found", async () => {
|
|
const bookerEmail = "booker@example.com";
|
|
const teamMemberEmail = "teamMember@example.com";
|
|
mockGetCRMContactOwnerForRRLeadSkip({ bookerEmail, teamMemberEmail });
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: { email: bookerEmail },
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
expect(result.email).toBeNull();
|
|
});
|
|
|
|
it("should return null when CRM owner is not part of event type", async () => {
|
|
const ownerEmail = "ownerNotInEventType@example.com";
|
|
const bookerEmail = "booker@example.com";
|
|
mockGetCRMContactOwnerForRRLeadSkip({ bookerEmail, teamMemberEmail: ownerEmail });
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: { email: bookerEmail },
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
expect(result.email).toBeNull();
|
|
});
|
|
|
|
describe("Booking form handler", () => {
|
|
describe("when responseId is provided", () => {
|
|
it("should return teamMember email through booking form handler when cal.routingFormResponseId and cal.salesforce.xxxx=true is provided", async () => {
|
|
const bookerEmail = "booker@example.com";
|
|
const teamMemberEmail = "owner@example.com";
|
|
mockBookingFormHandler({ bookerEmail, teamMemberEmail });
|
|
await createHostForEvent({
|
|
eventTypeData: {
|
|
id: mockEventData.id,
|
|
},
|
|
userData: {
|
|
email: teamMemberEmail,
|
|
},
|
|
});
|
|
|
|
const { responseRecord } = await createRoutingFormWithResponse({
|
|
formData: {
|
|
routes: [
|
|
{
|
|
action: {
|
|
eventTypeId: 1,
|
|
type: RouteActionType.EventTypeRedirectUrl,
|
|
value: "/team/sales",
|
|
},
|
|
attributeRoutingConfig: { skipContactOwner: false },
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: {
|
|
email: bookerEmail,
|
|
[ROUTING_FORM_RESPONSE_ID_QUERY_STRING]: responseRecord.id.toString(),
|
|
"cal.salesforce.xxx": "true",
|
|
},
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
expect(result.email).toBe(teamMemberEmail);
|
|
});
|
|
|
|
it("should return null when skipContactOwner is true even when cal.routingFormResponseId and cal.salesforce.xxxx=true is provided", async () => {
|
|
const bookerEmail = "booker@example.com";
|
|
const teamMemberEmail = "owner@example.com";
|
|
mockBookingFormHandler({ bookerEmail, teamMemberEmail });
|
|
await createHostForEvent({
|
|
eventTypeData: {
|
|
id: mockEventData.id,
|
|
},
|
|
userData: {
|
|
email: teamMemberEmail,
|
|
},
|
|
});
|
|
|
|
const { responseRecord } = await createRoutingFormWithResponse({
|
|
formData: {
|
|
routes: [
|
|
{
|
|
action: {
|
|
eventTypeId: 1,
|
|
type: RouteActionType.EventTypeRedirectUrl,
|
|
value: "/team/sales",
|
|
},
|
|
attributeRoutingConfig: { skipContactOwner: true },
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: {
|
|
email: bookerEmail,
|
|
[ROUTING_FORM_RESPONSE_ID_QUERY_STRING]: responseRecord.id.toString(),
|
|
"cal.salesforce.xxx": "true",
|
|
},
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
// Because skipContactOwner is true, the booking form handler should return null
|
|
expect(result.email).toBe(null);
|
|
});
|
|
|
|
it("should return null when when cal.routingFormResponseId and cal.salesforce.xxxx=true is provided but the returned email isn't an event member", async () => {
|
|
const bookerEmail = "booker@example.com";
|
|
const teamMemberEmail = "ownerNotInEventType@example.com";
|
|
mockBookingFormHandler({ bookerEmail, teamMemberEmail });
|
|
const SOME_OTHER_EVENT_ID = 200;
|
|
await createHostForEvent({
|
|
eventTypeData: {
|
|
id: SOME_OTHER_EVENT_ID,
|
|
},
|
|
userData: {
|
|
email: teamMemberEmail,
|
|
},
|
|
});
|
|
|
|
const { responseRecord } = await createRoutingFormWithResponse({
|
|
formData: {
|
|
routes: [
|
|
{
|
|
action: {
|
|
eventTypeId: 1,
|
|
type: RouteActionType.EventTypeRedirectUrl,
|
|
value: "/team/sales",
|
|
},
|
|
attributeRoutingConfig: { skipContactOwner: false },
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: {
|
|
email: bookerEmail,
|
|
[ROUTING_FORM_RESPONSE_ID_QUERY_STRING]: responseRecord.id.toString(),
|
|
"cal.salesforce.xxx": "true",
|
|
},
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
expect(result.email).toBe(null);
|
|
});
|
|
|
|
it("should return null when cal.routingFormResponseId is provided but cal.salesforce.xxxx is not", async () => {
|
|
const bookerEmail = "booker@example.com";
|
|
const teamMemberEmail = "owner@example.com";
|
|
mockBookingFormHandler({ bookerEmail, teamMemberEmail });
|
|
await createHostForEvent({
|
|
eventTypeData: {
|
|
id: mockEventData.id,
|
|
},
|
|
userData: {
|
|
email: teamMemberEmail,
|
|
},
|
|
});
|
|
|
|
const { responseRecord } = await createRoutingFormWithResponse({
|
|
formData: {
|
|
routes: [
|
|
{
|
|
action: {
|
|
eventTypeId: 1,
|
|
type: RouteActionType.EventTypeRedirectUrl,
|
|
value: "/team/sales",
|
|
},
|
|
attributeRoutingConfig: { skipContactOwner: false },
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: {
|
|
email: bookerEmail,
|
|
[ROUTING_FORM_RESPONSE_ID_QUERY_STRING]: responseRecord.id.toString(),
|
|
"cal.somethingelse.xxx": "true",
|
|
},
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
expect(result.email).toBe(null);
|
|
});
|
|
});
|
|
describe("when queuedFormResponseId is provided", () => {
|
|
it("should return teamMember email through booking form handler when cal.queuedFormResponseId and cal.salesforce.xxxx=true is provided", async () => {
|
|
const bookerEmail = "booker@example.com";
|
|
const teamMemberEmail = "owner@example.com";
|
|
mockBookingFormHandler({ bookerEmail, teamMemberEmail });
|
|
await createHostForEvent({
|
|
eventTypeData: {
|
|
id: mockEventData.id,
|
|
},
|
|
userData: {
|
|
email: teamMemberEmail,
|
|
},
|
|
});
|
|
|
|
const { queuedResponseRecord } = await createRoutingFormWithQueuedResponse({
|
|
formData: {
|
|
routes: [
|
|
{
|
|
action: {
|
|
eventTypeId: 1,
|
|
type: RouteActionType.EventTypeRedirectUrl,
|
|
value: "/team/sales",
|
|
},
|
|
attributeRoutingConfig: { skipContactOwner: false },
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: {
|
|
email: bookerEmail,
|
|
[ROUTING_FORM_QUEUED_RESPONSE_ID_QUERY_STRING]: queuedResponseRecord.id,
|
|
"cal.salesforce.xxx": "true",
|
|
},
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
expect(result.email).toBe(teamMemberEmail);
|
|
});
|
|
|
|
it("should return null when skipContactOwner is true even when cal.queuedFormResponseId and cal.salesforce.xxxx=true is provided", async () => {
|
|
const bookerEmail = "booker@example.com";
|
|
const teamMemberEmail = "owner@example.com";
|
|
mockBookingFormHandler({ bookerEmail, teamMemberEmail });
|
|
await createHostForEvent({
|
|
eventTypeData: {
|
|
id: mockEventData.id,
|
|
},
|
|
userData: {
|
|
email: teamMemberEmail,
|
|
},
|
|
});
|
|
|
|
const { queuedResponseRecord } = await createRoutingFormWithQueuedResponse({
|
|
formData: {
|
|
routes: [
|
|
{
|
|
action: {
|
|
eventTypeId: 1,
|
|
type: RouteActionType.EventTypeRedirectUrl,
|
|
value: "/team/sales",
|
|
},
|
|
attributeRoutingConfig: { skipContactOwner: true },
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
const result = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({
|
|
query: {
|
|
email: bookerEmail,
|
|
[ROUTING_FORM_QUEUED_RESPONSE_ID_QUERY_STRING]: queuedResponseRecord.id,
|
|
"cal.salesforce.xxx": "true",
|
|
},
|
|
eventData: mockEventData,
|
|
});
|
|
|
|
// Because skipContactOwner is true, the booking form handler should return null
|
|
expect(result.email).toBe(null);
|
|
});
|
|
});
|
|
});
|
|
});
|